-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not start the PASE Session establishement before device scan succeeds #23638
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
vivien-apple:BLEPaseSessionEstablishementStartsBeforeDeviceScanIsDone
Nov 21, 2022
Merged
Do not start the PASE Session establishement before device scan succeeds #23638
Damian-Nordic
merged 1 commit into
project-chip:master
from
vivien-apple:BLEPaseSessionEstablishementStartsBeforeDeviceScanIsDone
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
November 16, 2022 17:40
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 16, 2022 17:40
PR #23638: Size comparison from d2ae082 to 1fac81d Increases (7 builds for bl602, bl702, linux, psoc6, telink)
Decreases (2 builds for telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 16, 2022
Damian-Nordic
requested changes
Nov 17, 2022
vivien-apple
force-pushed
the
BLEPaseSessionEstablishementStartsBeforeDeviceScanIsDone
branch
from
November 21, 2022 10:24
1fac81d
to
2f32b7c
Compare
vivien-apple
force-pushed
the
BLEPaseSessionEstablishementStartsBeforeDeviceScanIsDone
branch
from
November 21, 2022 10:50
2f32b7c
to
1f0c86b
Compare
PR #23638: Size comparison from 494f5f5 to 1f0c86b Increases (6 builds for bl602, cyw30739, esp32, linux, nrfconnect, psoc6)
Decreases (7 builds for bl602, esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23438