Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove using-directives namespaces in Tizen platform [ Tizen ] #23637

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Remove using-directives namespaces in Tizen platform [ Tizen ] #23637

merged 2 commits into from
Nov 17, 2022

Conversation

DamMicSzm
Copy link
Contributor

Problem

Using using-directives (e.g., using namespace foo) is not recommended. Some files in Tizen platform using this directives. Google style guide: https://google.github.io/styleguide/cppguide.html#Namespaces

Changes

Removed using-directives from src/platform/Tizen/* for more quality code.

Testing

Testing is not needed.

@github-actions
Copy link

github-actions bot commented Nov 16, 2022 •
edited
Loading

PR #23637: Size comparison from 26e3636 to a853426

Increases (5 builds for bl602, psoc6, telink)
platform target config section 26e3636 a853426 change % change
bl602 lighting-app bl602 (read/write) 1375250 1375258 8 0.0
.text 1059184 1059186 2 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26760523 26760524 1 0.0
light cy8ckit_062s2_43012 .debug_info 22225723 22225724 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 612686 612688 2 0.0
ota-requestor-app tlsr9518adk80d text 565530 565532 2 0.0
Decreases (5 builds for bl702, esp32, psoc6, telink)
platform target config section 26e3636 a853426 change % change
bl702 lighting-app bl702 .debug_info 39161306 39161305 -1 -0.0
.text 955516 955514 -2 -0.0
esp32 all-clusters-app m5stack (read/write) 564420 564412 -8 -0.0
.flash.rodata 315136 315128 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22459348 22459347 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 790700 790692 -8 -0.0
text 554150 554148 -2 -0.0
lighting-app tlsr9518adk80d text 624114 624112 -2 -0.0
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 26e3636 a853426 change % change
bl602 lighting-app bl602 (read/write) 1375250 1375258 8 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059184 1059186 2 0.0
bl602+rpc (read/write) 1421074 1421074 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1090678 1090678 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195127 1195127 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1523919 1523919 0 0.0
.debug_aranges 132304 132304 0 0.0
.debug_frame 485212 485212 0 0.0
.debug_info 39161306 39161305 -1 -0.0
.debug_line 5271709 5271709 0 0.0
.debug_loc 3367110 3367110 0 0.0
.debug_ranges 360272 360272 0 0.0
.debug_str 3462160 3462160 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566531 566531 0 0.0
.symtab 171808 171808 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955516 955514 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283267 1283267 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1667931 1667931 0 0.0
.debug_aranges 140368 140368 0 0.0
.debug_frame 512416 512416 0 0.0
.debug_info 43430528 43430528 0 0.0
.debug_line 5667078 5667078 0 0.0
.debug_loc 3561346 3561346 0 0.0
.debug_ranges 383296 383296 0 0.0
.debug_str 3859469 3859469 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130120 130120 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 626746 626746 0 0.0
.symtab 189920 189920 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029214 1029214 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678163 678163 0 0.0
(read/write) 173372 173372 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588000 588000 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642459 642459 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563152 563152 0 0.0
lock-ftd LP_CC2652R7 (read only) 676295 676295 0 0.0
(read/write) 172808 172808 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598544 598544 0 0.0
lock-mtd LP_CC2652R7 (read only) 660819 660819 0 0.0
(read/write) 183540 183540 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103307 103307 0 0.0
.text 557032 557032 0 0.0
pump-app LP_CC2652R7 (read only) 688743 688743 0 0.0
(read/write) 161096 161096 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90759 90759 0 0.0
.text 597500 597500 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673027 673027 0 0.0
(read/write) 176908 176908 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86307 86307 0 0.0
.text 586240 586240 0 0.0
shell LP_CC2652R7 (read only) 669382 669382 0 0.0
(read/write) 184472 184472 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582468 582468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587230 587230 0 0.0
.app_xip_area 463440 463440 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591338 591338 0 0.0
.app_xip_area 462252 462252 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543714 543714 0 0.0
.app_xip_area 425444 425444 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974172 974172 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 819724 819724 0 0.0
BRD4161A+rs911x (read/write) 1034744 1034744 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 845972 845972 0 0.0
BRD4187C (read/write) 1146576 1146576 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 980808 980808 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160144 1160144 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 999836 999836 0 0.0
window-app BRD4187C (read/write) 1139812 1139812 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 972604 972604 0 0.0
esp32 all-clusters-app c3devkit (read only) 1224290 1224290 0 0.0
(read/write) 1788606 1788606 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258176 258176 0 0.0
.flash.text 1224290 1224290 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234187 1234187 0 0.0
(read/write) 564420 564412 -8 -0.0
.dram0.bss 82320 82320 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315136 315128 -8 -0.0
.flash.text 1228803 1228803 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661796 661796 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563468 563468 0 0.0
light k32w0+release (read/write) 671800 671800 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592100 592100 0 0.0
lock k32w0+release (read/write) 633356 633356 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 552876 552876 0 0.0
linux all-clusters-app debug (read only) 3085417 3085417 0 0.0
(read/write) 158312 158312 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 86984 86984 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 280939 280939 0 0.0
.text 2620274 2620274 0 0.0
all-clusters-minimal-app debug (read only) 2911113 2911113 0 0.0
(read/write) 149712 149712 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79352 79352 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280427 280427 0 0.0
.text 2449522 2449522 0 0.0
bridge-app debug+rpc (read only) 2410065 2410065 0 0.0
(read/write) 129448 129448 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68616 68616 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210688 210688 0 0.0
.text 2032306 2032306 0 0.0
chip-tool debug (read only) 11079241 11079241 0 0.0
(read/write) 658304 658304 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623040 623040 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 591837 591837 0 0.0
.text 8963988 8963988 0 0.0
chip-tool-ipv6only arm64 (read only) 10433596 10433596 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650672 650672 0 0.0
.dynamic 560 560 0 0.0
.got 13912 13912 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8260020 8260020 0 0.0
lighting-app debug+rpc (read only) 2641089 2641089 0 0.0
(read/write) 132296 132296 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73832 73832 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227552 227552 0 0.0
.text 2237122 2237122 0 0.0
lock-app debug (read only) 2600329 2600329 0 0.0
(read/write) 127216 127216 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70680 70680 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 243848 243848 0 0.0
.text 2185058 2185058 0 0.0
ota-provider-app debug (read only) 2396497 2396497 0 0.0
(read/write) 120744 120744 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64600 64600 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216328 216328 0 0.0
.text 2011906 2011906 0 0.0
ota-requestor-app debug (read only) 2561809 2561809 0 0.0
(read/write) 129088 129088 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 69960 69960 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223408 223408 0 0.0
.text 2161042 2161042 0 0.0
shell debug (read only) 2621521 2621521 0 0.0
(read/write) 142808 142808 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77880 77880 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239250 239250 0 0.0
.text 2223042 2223042 0 0.0
thermostat-no-ble arm64 (read only) 2392812 2392812 0 0.0
(read/write) 143489 143489 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77096 77096 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144788 144788 0 0.0
.text 2004560 2004560 0 0.0
tv-app debug (read only) 3254881 3254881 0 0.0
(read/write) 261832 261832 0 0.0
.bss 170648 170648 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80224 80224 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268216 268216 0 0.0
.text 2792962 2792962 0 0.0
tv-casting-app debug (read only) 5580961 5580961 0 0.0
(read/write) 161720 161720 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101056 101056 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 355001 355001 0 0.0
.text 4950578 4950578 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452336 2452336 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1414980 1414980 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187855 1187855 0 0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 816982 816982 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167283 1167283 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805532 805532 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746244 1746244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235716 1235716 0 0.0
.debug_aranges 110704 110704 0 0.0
.debug_frame 371284 371284 0 0.0
.debug_info 27023893 27023893 0 0.0
.debug_line 3685941 3685941 0 0.0
.debug_loc 3603774 3603774 0 0.0
.debug_ranges 339544 339544 0 0.0
.debug_str 3431051 3431051 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570257 570257 0 0.0
.symtab 421440 421440 0 0.0
.text 0 0 0 0.0
1546480 1546480 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1688780 1688780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227559 1227559 0 0.0
.debug_aranges 110176 110176 0 0.0
.debug_frame 374364 374364 0 0.0
.debug_info 26760523 26760524 1 0.0
.debug_line 3706925 3706925 0 0.0
.debug_loc 3591380 3591380 0 0.0
.debug_ranges 338160 338160 0 0.0
.debug_str 3420071 3420071 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534346 534346 0 0.0
.symtab 407872 407872 0 0.0
.text 1489752 1489752 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1606956 1606956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062020 1062020 0 0.0
.debug_aranges 102376 102376 0 0.0
.debug_frame 344676 344676 0 0.0
.debug_info 22225723 22225724 1 0.0
.debug_line 3276050 3276050 0 0.0
.debug_loc 3288865 3288865 0 0.0
.debug_ranges 303440 303440 0 0.0
.debug_str 3225606 3225606 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470671 470671 0 0.0
.symtab 376240 376240 0 0.0
.text 1416112 1416112 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640964 1640964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1063995 1063995 0 0.0
.debug_aranges 102776 102776 0 0.0
.debug_frame 346552 346552 0 0.0
.debug_info 22459348 22459347 -1 -0.0
.debug_line 3273170 3273170 0 0.0
.debug_loc 3316718 3316718 0 0.0
.debug_ranges 305400 305400 0 0.0
.debug_str 3244977 3244977 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473074 473074 0 0.0
.symtab 377936 377936 0 0.0
.text 1445128 1445128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149304 1149304 0 0.0
.bss 109860 109860 0 0.0
.data 848 848 0 0.0
.text 596404 596404 0 0.0
lock-app qpg6105+debug (read/write) 1115004 1115004 0 0.0
.bss 105308 105308 0 0.0
.data 836 836 0 0.0
.text 562100 562100 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937344 937344 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 648700 648700 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875344 875344 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 612686 612688 2 0.0
light-switch-app tlsr9518adk80d (read/write) 790700 790692 -8 -0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554150 554148 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 874924 874924 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624114 624112 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805192 805192 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565530 565532 2 0.0

andy31415
andy31415 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. I would note though that using in cpp files should be fine, it should be banned just in headers.

@arkq
Copy link
Contributor

arkq commented Nov 17, 2022

I would note though that using in cpp files should be fine, it should be banned just in headers.

Yes, you are right. But we are struggling with include-what-you-use (related with #23092) usage, and it seems that the IWYU is confused by using namespace xxx - it tries to find a header defining xxx. So, it will be easier to adopt IWYU for matter codebase without using namespace statements.

@arkq arkq force-pushed the remove-using-namespaces branch from a853426 to 8835082 Compare November 17, 2022 07:53
@arkq
Copy link
Contributor

arkq commented Nov 17, 2022

I've just applied restyle patch

@arkq arkq enabled auto-merge (squash) November 17, 2022 07:55
auto-merge was automatically disabled November 17, 2022 07:59

Head branch was pushed to by a user without write access

@DamMicSzm DamMicSzm force-pushed the remove-using-namespaces branch from 8835082 to 13cefc3 Compare November 17, 2022 07:59
@arkq arkq enabled auto-merge (squash) November 17, 2022 08:06
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

PR #23637: Size comparison from cf45410 to 13cefc3

Increases (5 builds for bl702, esp32, psoc6, telink)
platform target config section cf45410 13cefc3 change % change
bl702 lighting-app bl702 (read/write) 1195687 1195703 16 0.0
.debug_info 39163596 39163597 1 0.0
.text 956000 956002 2 0.0
esp32 all-clusters-app m5stack (read/write) 562500 562508 8 0.0
.flash.rodata 313480 313488 8 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26763962 26763964 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22462797 22462798 1 0.0
telink ota-requestor-app tlsr9518adk80d text 565882 565884 2 0.0
Decreases (2 builds for bl602, esp32)
platform target config section cf45410 13cefc3 change % change
bl602 lighting-app bl602 .text 1059742 1059740 -2 -0.0
esp32 all-clusters-app c3devkit (read only) 1213488 1213486 -2 -0.0
(read/write) 1786542 1786534 -8 -0.0
.flash.rodata 256368 256360 -8 -0.0
.flash.text 1213488 1213486 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section cf45410 13cefc3 change % change
bl602 lighting-app bl602 (read/write) 1375890 1375890 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059742 1059740 -2 -0.0
bl602+rpc (read/write) 1421714 1421714 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1091236 1091236 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195687 1195703 16 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524109 1524109 0 0.0
.debug_aranges 132328 132328 0 0.0
.debug_frame 485344 485344 0 0.0
.debug_info 39163596 39163597 1 0.0
.debug_line 5273272 5273272 0 0.0
.debug_loc 3368326 3368326 0 0.0
.debug_ranges 360440 360440 0 0.0
.debug_str 3463589 3463589 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116568 116568 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566910 566910 0 0.0
.symtab 171888 171888 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956000 956002 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283843 1283843 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668139 1668139 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 512548 512548 0 0.0
.debug_info 43432797 43432797 0 0.0
.debug_line 5668641 5668641 0 0.0
.debug_loc 3562561 3562561 0 0.0
.debug_ranges 383464 383464 0 0.0
.debug_str 3860904 3860904 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130200 130200 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 627125 627125 0 0.0
.symtab 190000 190000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029698 1029698 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678427 678427 0 0.0
(read/write) 173108 173108 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588264 588264 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642723 642723 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563416 563416 0 0.0
lock-ftd LP_CC2652R7 (read only) 676559 676559 0 0.0
(read/write) 172544 172544 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598808 598808 0 0.0
lock-mtd LP_CC2652R7 (read only) 661115 661115 0 0.0
(read/write) 183244 183244 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103315 103315 0 0.0
.text 557320 557320 0 0.0
pump-app LP_CC2652R7 (read only) 689055 689055 0 0.0
(read/write) 160784 160784 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90767 90767 0 0.0
.text 597804 597804 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673339 673339 0 0.0
(read/write) 176596 176596 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86315 86315 0 0.0
.text 586544 586544 0 0.0
shell LP_CC2652R7 (read only) 669646 669646 0 0.0
(read/write) 184208 184208 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582732 582732 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587494 587494 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591602 591602 0 0.0
.app_xip_area 462516 462516 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543978 543978 0 0.0
.app_xip_area 425708 425708 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974500 974500 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 820052 820052 0 0.0
BRD4161A+rs911x (read/write) 1035280 1035280 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 846508 846508 0 0.0
BRD4187C (read/write) 1147096 1147096 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 981328 981328 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160480 1160480 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1000172 1000172 0 0.0
window-app BRD4187C (read/write) 1140316 1140316 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 973108 973108 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213488 1213486 -2 -0.0
(read/write) 1786542 1786534 -8 -0.0
.dram0.bss 76680 76680 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256368 256360 -8 -0.0
.flash.text 1213488 1213486 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1224347 1224347 0 0.0
(read/write) 562500 562508 8 0.0
.dram0.bss 82056 82056 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313480 313488 8 0.0
.flash.text 1218963 1218963 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662052 662052 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563724 563724 0 0.0
light k32w0+release (read/write) 672112 672112 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592412 592412 0 0.0
lock k32w0+release (read/write) 633612 633612 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553132 553132 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10424668 10424668 0 0.0
(read/write) 706529 706529 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650832 650832 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518380 518380 0 0.0
.text 8250500 8250500 0 0.0
thermostat-no-ble arm64 (read only) 2384076 2384076 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144948 144948 0 0.0
.text 1995232 1995232 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452664 2452664 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1415308 1415308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188159 1188159 0 0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 817284 817284 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167587 1167587 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805834 805834 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746780 1746780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235857 1235857 0 0.0
.debug_aranges 110728 110728 0 0.0
.debug_frame 371396 371396 0 0.0
.debug_info 27027332 27027332 0 0.0
.debug_line 3687492 3687492 0 0.0
.debug_loc 3606214 3606214 0 0.0
.debug_ranges 339928 339928 0 0.0
.debug_str 3432484 3432484 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570636 570636 0 0.0
.symtab 421600 421600 0 0.0
.text 1547016 1547016 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1689316 1689316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227700 1227700 0 0.0
.debug_aranges 110200 110200 0 0.0
.debug_frame 374476 374476 0 0.0
.debug_info 26763962 26763964 2 0.0
.debug_line 3708476 3708476 0 0.0
.debug_loc 3593820 3593820 0 0.0
.debug_ranges 338544 338544 0 0.0
.debug_str 3421504 3421504 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534725 534725 0 0.0
.symtab 408032 408032 0 0.0
.text 1490288 1490288 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1607492 1607492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062161 1062161 0 0.0
.debug_aranges 102400 102400 0 0.0
.debug_frame 344788 344788 0 0.0
.debug_info 22229174 22229174 0 0.0
.debug_line 3277603 3277603 0 0.0
.debug_loc 3291305 3291305 0 0.0
.debug_ranges 303824 303824 0 0.0
.debug_str 3227039 3227039 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471050 471050 0 0.0
.symtab 376400 376400 0 0.0
.text 1416648 1416648 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1641500 1641500 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064136 1064136 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22462797 22462798 1 0.0
.debug_line 3274723 3274723 0 0.0
.debug_loc 3319158 3319158 0 0.0
.debug_ranges 305784 305784 0 0.0
.debug_str 3246396 3246396 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473453 473453 0 0.0
.symtab 378096 378096 0 0.0
.text 1445664 1445664 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151104 1151104 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 598204 598204 0 0.0
lock-app qpg6105+debug (read/write) 1116800 1116800 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 563896 563896 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937728 937728 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 649054 649054 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875720 875720 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 613040 613040 0 0.0
light-switch-app tlsr9518adk80d (read/write) 791076 791076 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554504 554504 0 0.0
lighting-app tlsr9518adk80d (read/write) 875300 875300 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624466 624466 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 805568 805568 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565882 565884 2 0.0

@arkq arkq merged commit 8c09eae into project-chip:master Nov 17, 2022
@arkq arkq deleted the remove-using-namespaces branch November 17, 2022 10:25
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@DamMicSzm @adbridge
Remove using-directives namespaces in Tizen platform (project-chip#23637
0879644 
)
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@DamMicSzm @adbridge
Remove using-directives namespaces in Tizen platform (project-chip#23637
af26826 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DamMicSzm @arkq @andy31415 @restyled-commits