-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Adding new app params #23624
Merged
chrisdecenzo
merged 3 commits into
project-chip:master
from
sharadb-amazon:params-20221111
Nov 17, 2022
Merged
tv-casting-app: Adding new app params #23624
chrisdecenzo
merged 3 commits into
project-chip:master
from
sharadb-amazon:params-20221111
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
changed the title
Adding new app params
tv-casting-app: Adding new app params
Nov 15, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
November 15, 2022 23:12
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 15, 2022 23:12
PR #23624: Size comparison from 700ee0e to 066eb5a Increases (6 builds for bl702, esp32, psoc6, telink)
Decreases (3 builds for bl602, qpg, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Nov 15, 2022
sharadb-amazon
force-pushed
the
params-20221111
branch
2 times, most recently
from
November 16, 2022 03:50
9485c17
to
698af60
Compare
PR #23624: Size comparison from 700ee0e to 698af60 Increases (5 builds for esp32, psoc6, telink)
Decreases (4 builds for bl602, cyw30739, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
params-20221111
branch
from
November 17, 2022 02:38
698af60
to
ebfb7fe
Compare
pullapprove
bot
requested review from
tcarmelveilleux
and removed request for
kpschoedel
November 17, 2022 02:38
PR #23624: Size comparison from 6221fe1 to ebfb7fe Increases (5 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hawk248
approved these changes
Nov 17, 2022
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 17, 2022
* Adding new app params * Using only nodeId to check two VideoPlayers for equality * Checking for null data on the targetNavigation_navigateTarget command in JNI
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Adding new app params * Using only nodeId to check two VideoPlayers for equality * Checking for null data on the targetNavigation_navigateTarget command in JNI
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Adding new app params * Using only nodeId to check two VideoPlayers for equality * Checking for null data on the targetNavigation_navigateTarget command in JNI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23623 and #20073
####Change summary
Added new AppParameter fields to both Android and iOS to pass in setupPasscode, discriminator, spake2p fields and DAC.
####Testing
Tested using the Android and iOS tv-casting-apps against the tv-app.