[nrfconnect] Moved FlashHandler implementation to separate file #23570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #23570: Size comparison from fe7d3fe to d993621 Increases (4 builds for esp32, psoc6, telink)
Decreases (16 builds for bl602, nrfconnect, psoc6, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ArekBalysNordic
approved these changes
Nov 10, 2022
kkasperczyk-no
force-pushed
the
dfu_over_smp_fix
branch
from
d993621 to
d417700
Compare
markaj-nordic
approved these changes
Nov 10, 2022
|
PR #23570: Size comparison from 64abaf1 to d417700 Increases (9 builds for bl602, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, esp32, psoc6)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The FlashHandler implementation was coupled with Matter OTAImageProcessorImpl, what resulted with the fact that it was not possible to use build other DFU mechanisms, like DFU over BT SMP without Matter OTA enabled. Summary of changes: * Moved FlashHandler to separate file called ExternalFlashManager * Added ifdefs to OTAUtil that prevents from building Matter OTA dependencies while Matter OTA is disabled.
kkasperczyk-no
force-pushed
the
dfu_over_smp_fix
branch
from
d417700 to
597ee54
Compare
|
PR #23570: Size comparison from 599ad3b to 597ee54 Increases (2 builds for esp32, psoc6)
Decreases (8 builds for bl702, esp32, k32w, psoc6, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 10, 2022
jmartinez-silabs
approved these changes
Nov 15, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ect-chip#23570) The FlashHandler implementation was coupled with Matter OTAImageProcessorImpl, what resulted with the fact that it was not possible to use build other DFU mechanisms, like DFU over BT SMP without Matter OTA enabled. Summary of changes: * Moved FlashHandler to separate file called ExternalFlashManager * Added ifdefs to OTAUtil that prevents from building Matter OTA dependencies while Matter OTA is disabled.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ect-chip#23570) The FlashHandler implementation was coupled with Matter OTAImageProcessorImpl, what resulted with the fact that it was not possible to use build other DFU mechanisms, like DFU over BT SMP without Matter OTA enabled. Summary of changes: * Moved FlashHandler to separate file called ExternalFlashManager * Added ifdefs to OTAUtil that prevents from building Matter OTA dependencies while Matter OTA is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FlashHandlerimplementation was coupled with MatterOTAImageProcessorImpl, what resulted with the fact that it was not possible to build other DFU mechanisms, like DFU over BT SMP without Matter OTA enabled.Summary of changes:
FlashHandlerto separate file calledExternalFlashManagerOTAUtilthat prevents from building Matter OTA dependencies while Matter OTA is disabled.