Address API review issues in MTRDeviceController. #23512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #23512: Size comparison from 092c91c to 8976672 Increases (5 builds for bl602, bl702, esp32, nrfconnect, telink)
Decreases (4 builds for esp32, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22596
branch
from
8976672 to
47caf62
Compare
|
PR #23512: Size comparison from be90d4d to 47caf62 Increases (8 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (4 builds for esp32, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Nov 9, 2022
|
Fast-tracking platform-specific change with platform owner review. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of PR #22596 but with changes made for backwards compat.
Review note: An "ignore whitespace" diff makes this PR much easier to review. Even easier would be to grab it locally and use
git show --color-moved -won the changeset, since a bunch of code just moved around into Deprecated categories.The header changes not accompanied by backwards-compat shims are OK for the following reasons: