Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] MTRDevice write expected value expiration should generate report properly #23441

Merged
merged 1 commit into from
Nov 2, 2022
Merged

[Darwin] MTRDevice write expected value expiration should generate report properly #23441

merged 1 commit into from
Nov 2, 2022

Conversation

jtung-apple
Copy link
Contributor

Fixes #23440

  1. When MTRDevice writes fail, the expected value expiration would generate report to revert the value
  2. The generated report is incorrectly formatted and missing the attribute path

The fix is to format it correctly on the expiration report generation path

@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

PR #23441: Size comparison from 5030df4 to 43f4960

Increases (9 builds for bl602, bl702, esp32, psoc6, telink)
platform target config section 5030df4 43f4960 change % change
bl602 lighting-app bl602+rpc (read/write) 1435974 1435982 8 0.0
.text 1101414 1101418 4 0.0
bl702 lighting-app bl702+rpc .debug_info 41985158 41985159 1 0.0
.text 1031486 1031488 2 0.0
esp32 all-clusters-app c3devkit (read only) 1223970 1223972 2 0.0
.flash.text 1223970 1223972 2 0.0
m5stack (read/write) 564396 564404 8 0.0
.flash.rodata 315096 315104 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27004566 27004567 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26741196 26741197 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 875148 875156 8 0.0
text 612604 612608 4 0.0
light-switch-app tlsr9518adk80d text 554264 554266 2 0.0
lighting-app tlsr9518adk80d (read/write) 875044 875052 8 0.0
text 624252 624254 2 0.0
Decreases (6 builds for esp32, k32w, nrfconnect, psoc6, qpg, telink)
platform target config section 5030df4 43f4960 change % change
esp32 all-clusters-app c3devkit (read/write) 1788478 1788470 -8 -0.0
.flash.rodata 258032 258024 -8 -0.0
k32w lock k32w0+release (read/write) 633484 633468 -16 -0.0
.text 553076 553060 -16 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 805334 805330 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22202548 22202547 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1149968 1149960 -8 -0.0
.text 597068 597060 -8 -0.0
telink all-clusters-app tlsr9518adk80d text 648768 648766 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5030df4 43f4960 change % change
bl602 lighting-app bl602 (read/write) 1390518 1390518 0 0.0
.bss 90745 90745 0 0.0
.data 9936 9936 0 0.0
.text 1069810 1069810 0 0.0
bl602+rpc (read/write) 1435974 1435982 8 0.0
.bss 98177 98177 0 0.0
.data 10320 10320 0 0.0
.text 1101414 1101418 4 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189323 1189323 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1513290 1513290 0 0.0
.debug_aranges 132064 132064 0 0.0
.debug_frame 484444 484444 0 0.0
.debug_info 38069051 38069051 0 0.0
.debug_line 5262950 5262950 0 0.0
.debug_loc 3366388 3366388 0 0.0
.debug_ranges 358072 358072 0 0.0
.debug_str 3451656 3451656 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565981 565981 0 0.0
.symtab 171984 171984 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957780 957780 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285251 1285251 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1650704 1650704 0 0.0
.debug_aranges 139568 139568 0 0.0
.debug_frame 509816 509816 0 0.0
.debug_info 41985158 41985159 1 0.0
.debug_line 5638684 5638684 0 0.0
.debug_loc 3559215 3559215 0 0.0
.debug_ranges 380872 380872 0 0.0
.debug_str 3847784 3847784 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130024 130024 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 625154 625154 0 0.0
.symtab 189792 189792 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031486 1031488 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677871 677871 0 0.0
(read/write) 173688 173688 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89887 89887 0 0.0
.text 587672 587672 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642119 642119 0 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 79023 79023 0 0.0
.text 562776 562776 0 0.0
lock-ftd LP_CC2652R7 (read only) 676379 676379 0 0.0
(read/write) 172316 172316 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77411 77411 0 0.0
.text 598488 598488 0 0.0
lock-mtd LP_CC2652R7 (read only) 660167 660167 0 0.0
(read/write) 184216 184216 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103263 103263 0 0.0
.text 556424 556424 0 0.0
pump-app LP_CC2652R7 (read only) 688635 688635 0 0.0
(read/write) 160796 160796 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90859 90859 0 0.0
.text 597292 597292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672911 672911 0 0.0
(read/write) 176616 176616 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86407 86407 0 0.0
.text 586024 586024 0 0.0
shell LP_CC2652R7 (read only) 668906 668906 0 0.0
(read/write) 184972 184972 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86594 86594 0 0.0
.text 581996 581996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588542 588542 0 0.0
.app_xip_area 465128 465128 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592590 592590 0 0.0
.app_xip_area 463880 463880 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544482 544482 0 0.0
.app_xip_area 426148 426148 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974732 974732 0 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 820188 820188 0 0.0
BRD4161A+rs911x (read/write) 1034672 1034672 0 0.0
.bss 186744 186744 0 0.0
.data 2092 2092 0 0.0
.text 845812 845812 0 0.0
BRD4187C (read/write) 1146720 1146720 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980864 980864 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160424 1160424 0 0.0
.bss 158272 158272 0 0.0
.data 2100 2100 0 0.0
.text 1000032 1000032 0 0.0
window-app BRD4187C (read/write) 1139940 1139940 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972644 972644 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223970 1223972 2 0.0
(read/write) 1788478 1788470 -8 -0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258032 258024 -8 -0.0
.flash.text 1223970 1223972 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234039 1234039 0 0.0
(read/write) 564396 564404 8 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315096 315104 8 0.0
.flash.text 1228655 1228655 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661676 661676 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563420 563420 0 0.0
light k32w0+release (read/write) 672008 672008 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592380 592380 0 0.0
lock k32w0+release (read/write) 633484 633468 -16 -0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 553076 553060 -16 -0.0
linux chip-tool-ipv6only arm64 (read only) 10436348 10436348 0 0.0
(read/write) 706465 706465 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8262292 8262292 0 0.0
thermostat-no-ble arm64 (read only) 2392844 2392844 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2005296 2005296 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452768 2452768 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1415412 1415412 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188191 1188191 0 0.0
bss 145301 145301 0 0.0
rodata 144836 144836 0 0.0
text 816996 816996 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167475 1167475 0 0.0
bss 144528 144528 0 0.0
rodata 136576 136576 0 0.0
text 805334 805330 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745940 1745940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1234891 1234891 0 0.0
.debug_aranges 110736 110736 0 0.0
.debug_frame 371220 371220 0 0.0
.debug_info 27004566 27004567 1 0.0
.debug_line 3679399 3679399 0 0.0
.debug_loc 3588816 3588816 0 0.0
.debug_ranges 337968 337968 0 0.0
.debug_str 3435414 3435414 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570487 570487 0 0.0
.symtab 421760 421760 0 0.0
.text 1546160 1546160 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688548 1688548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1226734 1226734 0 0.0
.debug_aranges 110208 110208 0 0.0
.debug_frame 374300 374300 0 0.0
.debug_info 26741196 26741197 1 0.0
.debug_line 3700375 3700375 0 0.0
.debug_loc 3576453 3576453 0 0.0
.debug_ranges 336584 336584 0 0.0
.debug_str 3424443 3424443 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534576 534576 0 0.0
.symtab 408192 408192 0 0.0
.text 1489504 1489504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1607004 1607004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1061195 1061195 0 0.0
.debug_aranges 102408 102408 0 0.0
.debug_frame 344616 344616 0 0.0
.debug_info 22202548 22202547 -1 -0.0
.debug_line 3269633 3269633 0 0.0
.debug_loc 3274179 3274179 0 0.0
.debug_ranges 301880 301880 0 0.0
.debug_str 3229870 3229870 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470901 470901 0 0.0
.symtab 376576 376576 0 0.0
.text 1416144 1416144 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640780 1640780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1063170 1063170 0 0.0
.debug_aranges 102808 102808 0 0.0
.debug_frame 346488 346488 0 0.0
.debug_info 22435925 22435925 0 0.0
.debug_line 3266531 3266531 0 0.0
.debug_loc 3301773 3301773 0 0.0
.debug_ranges 303824 303824 0 0.0
.debug_str 3249341 3249341 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473304 473304 0 0.0
.symtab 378256 378256 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149968 1149960 -8 -0.0
.bss 110612 110612 0 0.0
.data 848 848 0 0.0
.text 597068 597060 -8 -0.0
lock-app qpg6105+debug (read/write) 1114760 1114760 0 0.0
.bss 106388 106388 0 0.0
.data 836 836 0 0.0
.text 561856 561856 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937348 937348 0 0.0
bss 81632 81632 0 0.0
noinit 43440 43440 0 0.0
text 648768 648766 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875148 875156 8 0.0
bss 80856 80856 0 0.0
noinit 43440 43440 0 0.0
text 612604 612608 4 0.0
light-switch-app tlsr9518adk80d (read/write) 790820 790820 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554264 554266 2 0.0
lighting-app tlsr9518adk80d (read/write) 875044 875052 8 0.0
bss 82248 82248 0 0.0
noinit 43520 43520 0 0.0
text 624252 624254 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804952 804952 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565286 565286 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) November 2, 2022 19:37
@woody-apple woody-apple merged commit 7aadb28 into project-chip:master Nov 2, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@jtung-apple @adbridge
[Darwin] MTRDevice write expected value expiration should generate re…
4ab6979 
…port properly (project-chip#23441)
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@jtung-apple @adbridge
[Darwin] MTRDevice write expected value expiration should generate re…
5774f59 
…port properly (project-chip#23441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@terafin terafin terafin approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Darwin] MTRDevice write expected value expiration should generate report properly
4 participants
@jtung-apple @terafin @bzbarsky-apple @woody-apple