Feature/common storage class #23409
Merged
Feature/common storage class #23409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lpbeliveau-silabs
changed the title
andy31415
reviewed
Oct 31, 2022
rcasallas-silabs
approved these changes
Nov 3, 2022
lpbeliveau-silabs
force-pushed
the
feature/common_storage_class
branch
from
c934beb to
b93d872
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
|
@lpbeliveau-silabs it seems a compile error needs to be fixed: |
It seems Iterator class name is already used: |
|
PR #23409: Size comparison from 78b6137 to 1061e48 Increases (10 builds for bl602, bl702, k32w, mbed, qpg)
Full report (10 builds for bl602, bl702, k32w, mbed, qpg)
|
lpbeliveau-silabs
force-pushed
the
feature/common_storage_class
branch
6 times, most recently
from
e18a813 to
6ffbf53
Compare
|
The Iterator class was changed to CommonIterator |
lpbeliveau-silabs
force-pushed
the
feature/common_storage_class
branch
3 times, most recently
from
38014a8 to
daac71b
Compare
… comon location: PersistentData.h
lpbeliveau-silabs
force-pushed
the
feature/common_storage_class
branch
from
daac71b to
54ae6aa
Compare
|
PR #23409: Size comparison from b87a86b to d3530ca Increases above 0.2%:
Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23409: Size comparison from 6519b91 to 07ffe47 Increases above 0.2%:
Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Moved structures from group data that could be re-used in scenes in a comon location: PersistentData.h * Refactored the name of Iterator class to CommonIterator Co-authored-by: Andrei Litvin <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Moved structures from group data that could be re-used in scenes in a comon location: PersistentData.h * Refactored the name of Iterator class to CommonIterator Co-authored-by: Andrei Litvin <[email protected]>
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Dec 21, 2022
project-chip#23409 changed the key under which we store group fabric info, which breaks reception of group messages if a node updates from before that change to after that change. We should just keep using the same key name, especially because sharing a single storage key for all possible fabric lists (groups and whatever else will want to store lists of fabric indices) does not necessarily make sense. Fixes project-chip#24161
bzbarsky-apple
added a commit
that referenced
this pull request
Dec 21, 2022
) #23409 changed the key under which we store group fabric info, which breaks reception of group messages if a node updates from before that change to after that change. We should just keep using the same key name, especially because sharing a single storage key for all possible fabric lists (groups and whatever else will want to store lists of fabric indices) does not necessarily make sense. Fixes #24161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated class used in group data provider and implementation and moved them outside of credentials so they can be re-used in scene table implementation.
This PR is basically the first step of: the scene table structure PR