Fix active mode (fast-poll) management in CommissioningWindowManager. #23298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix we could end up in the following situation: 1. Open a commissioning window when operational. Enter active mode in StartAdvertisement. 2. Establish a PASE session. Leave active mode in StopAdvertisement. 3. Commissioning fails, fail-safe triggers. 4. We call StartAdvertisement, but do not enter active mode, because IsCommissioningWindowOpen() is true at this point. The fix is to ensure that our RequestSEDActiveMode() calls happen exacty when mListeningForPASE chages value, since that's the reason we want to be messing with active mode to start with.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
tcarmelveilleux
approved these changes
Oct 21, 2022
|
PR #23298: Size comparison from a325034 to ed41b83 Increases (15 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739, esp32, k32w)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Oct 25, 2022
bzbarsky-apple
deleted the
safer-fast-mode-commissioning-window-management
branch
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23298) Without this fix we could end up in the following situation: 1. Open a commissioning window when operational. Enter active mode in StartAdvertisement. 2. Establish a PASE session. Leave active mode in StopAdvertisement. 3. Commissioning fails, fail-safe triggers. 4. We call StartAdvertisement, but do not enter active mode, because IsCommissioningWindowOpen() is true at this point. The fix is to ensure that our RequestSEDActiveMode() calls happen exacty when mListeningForPASE chages value, since that's the reason we want to be messing with active mode to start with.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23298) Without this fix we could end up in the following situation: 1. Open a commissioning window when operational. Enter active mode in StartAdvertisement. 2. Establish a PASE session. Leave active mode in StopAdvertisement. 3. Commissioning fails, fail-safe triggers. 4. We call StartAdvertisement, but do not enter active mode, because IsCommissioningWindowOpen() is true at this point. The fix is to ensure that our RequestSEDActiveMode() calls happen exacty when mListeningForPASE chages value, since that's the reason we want to be messing with active mode to start with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix we could end up in the following situation:
The fix is to ensure that our RequestSEDActiveMode() calls happen exacty when mListeningForPASE chages value, since that's the reason we want to be messing with active mode to start with.