-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef to support disabling IPv4 on ESP32 #23174
Chef to support disabling IPv4 on ESP32 #23174
Conversation
The current Chef can only support disabling IPv4 on Linux. However, ESP32 that can disable IPv4 is not supported by Chef. This commit is for fixing this.
@chshu Would you mind to review this PR since it is mainly focus on supporting ESP32 through Chef? |
PR #23174: Size comparison from 2c9cd92 to ffe27c4 Increases (2 builds for cc13x2_26x2)
Decreases (3 builds for bl702, cc13x2_26x2)
Full report (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #23174: Size comparison from bc6b438 to 837867d Increases (6 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good. Mentioned offline about updating cicd_config.json. It would be nice to have a follow up to reduce dependence on shell functions like sed
and [ -f ]
. LGTM.
PR #23174: Size comparison from bc6b438 to 68eb64a Increases (4 builds for cc13x2_26x2, esp32, psoc6)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23174: Size comparison from d520b39 to 769e038 Increases (2 builds for bl602, psoc6)
Decreases (4 builds for psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Chef to support disabling IPv4 on ESP32 The current Chef can only support disabling IPv4 on Linux. However, ESP32 that can disable IPv4 is not supported by Chef. This commit is for fixing this. * Restyled by autopep8 * Rename Chef option ipv6only to enable_ipv4 * [Chef] Fix cicd when renaming option ipv6only Co-authored-by: Restyled.io <[email protected]>
* Chef to support disabling IPv4 on ESP32 The current Chef can only support disabling IPv4 on Linux. However, ESP32 that can disable IPv4 is not supported by Chef. This commit is for fixing this. * Restyled by autopep8 * Rename Chef option ipv6only to enable_ipv4 * [Chef] Fix cicd when renaming option ipv6only Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Erwin Pan <[email protected]> Co-authored-by: Restyled.io <[email protected]>
The current Chef can only support disabling IPv4 on Linux. However, ESP32 that can disable IPv4 is not supported by Chef. This commit is for fixing this.