Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Fix setting pincode based on kconfig. #23172

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Currently the CONFIG_CHIP_DEVICE_PAIRING_PASSCODE is used for setting pincode, but such symbol doesn't exist anymore. Used correct CONFIG_CHIP_DEVICE_SPAKE2_PASSCODE symbol instead.

Currently the CONFIG_CHIP_DEVICE_PAIRING_PASSCODE is used for
setting pincode, but such symbol doesn't exist anymore.
Used correct CONFIG_CHIP_DEVICE_SPAKE2_PASSCODE symbol instead.
@github-actions
Copy link

PR #23172: Size comparison from 2c9cd92 to 3d26596

Increases (2 builds for qpg, telink)
platform target config section 2c9cd92 3d26596 change % change
qpg lighting-app qpg6105+debug (read/write) 1148624 1148632 8 0.0
.text 595724 595732 8 0.0
telink ota-requestor-app tlsr9518adk80d text 577540 577542 2 0.0
Full report (5 builds for qpg, telink)
platform target config section 2c9cd92 3d26596 change % change
qpg lighting-app qpg6105+debug (read/write) 1148624 1148632 8 0.0
.bss 110556 110556 0 0.0
.data 832 832 0 0.0
.text 595724 595732 8 0.0
lock-app qpg6105+debug (read/write) 1113712 1113712 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560808 560808 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789364 789364 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553136 553136 0 0.0
lighting-app tlsr9518adk80d (read/write) 811468 811468 0 0.0
bss 73328 73328 0 0.0
noinit 43520 43520 0 0.0
text 571354 571354 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 819412 819412 0 0.0
bss 74236 74236 0 0.0
noinit 43520 43520 0 0.0
text 577540 577542 2 0.0

@andy31415 andy31415 merged commit d59d5ed into project-chip:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants