Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Release BLE when no longer needed #23032

Merged
merged 2 commits into from
Oct 6, 2022
Merged

[Tizen] Release BLE when no longer needed #23032

merged 2 commits into from
Oct 6, 2022

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Oct 5, 2022

Problem

Tizen Native API bt_deinitialize() is not called when shutting down BLE subsystem. Tizen doc says: "In addition, bt_deinitialize() should be called when Bluetooth Service is no longer needed."

Changes

  • implement BLEManagerImpl::_Shutdown for Tizen
  • clang-tidy: modernize redundant void
  • add error verification for Linux when registering GATT

Testing

Manually tested by running chip-tool on Tizen. Now bt_deinitialize() is called when BLEMgr().Shutdown(); is called in void GenericPlatformManagerImpl<ImplClass>::_Shutdown().

@pullapprove pullapprove bot requested a review from LuDuda October 5, 2022 11:00
@arkq
Copy link
Contributor Author

arkq commented Oct 5, 2022

One more question, maybe we should change log message severity from error to info in here (technically these messages are not errors):
https://github.com/project-chip/connectedhomeip/blob/master/src/include/platform/internal/GenericPlatformManagerImpl.ipp#L129-L142

@github-actions
Copy link

github-actions bot commented Oct 5, 2022 •
edited
Loading

PR #23032: Size comparison from 55116a1 to 45ef30b

Increases (8 builds for cc13x2_26x2, esp32, linux, nrfconnect, psoc6, qpg)
platform target config section 55116a1 45ef30b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174760 174768 8 0.0
pump-controller-app LP_CC2652R7 (read only) 672011 672019 8 0.0
.text 585432 585440 8 0.0
esp32 all-clusters-app c3devkit (read only) 1223140 1223142 2 0.0
.flash.text 1223140 1223142 2 0.0
linux chip-tool-ipv6only arm64 (read only) 10428236 10428284 48 0.0
.text 8255332 8255380 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815484 815488 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26567605 26567606 1 0.0
light cy8ckit_062s2_43012 .debug_info 22031247 22031249 2 0.0
qpg lock-app qpg6105+debug (read/write) 1113312 1113320 8 0.0
.text 560408 560416 8 0.0
Decreases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
platform target config section 55116a1 45ef30b change % change
bl602 lighting-app bl602+rpc (read/write) 1434414 1434406 -8 -0.0
.text 1100138 1100136 -2 -0.0
bl702 lighting-app bl702 .debug_info 37904719 37904718 -1 -0.0
.text 956762 956760 -2 -0.0
bl702+rpc .debug_info 41811330 41811329 -1 -0.0
.text 1030464 1030462 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676783 676775 -8 -0.0
.text 586864 586856 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177516 177508 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803384 803380 -4 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22269917 22269916 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1148256 1148248 -8 -0.0
.text 595356 595348 -8 -0.0
telink light-switch-app tlsr9518adk80d text 552920 552918 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 819016 819008 -8 -0.0
text 577324 577320 -4 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 55116a1 45ef30b change % change
bl602 lighting-app bl602 (read/write) 1389194 1389194 0 0.0
.bss 90729 90729 0 0.0
.data 9928 9928 0 0.0
.text 1068790 1068790 0 0.0
bl602+rpc (read/write) 1434414 1434406 -8 -0.0
.bss 98161 98161 0 0.0
.data 10312 10312 0 0.0
.text 1100138 1100136 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188195 1188195 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506913 1506913 0 0.0
.debug_aranges 133120 133120 0 0.0
.debug_frame 486540 486540 0 0.0
.debug_info 37904719 37904718 -1 -0.0
.debug_line 5256212 5256212 0 0.0
.debug_loc 3366560 3366560 0 0.0
.debug_ranges 359264 359264 0 0.0
.debug_str 3457718 3457718 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116552 116552 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565037 565037 0 0.0
.symtab 171648 171648 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956762 956760 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284115 1284115 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75150 75150 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644458 1644458 0 0.0
.debug_aranges 140624 140624 0 0.0
.debug_frame 511916 511916 0 0.0
.debug_info 41811330 41811329 -1 -0.0
.debug_line 5630747 5630747 0 0.0
.debug_loc 3559220 3559220 0 0.0
.debug_ranges 381720 381720 0 0.0
.debug_str 3853618 3853618 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129944 129944 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624210 624210 0 0.0
.symtab 189456 189456 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030464 1030462 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676783 676775 -8 -0.0
(read/write) 174760 174768 8 0.0
.bss 81236 81236 0 0.0
.data 3380 3380 0 0.0
.rodata 89607 89607 0 0.0
.text 586864 586856 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641031 641031 0 0.0
(read/write) 158004 158004 0 0.0
.bss 80508 80508 0 0.0
.data 3380 3380 0 0.0
.rodata 78743 78743 0 0.0
.text 561968 561968 0 0.0
lock-ftd LP_CC2652R7 (read only) 675467 675467 0 0.0
(read/write) 173228 173228 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77131 77131 0 0.0
.text 597856 597856 0 0.0
lock-mtd LP_CC2652R7 (read only) 659215 659215 0 0.0
(read/write) 185168 185168 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 102951 102951 0 0.0
.text 555784 555784 0 0.0
pump-app LP_CC2652R7 (read only) 687519 687519 0 0.0
(read/write) 161896 161896 0 0.0
.bss 78428 78428 0 0.0
.data 3296 3296 0 0.0
.rodata 90543 90543 0 0.0
.text 596492 596492 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672011 672019 8 0.0
(read/write) 177516 177508 -8 -0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86099 86099 0 0.0
.text 585432 585440 8 0.0
shell LP_CC2652R7 (read only) 667830 667830 0 0.0
(read/write) 186032 186032 0 0.0
.bss 83556 83556 0 0.0
.data 3376 3376 0 0.0
.rodata 86318 86318 0 0.0
.text 581196 581196 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587738 587738 0 0.0
.app_xip_area 464348 464348 0 0.0
.bss 65808 65808 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591994 591994 0 0.0
.app_xip_area 463284 463284 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543586 543586 0 0.0
.app_xip_area 425252 425252 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 973768 973768 0 0.0
.bss 152244 152244 0 0.0
.data 2248 2248 0 0.0
.text 819256 819256 0 0.0
BRD4161A+rs911x (read/write) 1031312 1031312 0 0.0
.bss 186640 186640 0 0.0
.data 2092 2092 0 0.0
.text 842560 842560 0 0.0
BRD4187C (read/write) 1146076 1146076 0 0.0
.bss 138624 138624 0 0.0
.data 2596 2596 0 0.0
.text 980260 980260 0 0.0
lock-app BRD4161A+wf200 (read/write) 1157232 1157232 0 0.0
.bss 158192 158192 0 0.0
.data 2100 2100 0 0.0
.text 996920 996920 0 0.0
window-app BRD4187C (read/write) 1138076 1138076 0 0.0
.bss 140064 140064 0 0.0
.data 2620 2620 0 0.0
.text 970796 970796 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223140 1223142 2 0.0
(read/write) 1788126 1788126 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257696 257696 0 0.0
.flash.text 1223140 1223142 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233183 1233183 0 0.0
(read/write) 564028 564028 0 0.0
.dram0.bss 82312 82312 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314752 314752 0 0.0
.flash.text 1227799 1227799 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 641588 641588 0 0.0
.bss 74824 74824 0 0.0
.data 2064 2064 0 0.0
.text 561972 561972 0 0.0
lock k32w0+release (read/write) 632916 632916 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552508 552508 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10428236 10428284 48 0.0
(read/write) 706433 706433 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650608 650608 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 517532 517532 0 0.0
.text 8255332 8255380 48 0.0
thermostat-no-ble arm64 (read only) 2388740 2388740 0 0.0
(read/write) 143713 143713 0 0.0
.bss 55377 55377 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77232 77232 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143772 143772 0 0.0
.text 2002256 2002256 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2451792 2451792 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414436 1414436 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183051 1183051 0 0.0
bss 144441 144441 0 0.0
rodata 144220 144220 0 0.0
text 815484 815488 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161735 1161735 0 0.0
bss 143668 143668 0 0.0
rodata 135792 135792 0 0.0
text 803384 803380 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1744748 1744748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229469 1229469 0 0.0
.debug_aranges 111848 111848 0 0.0
.debug_frame 373448 373448 0 0.0
.debug_info 26830823 26830823 0 0.0
.debug_line 3671570 3671570 0 0.0
.debug_loc 3588349 3588349 0 0.0
.debug_ranges 339632 339632 0 0.0
.debug_str 3441121 3441121 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569605 569605 0 0.0
.symtab 421120 421120 0 0.0
.text 1544984 1544984 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1687356 1687356 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221268 1221268 0 0.0
.debug_aranges 111320 111320 0 0.0
.debug_frame 376528 376528 0 0.0
.debug_info 26567605 26567606 1 0.0
.debug_line 3692286 3692286 0 0.0
.debug_loc 3575986 3575986 0 0.0
.debug_ranges 338248 338248 0 0.0
.debug_str 3430134 3430134 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533694 533694 0 0.0
.symtab 407552 407552 0 0.0
.text 1488328 1488328 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1605884 1605884 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055324 1055324 0 0.0
.debug_aranges 103528 103528 0 0.0
.debug_frame 346860 346860 0 0.0
.debug_info 22031247 22031249 2 0.0
.debug_line 3262191 3262191 0 0.0
.debug_loc 3273948 3273948 0 0.0
.debug_ranges 303552 303552 0 0.0
.debug_str 3235666 3235666 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470071 470071 0 0.0
.symtab 376000 376000 0 0.0
.text 1415048 1415048 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1639804 1639804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1057427 1057427 0 0.0
.debug_aranges 103928 103928 0 0.0
.debug_frame 348752 348752 0 0.0
.debug_info 22269917 22269916 -1 -0.0
.debug_line 3260052 3260052 0 0.0
.debug_loc 3302541 3302541 0 0.0
.debug_ranges 305496 305496 0 0.0
.debug_str 3255180 3255180 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472478 472478 0 0.0
.symtab 377664 377664 0 0.0
.text 1443952 1443952 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148256 1148248 -8 -0.0
.bss 110556 110556 0 0.0
.data 832 832 0 0.0
.text 595356 595348 -8 -0.0
lock-app qpg6105+debug (read/write) 1113312 1113320 8 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560408 560416 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 788968 788968 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 552920 552918 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 811072 811072 0 0.0
bss 73328 73328 0 0.0
noinit 43520 43520 0 0.0
text 571140 571140 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 819016 819008 -8 -0.0
bss 74236 74236 0 0.0
noinit 43520 43520 0 0.0
text 577324 577320 -4 -0.0

@bzbarsky-apple bzbarsky-apple merged commit bf066a2 into project-chip:master Oct 6, 2022
@arkq arkq deleted the tizen-ble-shutdown branch October 7, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkq @andy31415 @bzbarsky-apple