-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Make dispatch event time threshold configurable #22994
Merged
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22994: Size comparison from b6c9191 to d051d67 Increases (2 builds for k32w, nrfconnect)
Decreases (3 builds for bl702, telink)
Full report (12 builds for bl702, k32w, mbed, nrfconnect, qpg, telink)
|
ATmobica
force-pushed
the
upstream-fixes
branch
from
October 3, 2022 11:24
d051d67
to
adece0c
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
October 3, 2022 11:24
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
October 3, 2022 11:24
PR #22994: Size comparison from b6c9191 to adece0c Increases (12 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 4, 2022
Add CHIP_DISPATCH_EVENT_LONG_DISPATCH_TIME_WARNING_THRESHOLD_MS variable to set the time threshold for events dispatching. Signed-off-by: ATmobica <artur.tynecki@mobica.com>
ATmobica
force-pushed
the
upstream-fixes
branch
from
October 4, 2022 16:04
adece0c
to
32c43f8
Compare
PR #22994: Size comparison from fcf68c1 to 32c43f8 Increases (10 builds for cc13x2_26x2, cyw30739, esp32, k32w)
Decreases (10 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22993
Add CHIP_DISPATCH_EVENT_LONG_DISPATCH_TIME_WARNING_THRESHOLD_MS variable to set the time threshold for events dispatching.
This will allow for the adaptation of the threshold value to the platform or application.