Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform] [WIP] make setup constants configurable in gn #2296

Closed
wants to merge 2 commits into from
Closed

[platform] [WIP] make setup constants configurable in gn #2296

wants to merge 2 commits into from

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Aug 24, 2020 •
edited
Loading

Now you can use:

extra_args="chip_device_test_setup_pincode=87654321 \
chip_device_test_setup_discriminator=1024" ./gn_build.sh

to specify the setup constants.

Also updated the device name in ble advertisements to make the devices more distinguishable.

@gjc13 gjc13 requested review from mspang and erjiaqing August 24, 2020 10:26
@restyled-io restyled-io bot mentioned this pull request Aug 24, 2020
Closed
BroderickCarlin
BroderickCarlin approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@BroderickCarlin BroderickCarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be some documentation changes to accompany this change?

mspang
mspang requested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@mspang mspang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pass this on the command line instead of environment?

src/platform/BUILD.gn Outdated Show resolved Hide resolved
@gjc13 gjc13 requested a review from mspang August 25, 2020 03:03
@restyled-io restyled-io bot mentioned this pull request Aug 25, 2020
Closed
@gjc13
[platform] make setup constants configurable in gn
ef61f77 
Now you can use:
```
./gn_build.sh --pincode=87654321 --discriminator=1024
```
to specify the setup constants.
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 25, 2020
@restyled-io restyled-io bot mentioned this pull request Aug 25, 2020
Closed
@gjc13 gjc13 force-pushed the setup-constants branch 2 times, most recently from 720aed3 to fc3b314 Compare August 25, 2020 05:34
@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@gjc13
Copy link
Contributor Author

gjc13 commented Aug 25, 2020 •
edited
Loading

DO NOT SUBMIT

Causes build errors(macro redefinition) after #2270 is merged.

We need to find a way to unify how we configure these macros.

@gjc13 gjc13 changed the title [platform] make setup constants configurable in gn [platform] WIP make setup constants configurable in gn Aug 25, 2020
@gjc13 gjc13 changed the title [platform] WIP make setup constants configurable in gn [platform] [WIP] make setup constants configurable in gn Aug 25, 2020
mspang
mspang requested changes Sep 17, 2020
View reviewed changes
gn_build.sh
@@ -99,6 +99,25 @@ else
echo "Hint: Set \$EFR32_SDK_ROOT to enable building for EFR32"
fi

opts=$(getopt --longoptions "pincode:,discriminator:" -n "$0" --options "" -- "$@")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree with creating new bespoke options here, instead we could just generically accept args:

gn_build.sh chip_device_config_use_test_setup_pin_code=12345

But really, if you want a custom configuration, I'd actually recommend not using gn_build.sh at all and following the documented instructions for creating a custom configuration.

gn_build.sh is more intended to build what CI builds, without any local deviations.

@rwalker-apple
Copy link
Contributor

@gjc13 are you still working on this?

@gjc13 gjc13 closed this Nov 25, 2020
manjunath-grl added a commit to manjunath-grl/connectedhomeip that referenced this pull request Sep 23, 2022
@manjunath-grl
Fix project-chip#2296
80d4716
andy31415 pushed a commit that referenced this pull request Sep 23, 2022
@manjunath-grl @restyled-commits
Modified TSTAT sep 21 (#22800)
dbe192d 
* Fixed issue #561and #562
TSTAT-2.1
TSTAT-2.2

* Auto generated files

* Restyled by whitespace

* Disabled TSTAT tests in Darwin

* Auto generated files

* Restyled by whitespace

* Fix #2296

* Auto generated files

Co-authored-by: Restyled.io <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 23, 2022
@manjunath-grl @restyled-commits @web-flow
Modified TSTAT sep 21 (#22800)
664ea3e 
* Fixed issue #561and #562
TSTAT-2.1
TSTAT-2.2

* Auto generated files

* Restyled by whitespace

* Disabled TSTAT tests in Darwin

* Auto generated files

* Restyled by whitespace

* Fix #2296

* Auto generated files

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang requested changes

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@bukepo bukepo bukepo approved these changes

@andy31415 andy31415 andy31415 approved these changes

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gjc13 @rwalker-apple @mspang @andy31415 @bukepo @BroderickCarlin @woody-apple