-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chef Color Temperature Light #22956
Merged
andy31415
merged 24 commits into
project-chip:master
from
erwinpan1:add_chef_color_temperature_light
Oct 7, 2022
Merged
Add Chef Color Temperature Light #22956
andy31415
merged 24 commits into
project-chip:master
from
erwinpan1:add_chef_color_temperature_light
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erwinpan1
commented
Sep 29, 2022
- Add new chef device : colortemperaturelight which follows spec 4.3. Color Temperature Light
- Associated *.zap , *.matter , and zap-generated codes are all committed.
Add new chef device : colortemperaturelight
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
September 29, 2022 16:34
andy31415
reviewed
Oct 4, 2022
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter
Outdated
Show resolved
Hide resolved
The current chef Color Temperature Light device contains several unnecessary clusters such as Switch, LocalizationConfiguration, , TimeFormatLocalization. Putting a Switch cluster in the EP0 (root node) is wrong. While we don't need to localize text/time for a light. So we remove them all.
PR #22956: Size comparison from bcc99dd to 7a13f94 Increases (1 build for bl602)
Decreases (4 builds for bl602, bl702, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22956: Size comparison from 36d08bb to 3cb3eb7 Increases (3 builds for bl702, cc13x2_26x2, psoc6)
Decreases (3 builds for cc13x2_26x2, psoc6)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
After removing Switch/LocalizationConfiguration/TimeFormat clusters, the codes in zzz_generated are also regenerated and should be committed
PR #22956: Size comparison from 36d08bb to 98ffd41 Decreases (1 build for bl702)
Full report (9 builds for bl702, k32w, linux, mbed, qpg)
|
Fix examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter which defines new matter format "fabric_scoped"
PR #22956: Size comparison from 55116a1 to 6ae5083 Increases (1 build for nrfconnect)
Full report (7 builds for bl702, mbed, nrfconnect, qpg)
|
PR #22956: Size comparison from a01d8e4 to 775ade3 Decreases (10 builds for bl602, bl702, nrfconnect, qpg, telink)
Full report (13 builds for bl602, bl702, linux, nrfconnect, qpg, telink)
|
PR #22956: Size comparison from 9945f23 to 754cd6e Increases (7 builds for bl702, efr32, esp32, psoc6, qpg)
Decreases (3 builds for bl602, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22956: Size comparison from 55b0a19 to 211722a Increases (2 builds for esp32, psoc6)
Decreases (2 builds for bl602, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 6, 2022
PR #22956: Size comparison from bf066a2 to f958d79 Increases (4 builds for efr32, nrfconnect, psoc6)
Decreases (6 builds for bl602, bl702, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mrjerryjohns
approved these changes
Oct 7, 2022
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Oct 12, 2022
* Add Chef Color Temperature Light Add new chef device : colortemperaturelight * Restyled by whitespace * Restyled by clang-format * Remove Chef ColorTemperatureLight Clusters.matter Remove unused Clusters.matter zzz_generated/chef-rootnode_colortemperaturelight_hbUnzYVeyn/zap-generated/Clusters.matter * Remove Scene Cluster which is not supported in 1.0 * Restyled by whitespace * Restyled by clang-format * Remove unnecessary clusters fro chef colortemperature device The current chef Color Temperature Light device contains several unnecessary clusters such as Switch, LocalizationConfiguration, , TimeFormatLocalization. Putting a Switch cluster in the EP0 (root node) is wrong. While we don't need to localize text/time for a light. So we remove them all. * Fix Chef color temperature light zzz_generated After removing Switch/LocalizationConfiguration/TimeFormat clusters, the codes in zzz_generated are also regenerated and should be committed * Fix chef colortemperaturelight matter new format Fix examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter which defines new matter format "fabric_scoped" * Remove FixedLabel & UserLabel which doesn't apply here * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Oct 12, 2022
* Add Chef Color Temperature Light Add new chef device : colortemperaturelight * Restyled by whitespace * Restyled by clang-format * Remove Chef ColorTemperatureLight Clusters.matter Remove unused Clusters.matter zzz_generated/chef-rootnode_colortemperaturelight_hbUnzYVeyn/zap-generated/Clusters.matter * Remove Scene Cluster which is not supported in 1.0 * Restyled by whitespace * Restyled by clang-format * Remove unnecessary clusters fro chef colortemperature device The current chef Color Temperature Light device contains several unnecessary clusters such as Switch, LocalizationConfiguration, , TimeFormatLocalization. Putting a Switch cluster in the EP0 (root node) is wrong. While we don't need to localize text/time for a light. So we remove them all. * Fix Chef color temperature light zzz_generated After removing Switch/LocalizationConfiguration/TimeFormat clusters, the codes in zzz_generated are also regenerated and should be committed * Fix chef colortemperaturelight matter new format Fix examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter which defines new matter format "fabric_scoped" * Remove FixedLabel & UserLabel which doesn't apply here * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Add Chef Color Temperature Light (#22956) * Add Chef Color Temperature Light Add new chef device : colortemperaturelight * Restyled by whitespace * Restyled by clang-format * Remove Chef ColorTemperatureLight Clusters.matter Remove unused Clusters.matter zzz_generated/chef-rootnode_colortemperaturelight_hbUnzYVeyn/zap-generated/Clusters.matter * Remove Scene Cluster which is not supported in 1.0 * Restyled by whitespace * Restyled by clang-format * Remove unnecessary clusters fro chef colortemperature device The current chef Color Temperature Light device contains several unnecessary clusters such as Switch, LocalizationConfiguration, , TimeFormatLocalization. Putting a Switch cluster in the EP0 (root node) is wrong. While we don't need to localize text/time for a light. So we remove them all. * Fix Chef color temperature light zzz_generated After removing Switch/LocalizationConfiguration/TimeFormat clusters, the codes in zzz_generated are also regenerated and should be committed * Fix chef colortemperaturelight matter new format Fix examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter which defines new matter format "fabric_scoped" * Remove FixedLabel & UserLabel which doesn't apply here * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> * Fix rootnode_colortemperaturelight_hbUnzYVeyn.matter Fix rootnode_colortemperaturelight_hbUnzYVeyn.matter lint error (fabric_scoped) due to cherry-pick from master Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.