-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nltest runner builds #22878
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:fix_nltest_runner_builds
Sep 26, 2022
Merged
Fix nltest runner builds #22878
andy31415
merged 2 commits into
project-chip:master
from
andy31415:fix_nltest_runner_builds
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
September 26, 2022 20:03
pullapprove
bot
requested review from
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 26, 2022 20:03
pullapprove
bot
added
review - pending
github
scripts
workflows
and removed
scripts
github
workflows
labels
Sep 26, 2022
andy31415
force-pushed
the
fix_nltest_runner_builds
branch
from
September 26, 2022 20:04
6205082
to
18ae6e8
Compare
PR #22878: Size comparison from 797ca40 to 26fb3ff Increases (5 builds for nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl602, bl702, psoc6, telink)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
* Force a board name for silabs_board so that linux-x64-nl-test-runner can be built * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
fails to compile.
Change overview
#22793 added a requirement on silabs_board being defined. nl_test_runner has some sdk build parts which previously did not seem triggered, however now the SDK usage requires a board.
May need to define better on how to select boards (and if they are even valid).