-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Refactor Bluetooth implementation to use SLC structure #22877
Merged
andy31415
merged 7 commits into
project-chip:master
from
mkardous-silabs:feature/refactor_ble
Sep 30, 2022
Merged
[Silabs] Refactor Bluetooth implementation to use SLC structure #22877
andy31415
merged 7 commits into
project-chip:master
from
mkardous-silabs:feature/refactor_ble
Sep 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
September 26, 2022 19:08
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 26, 2022 19:09
mkardous-silabs
force-pushed
the
feature/refactor_ble
branch
from
September 26, 2022 19:16
2f2d3fe
to
14d7272
Compare
jmartinez-silabs
approved these changes
Sep 26, 2022
PR #22877: Size comparison from 797ca40 to fcc9b23 Increases (3 builds for bl702, qpg, telink)
Decreases (2 builds for telink)
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
jmartinez-silabs
approved these changes
Sep 29, 2022
mkardous-silabs
force-pushed
the
feature/refactor_ble
branch
from
September 29, 2022 21:40
7f7bd82
to
c447105
Compare
PR #22877: Size comparison from 852c879 to c447105 Increases (1 build for bl702)
Decreases (2 builds for bl702, nrfconnect)
Full report (7 builds for bl702, mbed, nrfconnect, qpg)
|
mkardous-silabs
force-pushed
the
feature/refactor_ble
branch
from
September 30, 2022 03:08
c447105
to
5e31b0d
Compare
PR #22877: Size comparison from a334714 to 5e31b0d Increases above 0.2%:
Increases (9 builds for cc13x2_26x2, efr32, esp32, psoc6)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, efr32, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 30, 2022
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…ect-chip#22877) * Bluetooth refactor to use SLC generation * Update Submodule to get generated files * Fix conflict error * move gatt_db files out of csa repo * update sdk build gn * Update Submodule * Move fault logging to better location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview