[QPG] Build Qorvo libraries, use QMatter v0.9.0.0-libs #22864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
abc55eb to
6f8d021
Compare
|
PR #22864: Size comparison from dc66d4e to 6f8d021 Increases (1 build for bl702)
Decreases (1 build for bl702)
Full report (5 builds for bl702, linux, mbed)
|
|
PR #22864: Size comparison from dc66d4e to d0631f0 Increases (5 builds for bl602, cc13x2_26x2, psoc6)
Decreases (5 builds for bl702, cc13x2_26x2, esp32, psoc6)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
d0631f0 to
4cd2140
Compare
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
4cd2140 to
e769ab8
Compare
|
PR #22864: Size comparison from 1ddf6ad to e769ab8 Increases (1 build for bl702)
Decreases (1 build for bl702)
Full report (4 builds for bl702, k32w)
|
tima-q
changed the title
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
e769ab8 to
006f1e5
Compare
|
PR #22864: Size comparison from f2cd15f to 006f1e5 Increases (3 builds for cc13x2_26x2, qpg)
Decreases (12 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
006f1e5 to
2537d43
Compare
|
PR #22864: Size comparison from f2cd15f to 2537d43 Increases (6 builds for cc13x2_26x2, efr32, esp32, psoc6, qpg)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Sep 27, 2022
andy31415
approved these changes
Sep 27, 2022
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
2537d43 to
a6b2310
Compare
Build Qorvo libraries instead of using binary artifacts Reduce mbedtls sources list Use ld path without '_mrom' in the name use compiler executables from $PATH
q-thla
force-pushed
the
pr/move-to-qmatter-submodule
branch
from
a6b2310 to
3639a5e
Compare
|
PR #22864: Size comparison from f72807b to 3639a5e Increases (11 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702, qpg)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tima-q
pushed a commit
to tima-q/connectedhomeip
that referenced
this pull request
Sep 28, 2022
Build Qorvo libraries instead of using binary artifacts Reduce mbedtls sources list Use ld path without '_mrom' in the name use compiler executables from $PATH
andy31415
pushed a commit
that referenced
this pull request
Sep 28, 2022
Build Qorvo libraries instead of using binary artifacts Reduce mbedtls sources list Use ld path without '_mrom' in the name use compiler executables from $PATH Co-authored-by: Thomas Langewouters <[email protected]>
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
Build Qorvo libraries instead of using binary artifacts Reduce mbedtls sources list Use ld path without '_mrom' in the name use compiler executables from $PATH
|
@q-thla on Oct 6 @LuDuda observed a problem where At the time, it looked like Do you know what happened? |
@nekleo We were looking to eol the old submodule as master and v1.0 do no longer depend on it. Probably you've hit that small period of time. Currently we reverted that change for now, but we will remove it at a certain point in time. |
|
Thanks @tima-q for the info, and for the revert. I'm not aware of any special handing other than to move to a later commit, or if not possible, then to provide a patch. |
|
Fwiw, #23059 should help some with this sort of situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview