Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darwin tests] Fix testAnySharedRemoteController and testReadClusterStateCacheFailure #22838

Conversation

vivien-apple
Copy link
Contributor

Issue Being Resolved

Change overview

  • Fix testReadClusterStateCacheFailure to wait for the first XPC disconnect before issuing a read...
  • Fix MTRDeviceControllerOverXPC and MTRDeviceOverXPC in such a way that the proxy handle is not released while setting it up. It just seems that we don't really want to allocate an xpc connection for nothing. As a side effect it was allocated twice with a disconnect in between - which is why tests relying on a single disconnect were failing.

@vivien-apple vivien-apple changed the title Darwin test xpc double connection [Darwin tests] Fix testAnySharedRemoteController and testReadClusterStateCacheFailure Sep 23, 2022
@github-actions
Copy link

PR #22838: Size comparison from edb93a0 to a313797

Increases (1 build for qpg)
platform target config section edb93a0 a313797 change % change
qpg lighting-app qpg6105+debug (read/write) 1146288 1146296 8 0.0
.text 593384 593392 8 0.0
Decreases (1 build for bl702)
platform target config section edb93a0 a313797 change % change
bl702 lighting-app bl702 (read/write) 1188091 1188075 -16 -0.0
.debug_info 37898613 37898612 -1 -0.0
.text 956754 956752 -2 -0.0
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section edb93a0 a313797 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188091 1188075 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67078 67078 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506921 1506921 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486408 486408 0 0.0
.debug_info 37898613 37898612 -1 -0.0
.debug_line 5252753 5252753 0 0.0
.debug_loc 3364043 3364043 0 0.0
.debug_ranges 359032 359032 0 0.0
.debug_str 3456012 3456012 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116472 116472 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564828 564828 0 0.0
.symtab 171600 171600 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956754 956752 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284011 1284011 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75126 75126 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644466 1644466 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511784 511784 0 0.0
.debug_info 41805210 41805210 0 0.0
.debug_line 5627292 5627292 0 0.0
.debug_loc 3556747 3556747 0 0.0
.debug_ranges 381488 381488 0 0.0
.debug_str 3851912 3851912 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129864 129864 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624001 624001 0 0.0
.symtab 189408 189408 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030456 1030456 0 0.0
k32w light k32w0+release (read/write) 649908 649908 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574400 574400 0 0.0
lock k32w0+release (read/write) 706864 706864 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630900 630900 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10381740 10381740 0 0.0
(read/write) 706257 706257 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 508332 508332 0 0.0
.text 8219428 8219428 0 0.0
thermostat-no-ble arm64 (read only) 2387508 2387508 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143676 143676 0 0.0
.text 2001536 2001536 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455680 2455680 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418324 1418324 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182875 1182875 0 0.0
bss 144433 144433 0 0.0
rodata 144236 144236 0 0.0
text 815296 815296 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161559 1161559 0 0.0
bss 143660 143660 0 0.0
rodata 135808 135808 0 0.0
text 803188 803188 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146288 1146296 8 0.0
.bss 110544 110544 0 0.0
.data 1028 1028 0 0.0
.text 593384 593392 8 0.0
lock-app qpg6105+debug (read/write) 1116180 1116180 0 0.0
.bss 106376 106376 0 0.0
.data 1032 1032 0 0.0
.text 563280 563280 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814512 814512 0 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574560 574560 0 0.0
lighting-app tlsr9518adk80d (read/write) 836616 836616 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592778 592778 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844576 844576 0 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598962 598962 0 0.0

@andy31415
Copy link
Contributor

fast tracking: this fixes CI and the darwin flake is very disruptive.

@bzbarsky-apple bzbarsky-apple merged commit 2aaf589 into project-chip:master Sep 23, 2022
bzbarsky-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 17, 2022
…tateCacheFailure

This is a re-landing of PR project-chip#22838.

* [Darwin Tests] Fix testAnySharedRemoteController

* [Darwin Tests] Fix testReadClusterStateCacheFailure
bzbarsky-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 17, 2022
…tateCacheFailure

This is a re-landing of PR project-chip#22838.

* [Darwin Tests] Fix testAnySharedRemoteController

* [Darwin Tests] Fix testReadClusterStateCacheFailure
bzbarsky-apple added a commit that referenced this pull request Nov 18, 2022
…tateCacheFailure (#23663)

This is a re-landing of PR #22838.

* [Darwin Tests] Fix testAnySharedRemoteController

* [Darwin Tests] Fix testReadClusterStateCacheFailure

Co-authored-by: Vivien Nicolas <[email protected]>
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
…tateCacheFailure (project-chip#23663)

This is a re-landing of PR project-chip#22838.

* [Darwin Tests] Fix testAnySharedRemoteController

* [Darwin Tests] Fix testReadClusterStateCacheFailure

Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants