-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin tests] Fix testAnySharedRemoteController and testReadClusterStateCacheFailure #22838
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_test_XPC_DoubleConnection
Sep 23, 2022
Merged
[Darwin tests] Fix testAnySharedRemoteController and testReadClusterStateCacheFailure #22838
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_test_XPC_DoubleConnection
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
September 23, 2022 12:51
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 23, 2022 12:51
vivien-apple
changed the title
Darwin test xpc double connection
[Darwin tests] Fix testAnySharedRemoteController and testReadClusterStateCacheFailure
Sep 23, 2022
PR #22838: Size comparison from edb93a0 to a313797 Increases (1 build for qpg)
Decreases (1 build for bl702)
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
andy31415
approved these changes
Sep 23, 2022
fast tracking: this fixes CI and the darwin flake is very disruptive. |
bzbarsky-apple
approved these changes
Sep 23, 2022
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 17, 2022
…tateCacheFailure This is a re-landing of PR project-chip#22838. * [Darwin Tests] Fix testAnySharedRemoteController * [Darwin Tests] Fix testReadClusterStateCacheFailure
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 17, 2022
…tateCacheFailure This is a re-landing of PR project-chip#22838. * [Darwin Tests] Fix testAnySharedRemoteController * [Darwin Tests] Fix testReadClusterStateCacheFailure
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 18, 2022
…tateCacheFailure (#23663) This is a re-landing of PR #22838. * [Darwin Tests] Fix testAnySharedRemoteController * [Darwin Tests] Fix testReadClusterStateCacheFailure Co-authored-by: Vivien Nicolas <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…tateCacheFailure (project-chip#23663) This is a re-landing of PR project-chip#22838. * [Darwin Tests] Fix testAnySharedRemoteController * [Darwin Tests] Fix testReadClusterStateCacheFailure Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
testReadClusterStateCacheFailure
testAnySharedRemoteController
Change overview
testReadClusterStateCacheFailure
to wait for the first XPC disconnect before issuing a read...MTRDeviceControllerOverXPC
andMTRDeviceOverXPC
in such a way that the proxy handle is not released while setting it up. It just seems that we don't really want to allocate an xpc connection for nothing. As a side effect it was allocated twice with a disconnect in between - which is why tests relying on a single disconnect were failing.