-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid polluting Pigweed environment namespace #22742
Conversation
PR #22742: Size comparison from 2466360 to dd200b8 Increases (4 builds for esp32, psoc6, qpg)
Decreases (4 builds for bl702, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22742: Size comparison from 847f450 to 60901a5 Decreases (1 build for bl702)
Full report (2 builds for bl702)
|
PR #22742: Size comparison from 3aa138f to 6e3841c Increases (6 builds for bl702, psoc6, telink)
Decreases (2 builds for bl602, cyw30739)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22742: Size comparison from fa9f977 to d616896 Increases (1 build for bl702)
Decreases (2 builds for bl702, psoc6)
Full report (22 builds for bl602, bl702, cyw30739, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
@agners could you apply restyle changes to this? |
PR #22742: Size comparison from df07c87 to e936a58 Increases (8 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (2 builds for telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Merge queue setting changed
e936a58
to
cd454cd
Compare
@andy31415 recreated the change on-top of current master and fixed styling. |
PR #22742: Size comparison from 379cde1 to cd454cd Decreases (2 builds for cc32xx, mbed)
Full report (2 builds for cc32xx, mbed)
|
Issue Being Resolved
Sourcing with custom Pigweed environment currently fails:
This presumably broke due to a Pigweed update.
Change overview
Clear the relevant environment variable to avoid Pigweed complaining about unknown environment variable.