-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux tv-casting-app: Adding Media subscriptions support #22709
Merged
chrisdecenzo
merged 1 commit into
project-chip:master
from
sharadb-amazon:lin-subs-20220916
Sep 23, 2022
Merged
Linux tv-casting-app: Adding Media subscriptions support #22709
chrisdecenzo
merged 1 commit into
project-chip:master
from
sharadb-amazon:lin-subs-20220916
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
msandstedt
September 18, 2022 05:23
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
September 18, 2022 05:23
PR #22709: Size comparison from 989ad8e to 6e90f48 Increases (10 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (3 builds for esp32, nrfconnect, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
lin-subs-20220916
branch
2 times, most recently
from
September 18, 2022 17:08
e9fa4cc
to
1380d29
Compare
PR #22709: Size comparison from 989ad8e to 1380d29 Increases (6 builds for bl602, psoc6, telink)
Decreases (1 build for bl702)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
lin-subs-20220916
branch
from
September 20, 2022 22:01
1380d29
to
3f2e833
Compare
PR #22709: Size comparison from 3aa138f to 3f2e833 Increases (3 builds for bl602, bl702, telink)
Decreases (1 build for bl602)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
sharadb-amazon
force-pushed
the
lin-subs-20220916
branch
from
September 20, 2022 22:50
3f2e833
to
59631af
Compare
PR #22709: Size comparison from 3aa138f to 59631af Increases (3 builds for bl702, cc13x2_26x2, esp32)
Decreases (5 builds for bl602, cc13x2_26x2, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
lin-subs-20220916
branch
from
September 21, 2022 02:41
59631af
to
c77ff53
Compare
sharadb-amazon
force-pushed
the
lin-subs-20220916
branch
from
September 21, 2022 02:48
c77ff53
to
c229d63
Compare
PR #22709: Size comparison from 3aa138f to c229d63 Increases (4 builds for cc13x2_26x2, esp32, telink)
Decreases (10 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Sep 21, 2022
hawk248
approved these changes
Sep 23, 2022
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
CastingServer does not expose any APIs to subscribe to media attribute changes on a Matter TV.
Fixes #20064
Change overview
Testing
Tested by running the Linux tv-casting-app against the tv-app. Checked that the subscription was established successfully as per the log statements. Following is a sample successful read response received on the tv-casting-app from the Android tv-app (content app):