-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android tv-casting-app: Fixing issues with handling responses for Media commands #22701
Merged
andy31415
merged 1 commit into
project-chip:master
from
sharadb-amazon:droid-fix-20220916
Sep 16, 2022
Merged
Android tv-casting-app: Fixing issues with handling responses for Media commands #22701
andy31415
merged 1 commit into
project-chip:master
from
sharadb-amazon:droid-fix-20220916
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
force-pushed
the
droid-fix-20220916
branch
from
September 16, 2022 18:29
35d75e1
to
a43bdcd
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
September 16, 2022 18:30
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 16, 2022 18:30
andy31415
approved these changes
Sep 16, 2022
Accept for 1.0: examples change |
PR #22701: Size comparison from 0574c55 to a43bdcd Increases (2 builds for telink)
Decreases (3 builds for bl702, nrfconnect)
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
chrisdecenzo
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
Testing
Tested using the Android tv-casting-app example.