Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android TV-app Build #22642

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix Android TV-app Build #22642

merged 1 commit into from
Sep 15, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Issue Being Resolved

Change overview

Android build regression in previous commit

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

PR #22642: Size comparison from 377ac09 to 56c7d7b

Decreases (6 builds for bl602, nrfconnect, telink)
platform target config section 377ac09 56c7d7b change % change
bl602 lighting-app bl602 (read/write) 1412878 1412870 -8 -0.0
.text 1067596 1067592 -4 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182739 1182723 -16 -0.0
text 815940 815936 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 804332 804328 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813860 -8 -0.0
text 574712 574708 -4 -0.0
lighting-app tlsr9518adk80d text 592850 592848 -2 -0.0
ota-requestor-app tlsr9518adk80d text 599112 599110 -2 -0.0
Full report (12 builds for bl602, k32w, linux, mbed, nrfconnect, telink)
platform target config section 377ac09 56c7d7b change % change
bl602 lighting-app bl602 (read/write) 1412878 1412870 -8 -0.0
.bss 121585 121585 0 0.0
.data 9824 9824 0 0.0
.text 1067596 1067592 -4 -0.0
bl602+rpc (read/write) 1458346 1458346 0 0.0
.bss 129017 129017 0 0.0
.data 10208 10208 0 0.0
.text 1099198 1099198 0 0.0
k32w light k32w0+release (read/write) 649972 649972 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574464 574464 0 0.0
lock k32w0+release (read/write) 706960 706960 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630996 630996 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10349028 10349028 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503588 503588 0 0.0
.text 8191492 8191492 0 0.0
thermostat-no-ble arm64 (read only) 2368572 2368572 0 0.0
(read/write) 142545 142545 0 0.0
.bss 55249 55249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 76704 76704 0 0.0
.dynamic 560 560 0 0.0
.got 5096 5096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141748 141748 0 0.0
.text 1987728 1987728 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455808 2455808 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418452 1418452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182739 1182723 -16 -0.0
bss 143641 143641 0 0.0
rodata 144212 144212 0 0.0
text 815940 815936 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161923 1161923 0 0.0
bss 142868 142868 0 0.0
rodata 135804 135804 0 0.0
text 804332 804328 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813860 -8 -0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574712 574708 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 835800 835800 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592850 592848 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 843916 843916 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 599112 599110 -2 -0.0

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Sep 15, 2022
@woody-apple woody-apple enabled auto-merge (squash) September 15, 2022 03:04
@woody-apple woody-apple merged commit 898e166 into master Sep 15, 2022
@woody-apple woody-apple deleted the tvapps-android26 branch September 15, 2022 03:04
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.0] tv-app android build broken
3 participants