Fix completion naming in Darwin framework. #22557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
darwin-completion-naming
branch
from
a17b0c6 to
0e778e9
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
jtung-apple
approved these changes
Sep 12, 2022
|
Fast-tracking platform fix with review from platform owner. |
|
PR #22557: Size comparison from 43d7fd2 to 0e778e9 Increases (5 builds for bl602, bl702, cc13x2_26x2, psoc6)
Decreases (3 builds for cc13x2_26x2, esp32, k32w)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-completion-naming
branch
from
0e778e9 to
32d362c
Compare
|
PR #22557: Size comparison from 6a45e43 to 32d362c Increases (8 builds for cc13x2_26x2, efr32, esp32, psoc6, qpg)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-completion-naming
branch
from
32d362c to
9d1ec18
Compare
|
PR #22557: Size comparison from 6a45e43 to 9d1ec18 Increases (6 builds for cc13x2_26x2, efr32, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-completion-naming
branch
2 times, most recently
from
ef8bcfb to
756bd36
Compare
* Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. Fixes project-chip#22529 Addresses part of project-chip#22420
bzbarsky-apple
force-pushed
the
darwin-completion-naming
branch
from
756bd36 to
f9b37ea
Compare
|
PR #22557: Size comparison from 9ababd1 to f9b37ea Increases (5 builds for bl602, esp32, k32w, psoc6)
Decreases (2 builds for bl602, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. Fixes project-chip#22529 Addresses part of project-chip#22420
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 1, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue) which has a shim. * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 1, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 1, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 2, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 2, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 2, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 2, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 2, 2022
This is a re-landing of PR #22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #22420
Issue Being Resolved
Change overview
See above.