-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CurrentPositionLiftPercent100ths attribute read value mismatch #22497
Conversation
PR #22497: Size comparison from 9cb4c70 to 317b60d Increases above 0.2%:
Increases (8 builds for bl602, cc13x2_26x2, efr32, psoc6)
Decreases (16 builds for cc13x2_26x2, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22497: Size comparison from 27f9fb4 to fad6504 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, efr32, nrfconnect, psoc6, telink)
Decreases (16 builds for bl602, cc13x2_26x2, k32w, linux, nrfconnect, psoc6, telink)
Full report (33 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22497: Size comparison from 27f9fb4 to 196ef38 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, efr32, esp32, nrfconnect, psoc6)
Decreases (14 builds for bl602, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22497: Size comparison from e4c075f to bb8861e Increases above 0.2%:
Increases (10 builds for bl602, cc13x2_26x2, efr32, nrfconnect, psoc6)
Decreases (13 builds for bl602, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Full report (33 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/window-covering-server/window-covering-delegate.h
Outdated
Show resolved
Hide resolved
src/app/clusters/window-covering-server/window-covering-server.cpp
Outdated
Show resolved
Hide resolved
PR #22497: Size comparison from e0a9cca to 4c06f76 Increases above 0.2%:
Increases (12 builds for cc13x2_26x2, efr32, nrfconnect, psoc6, telink)
Decreases (13 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22497: Size comparison from e0a9cca to 2f0f97e Increases above 0.2%:
Increases (24 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, psoc6, qpg)
Decreases (19 builds for bl702, cc13x2_26x2, esp32, mbed, nrfconnect, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR i didn't have time to review it before today
…roject-chip#22497) * Fix CurrentPositionLiftPercent100ths attribute read value mismatch * Run codegen * Adjust the delay to improve the CI stability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mistake to fix
Currently, cert Test_TC_WNCV_3_1 and Test_TC_WNCV_3_2 are failed and temporarily disabled. This is because the current mock implementation of movement is one shot and up to the end straight after 5s, but the test requires the value change gradually when window is opened or closed.
Current mock implementation of window covering movement is done in WindowCovering cluster Server, this is not right, since the cluster server is used in both example app and product.
Issue Being Resolved
Change overview
Note: similar implementation for WindowApp will be done in a separate PR