-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android full build in CI #22486
Merged
andy31415
merged 5 commits into
project-chip:master
from
andy31415:split_out_android_builds
Sep 8, 2022
Merged
Fix android full build in CI #22486
andy31415
merged 5 commits into
project-chip:master
from
andy31415:split_out_android_builds
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
September 8, 2022 16:15
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 8, 2022 16:15
Marking as accepted for v1: this fixes CI (otherwise it will stay red, which is not ideal) and the change in core is adding an include only which should be very safe. |
tcarmelveilleux
approved these changes
Sep 8, 2022
fast track: android specific change, fixing CI infra |
PR #22486: Size comparison from 0e3bbae to 1b6f5ad Increases (3 builds for esp32, nrfconnect, psoc6)
Decreases (3 builds for bl602, efr32, psoc6)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Also tagging for SVE: sve branch will encounter the same issues. |
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Sep 9, 2022
* Split out android builds to not use as much space during building * Ensure we can test android builds with act * Since we use checkout_submodules, submodules are not needed on the other checkout * Add some documentation on using act to test * Fix ENOBUFS being undefined when compiling tv-casting-app on arm
andy31415
added a commit
that referenced
this pull request
Sep 9, 2022
* Fix Android Tests in CI (#22464) * Enable android CI on push as well * Revert "Enable android CI on push as well" This reverts commit 3bcca58. * Add submodule checkout to full android: needed to set secure.directory * Distinct name for full android builds * Place the submodule checkout to the right location * Undo the wandalen retry removal Co-authored-by: Andrei Litvin <[email protected]> * Fix android full build in CI (#22486) * Split out android builds to not use as much space during building * Ensure we can test android builds with act * Since we use checkout_submodules, submodules are not needed on the other checkout * Add some documentation on using act to test * Fix ENOBUFS being undefined when compiling tv-casting-app on arm Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Split out android builds to not use as much space during building * Ensure we can test android builds with act * Since we use checkout_submodules, submodules are not needed on the other checkout * Add some documentation on using act to test * Fix ENOBUFS being undefined when compiling tv-casting-app on arm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Fixes #22485
Change overview
CI was running out of space, so some builds were never tested. Changes contains:
act
so that these builds can locally be testedsubmodules: true
option from checkout, since we use checkout_submodulesOverall now
act -j full_android
passed for me.