-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat an ERR_MEM on send as non-fatal on LwIP. #22418
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:lwip-err-mem
Sep 6, 2022
Merged
Treat an ERR_MEM on send as non-fatal on LwIP. #22418
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:lwip-err-mem
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That can be caused by a transient lack of TX buffers. We should just try again via MRP. Fixes project-chip#21671
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
rgoliver and
saurabhst
September 6, 2022 16:30
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 6, 2022 16:30
PR #22418: Size comparison from e535710 to 2d408b2 Increases (13 builds for bl602, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (13 builds for bl602, k32w, linux, mbed, nrfconnect, qpg, telink)
|
tcarmelveilleux
approved these changes
Sep 6, 2022
PR #22418: Size comparison from e535710 to d1f3d21 Increases (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Accepted for 1.0 as high value fix for LWIP |
jmartinez-silabs
approved these changes
Sep 6, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Treat an ERR_MEM on send as non-fatal on LwIP. That can be caused by a transient lack of TX buffers. We should just try again via MRP. Fixes project-chip#21671 * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That can be caused by a transient lack of TX buffers. We should just
try again via MRP.
Fixes #21671
Problem
Errors that should be transient end up being fatal.
Change overview
Treat ERR_MEM on send as a transient error when using LwIP.
Testing
Needs real-world testing. I asked for some in #21671 but no responses so far.