[SVE2] Add timer compensation in level control cluster #22395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
andrei-menzopol
force-pushed
the
fix-level-control
branch
from
050d067 to
98f8918
Compare
|
PR #22395: Size comparison from bf066a2 to 98f8918 Increases (8 builds for bl702, k32w, nrfconnect, qpg, telink)
Full report (15 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 7, 2022
|
Thank you for the review |
andrei-menzopol
force-pushed
the
fix-level-control
branch
from
98f8918 to
b5d8cda
Compare
|
PR #22395: Size comparison from 0bff5ad to b5d8cda Increases (12 builds for bl602, bl702, k32w, nrfconnect, qpg, telink)
Full report (16 builds for bl602, bl702, k32w, linux, nrfconnect, qpg, telink)
|
andrei-menzopol
force-pushed
the
fix-level-control
branch
from
b5d8cda to
1c335ac
Compare
|
PR #22395: Size comparison from 7b284c0 to 1c335ac Increases (23 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg)
Decreases (7 builds for cc13x2_26x2, psoc6)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
* Move timestamp in state * Use callback compute time * Use only duration and timestamp Signed-off-by: Andrei Menzopol <[email protected]>
* Change structure and function names * Change function definition * Add comments Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
andrei-menzopol
force-pushed
the
fix-level-control
branch
from
1c335ac to
99342f6
Compare
|
PR #22395: Size comparison from 9f08fc1 to 99342f6 Increases (26 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 17, 2022
jmartinez-silabs
approved these changes
Oct 17, 2022
dvagner
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 25, 2022
…22395) * [SVE2] Add timer compensation in level control cluster Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Fix signedness error Signed-off-by: Andrei Menzopol <[email protected]> * Add requested changes * Move timestamp in state * Use callback compute time * Use only duration and timestamp Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Resolve conversations * Change structure and function names * Change function definition * Add comments Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Change struct to C++ style Signed-off-by: Andrei Menzopol <[email protected]> * Update function, add comments, change names Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Fix condition Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Restyled.io <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…22395) * [SVE2] Add timer compensation in level control cluster Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Fix signedness error Signed-off-by: Andrei Menzopol <[email protected]> * Add requested changes * Move timestamp in state * Use callback compute time * Use only duration and timestamp Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Resolve conversations * Change structure and function names * Change function definition * Add comments Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Change struct to C++ style Signed-off-by: Andrei Menzopol <[email protected]> * Update function, add comments, change names Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Fix condition Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Restyled.io <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…22395) * [SVE2] Add timer compensation in level control cluster Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Fix signedness error Signed-off-by: Andrei Menzopol <[email protected]> * Add requested changes * Move timestamp in state * Use callback compute time * Use only duration and timestamp Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Resolve conversations * Change structure and function names * Change function definition * Add comments Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Change struct to C++ style Signed-off-by: Andrei Menzopol <[email protected]> * Update function, add comments, change names Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * Fix condition Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Level Control tests (such as TC-LVL-4.1) fail because current level doesn't increase at the rate specified by Move command. This is due to delays introduced by crypto operations in CASE establishment when read requests are sent to the DUT.
Change overview
This PR adds timer compensation in level control cluster.
Fixes #22299
Inspired by #21755
Testing
Tested TC-LVL-4.1 with TH and it passes