-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chip-cert: Added Support for All Possible SubjectDN Attributes in Operational Certificates #22201
chip-cert: Added Support for All Possible SubjectDN Attributes in Operational Certificates #22201
Conversation
PR #22201: Size comparison from 7e00546 to 7c06ee6 Increases (9 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
@emargolis what is the 1.0 justification here? What is the sideffect of NOT having this in the 1.0 branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes: need 1.0 justification.
All PRs created after Aug 22 should be linked to an issue (except hotfixes or trivial changes) and provide solid justification for 1.0 (fixing crash, fixing a blocker issue, etc.).
The bar is higher than "safe change" or "good/useful change".
This tool enhancement will enable new test vectors creation, which were not possible before. As a result we will be able to increate code test coverage by testing new operational certificates with new fields (RDNs) in the SubjectDN. |
…ational Certificates.
7c06ee6
to
0c89238
Compare
PR #22201: Size comparison from e535710 to 0c89238 Increases (5 builds for cc13x2_26x2, esp32, nrfconnect, qpg)
Decreases (8 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Added ticket: #22442 |
Accepting for 1.0: this changes |
…ational Certificates. (project-chip#22201)
Problem
Need to support all possible attributes in the subjectDN of the operational certificates.
Change overview
Implemented.
Testing
Manual tool testing