-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libnl-dev to chip-build Dockerfile #22047
Merged
andy31415
merged 3 commits into
project-chip:master
from
andy31415:add_libnl_to_dockerfile
Aug 23, 2022
Merged
Add libnl-dev to chip-build Dockerfile #22047
andy31415
merged 3 commits into
project-chip:master
from
andy31415:add_libnl_to_dockerfile
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
August 19, 2022 18:39
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 19, 2022 18:39
PR #22047: Size comparison from 6ca1f85 to 5c293a9 Increases (3 builds for bl602, telink)
Decreases (4 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
PR #22047: Size comparison from 7c53493 to 1ac53a1 Increases (1 build for cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
/rebase |
1 similar comment
/rebase |
tcarmelveilleux
approved these changes
Aug 23, 2022
PR #22047: Size comparison from 65d9ccf to 9ac1290 Increases (2 builds for k32w, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of preparing for #22046
This provides libnl as available in chip-build. As a stand-alone it is a noop (slight increase in image size probably) however this allows us to use libnl for future builds.
A separate change is likely needed if we need cross compile support (so that our cross build environment also has it).
Change overview
add
libnl-3-dev
andlibnl-routing-3-dev
to DockerfileTesting
ran apt-get on a local image to check that the names are ok. Validated that pkg-config can find the new libraries and required flags.