Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mtrpayloadparser check type #22024

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Mtrpayloadparser check type #22024

merged 1 commit into from
Aug 18, 2022

Conversation

nivi-apple
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

Do not pass code type to setupPayloadForOnboardingPayload. Instead just get the code type from the payload itself.

Testing

How was this tested? (at least one bullet point required)

  • Ran unit tests.

@nivi-apple nivi-apple force-pushed the mtrpayloadparser_check_type branch from cc01097 to dd23c60 Compare August 18, 2022 23:42
@nivi-apple nivi-apple force-pushed the mtrpayloadparser_check_type branch from dd23c60 to 608c245 Compare August 18, 2022 23:43
@github-actions github-actions bot removed the platform label Aug 18, 2022
@woody-apple woody-apple merged commit 2a5f7fe into project-chip:master Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Aug 19, 2022 •
edited
Loading

PR #22024: Size comparison from c9d2148 to 608c245

Increases (6 builds for bl602, cc13x2_26x2, k32w, nrfconnect, telink)
platform target config section c9d2148 608c245 change % change
bl602 lighting-app bl602 .text 1051040 1051044 4 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 656823 656831 8 0.0
.text 554584 554592 8 0.0
pump-app LP_CC2652R7 (read only) 684743 684751 8 0.0
.text 594300 594308 8 0.0
k32w light k32w0+release (read/write) 646660 646676 16 0.0
.text 571464 571480 16 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803068 803072 4 0.0
telink lighting-app tlsr9518adk80d text 589406 589408 2 0.0
Decreases (4 builds for cc13x2_26x2, esp32, telink)
platform target config section c9d2148 608c245 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 180560 180552 -8 -0.0
pump-app LP_CC2652R7 (read/write) 157760 157752 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1031272 1031268 -4 -0.0
.flash.text 1031272 1031268 -4 -0.0
telink light-switch-app tlsr9518adk80d text 571316 571314 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section c9d2148 608c245 change % change
bl602 lighting-app bl602 (read/write) 1383858 1383858 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051040 1051044 4 0.0
bl602+rpc (read/write) 1429370 1429370 0 0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082800 1082800 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673027 673027 0 0.0
(read/write) 178468 178468 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583876 583876 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637747 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559444 559444 0 0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167616 167616 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656823 656831 8 0.0
(read/write) 180560 180552 -8 -0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554584 554592 8 0.0
pump-app LP_CC2652R7 (read only) 684743 684751 8 0.0
(read/write) 157760 157752 -8 -0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594300 594308 8 0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173380 173380 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665710 665710 0 0.0
(read/write) 181304 181304 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579612 579612 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586618 586618 0 0.0
.app_xip_area 463284 463284 0 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592418 592418 0 0.0
.app_xip_area 464300 464300 0 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599538 599538 0 0.0
.app_xip_area 476924 476924 0 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100980 1100980 0 0.0
.bss 133372 133372 0 0.0
.data 2068 2068 0 0.0
.text 965516 965516 0 0.0
BRD4161A+rpc (read/write) 1155232 1155232 0 0.0
.bss 150060 150060 0 0.0
.data 2280 2280 0 0.0
.text 1002872 1002872 0 0.0
BRD4161A+rs911x (read/write) 990152 990152 0 0.0
.bss 162696 162696 0 0.0
.data 2056 2056 0 0.0
.text 825380 825380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139636 1139636 0 0.0
.bss 145872 145872 0 0.0
.data 2064 2064 0 0.0
.text 991680 991680 0 0.0
window-app BRD4161A (read/write) 1092420 1092420 0 0.0
.bss 134812 134812 0 0.0
.data 2096 2096 0 0.0
.text 955492 955492 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031272 1031268 -4 -0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218440 218440 0 0.0
.flash.text 1031272 1031268 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084371 1084371 0 0.0
(read/write) 491544 491544 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078987 1078987 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646660 646676 16 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571464 571480 16 0.0
lock k32w0+release (read/write) 704196 704196 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628528 628528 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10255980 10255980 0 0.0
(read/write) 699105 699105 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643792 643792 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493340 493340 0 0.0
.text 8124596 8124596 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180603 1180603 0 0.0
bss 143737 143737 0 0.0
rodata 143356 143356 0 0.0
text 814664 814664 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159799 1159799 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803068 803072 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700996 1700996 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217459 1217459 0 0.0
.debug_aranges 111528 111528 0 0.0
.debug_frame 372352 372352 0 0.0
.debug_info 26643195 26643195 0 0.0
.debug_line 3646638 3646638 0 0.0
.debug_loc 3562036 3562036 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3393852 3393852 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569346 569346 0 0.0
.symtab 420416 420416 0 0.0
.text 1540264 1540264 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1644204 1644204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209298 0 0.0
.debug_aranges 111000 111000 0 0.0
.debug_frame 375432 375432 0 0.0
.debug_info 26379890 26379890 0 0.0
.debug_line 3667042 3667042 0 0.0
.debug_loc 3549673 3549673 0 0.0
.debug_ranges 335192 335192 0 0.0
.debug_str 3382841 3382841 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 533820 0 0.0
.symtab 407008 407008 0 0.0
.text 1484208 1484208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561436 1561436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1043971 0 0.0
.debug_aranges 103168 103168 0 0.0
.debug_frame 345676 345676 0 0.0
.debug_info 21844447 21844447 0 0.0
.debug_line 3238220 3238220 0 0.0
.debug_loc 3249205 3249205 0 0.0
.debug_ranges 301032 301032 0 0.0
.debug_str 3188935 3188935 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467101 0 0.0
.symtab 374064 374064 0 0.0
.text 1409784 1409784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598708 1598708 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051147 0 0.0
.debug_aranges 103840 103840 0 0.0
.debug_frame 348500 348500 0 0.0
.debug_info 22199615 22199615 0 0.0
.debug_line 3246906 3246906 0 0.0
.debug_loc 3289325 3289325 0 0.0
.debug_ranges 304448 304448 0 0.0
.debug_str 3216366 3216366 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473342 0 0.0
.symtab 377248 377248 0 0.0
.text 1442560 1442560 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808736 808736 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571316 571314 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830680 830680 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589406 589408 2 0.0

woody-apple added a commit that referenced this pull request Aug 19, 2022
@woody-apple
Revert "Check the onboarding payload code type in MTROnboardingPayloa…
0143a8e 
…dParser (#22024)"

This reverts commit 2a5f7fe.
@woody-apple woody-apple mentioned this pull request Aug 19, 2022
Merged
woody-apple added a commit that referenced this pull request Aug 19, 2022
@woody-apple
Revert "Check the onboarding payload code type in MTROnboardingPayloa…
b506a86 
…dParser (#22024)" (#22026)

This reverts commit 2a5f7fe.
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@nivi-apple @isiu-apple
Check the onboarding payload code type in MTROnboardingPayloadParser (p…
8616ba3 
…roject-chip#22024)
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@woody-apple @isiu-apple
Revert "Check the onboarding payload code type in MTROnboardingPayloa…
82938e0 
…dParser (project-chip#22024)" (project-chip#22026)

This reverts commit 2a5f7fe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MTROnboardingPayloadParser needs to check the code type
2 participants
@nivi-apple @woody-apple