urgent event needs to honor min interval for subscription. #21938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
yunhanw-google
changed the title
|
PR #21938: Size comparison from 12c8c0a to 13fad63 Increases (6 builds for cc13x2_26x2)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Aug 17, 2022
yunhanw-google
force-pushed
the
feature/improve_urgent_event
branch
from
13fad63
to
7d79cf5
Compare
|
PR #21938: Size comparison from b1f2fc7 to 7d79cf5 Increases (10 builds for cc13x2_26x2, psoc6)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/improve_urgent_event
branch
from
7d79cf5
to
8e408d3
Compare
|
PR #21938: Size comparison from 507bb70 to 8e408d3 Increases (10 builds for cc13x2_26x2, psoc6)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/improve_urgent_event
branch
from
d6c3f85
to
45fcd3b
Compare
|
PR #21938: Size comparison from 1f83af0 to 45fcd3b Increases (10 builds for cc13x2_26x2, psoc6)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/improve_urgent_event
branch
from
45fcd3b
to
ec204b2
Compare
|
PR #21938: Size comparison from dfc1a70 to ec204b2 Increases (10 builds for cc13x2_26x2, psoc6)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
mrjerryjohns
approved these changes
Aug 22, 2022
yunhanw-google
force-pushed
the
feature/improve_urgent_event
branch
from
da8e485
to
9c2df63
Compare
jmartinez-silabs
approved these changes
Aug 23, 2022
|
PR #21938: Size comparison from 5f94d38 to 9c2df63 Increases (10 builds for cc13x2_26x2, psoc6)
Decreases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#21938) * Improve urgent event -- In latest spec, urgent event needs to honor min interval for subscription. -- Add new fflag, urgentEvent, and remove unused flag, SuppressResponse -- ForceDirty would be used when recieving the initial request, where it mark the corresponding handler with dirtiness. -- When there is urgent event, we would set new flag, UrgentEvent, in readHandler instead of setting ForceDirty, after minInterval elapsed, the urgent event would be sent out. Modify the existing urgent event test and check if event can be generated after minInterval elapsed. * address comments * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#21864
In latest spec, urgent event needs to honor min interval for
subscription.
Change overview
-- Add new flag, UrgentEvent, and remove unused flag, SuppressResponse
-- ForceDirty would be used when receiving the initial request, where it
marks the corresponding handler with dirtiness.
-- When there is urgent event, we would set new flag, UrgentEvent, in
readHandler, after minInterval elapsed,
the urgent event would be sent out.
--Remove UpdateReadHandlerDirty in reporting engine. After sending out all chunked report, it would clear out UrgentEvent flag and ForceDirty flag, and mark mPreviousReportsBeginGeneration with mCurrentReportsBeginGeneration, which means the readHandler would be clear at that moment, we don't need extra UpdateReadHandlerDirty to check overlapped/intersected path between global dirty set and interested attribute paths.
Testing
Modify the existing urgent event test and check if event can be generated after minInterval elapsed.