Feedback from Android commissioning fixes #21927

chrisdecenzo · 2022-08-16T14:12:35Z

Problem

Cleanup from Issue 21314 - add proper step to commissioner for obtaining network credentials #21876. Make sure NetworkCredentialsReady() is called when network credentials are set by java layer and in kNeedsNetworkCreds step.
Cleanup from Allow partial validation of DAC and CD (for external cloud or custom app based validation) #21725. Address feedback received post-merge.

Change overview

Make sure NetworkCredentialsReady() is called when network credentials are set by java layer and in kNeedsNetworkCreds step.
Add comments.

Testing

Android chip controller

github-actions · 2022-08-16T14:37:50Z

PR #21927: Size comparison from 5a05207 to d5d0fe2

Full report (3 builds for mbed, nrfconnect)

platform	target	config	section	`5a05207`	`d5d0fe2`
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2454328	2454328
			.bss	214692	214692
			.data	5872	5872
			.text	1416972	1416972
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1179683	1179683
			bss	143375	143375
			rodata	143268	143268
			text	814084	814084
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	`1159543`	`1159543`
			bss	142612	142612
			rodata	134944	134944
			text	803072	803072

src/controller/java/src/chip/devicecontroller/ChipDeviceController.java

src/credentials/attestation_verifier/DacOnlyPartialAttestationVerifier.h

…ller.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

…Verifier.h Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

* Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>

github-actions · 2022-08-16T19:51:59Z

PR #21927: Size comparison from 5a05207 to 4048467

Decreases (10 builds for efr32, mbed, nrfconnect, telink)

platform	target	config	section	`5a05207`	`4048467`	change	% change
efr32	lighting-app	BRD4161A	(read/write)	1100620	1100460	-160	-0.0
			.bss	133020	132988	-32	-0.0
			.text	965512	965384	-128	-0.0
		BRD4161A+rpc	(read/write)	`1154860`	1154700	-160	-0.0
			.bss	149708	149676	-32	-0.0
			.text	`1002852`	1002724	-128	-0.0
		BRD4161A+rs911x	(read/write)	989748	989636	-112	-0.0
			.bss	162344	162312	-32	-0.0
			.text	825328	825248	-80	-0.0
	lock-app	BRD4161A+wf200	(read/write)	`1139216`	1139136	-80	-0.0
			.bss	145520	145488	-32	-0.0
			.text	991612	991564	-48	-0.0
	window-app	BRD4161A	(read/write)	1092080	`1091920`	-160	-0.0
			.bss	134460	134428	-32	-0.0
			.text	955504	955376	-128	-0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2454328	`2454264`	-64	-0.0
			.bss	214692	214660	-32	-0.0
			.text	1416972	1416908	-64	-0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1179683	1179539	-144	-0.0
			bss	143375	143343	-32	-0.0
			text	814084	814076	-8	-0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	`1159543`	`1159415`	-128	-0.0
			bss	142612	142580	-32	-0.0
			text	803072	803064	-8	-0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	808416	808344	-72	-0.0
			bss	71096	71064	-32	-0.0
			text	571346	571304	-42	-0.0
	lighting-app	tlsr9518adk80d	(read/write)	830352	830280	-72	-0.0
			bss	71952	71920	-32	-0.0
			text	589436	589396	-40	-0.0

Full report (10 builds for efr32, mbed, nrfconnect, telink)

platform	target	config	section	`5a05207`	`4048467`	change	% change
efr32	lighting-app	BRD4161A	(read/write)	1100620	1100460	-160	-0.0
			.bss	133020	132988	-32	-0.0
			.data	2068	2068	0	0.0
			.text	965512	965384	-128	-0.0
		BRD4161A+rpc	(read/write)	`1154860`	1154700	-160	-0.0
			.bss	149708	149676	-32	-0.0
			.data	2280	2280	0	0.0
			.text	`1002852`	1002724	-128	-0.0
		BRD4161A+rs911x	(read/write)	989748	989636	-112	-0.0
			.bss	162344	162312	-32	-0.0
			.data	2056	2056	0	0.0
			.text	825328	825248	-80	-0.0
	lock-app	BRD4161A+wf200	(read/write)	`1139216`	1139136	-80	-0.0
			.bss	145520	145488	-32	-0.0
			.data	2064	2064	0	0.0
			.text	991612	991564	-48	-0.0
	window-app	BRD4161A	(read/write)	1092080	`1091920`	-160	-0.0
			.bss	134460	134428	-32	-0.0
			.data	2096	2096	0	0.0
			.text	955504	955376	-128	-0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2454328	`2454264`	-64	-0.0
			.bss	214692	214660	-32	-0.0
			.data	5872	5872	0	0.0
			.text	1416972	1416908	-64	-0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1179683	1179539	-144	-0.0
			bss	143375	143343	-32	-0.0
			rodata	143268	143268	0	0.0
			text	814084	814076	-8	-0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	`1159543`	`1159415`	-128	-0.0
			bss	142612	142580	-32	-0.0
			rodata	134944	134944	0	0.0
			text	803072	803064	-8	-0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	808416	808344	-72	-0.0
			bss	71096	71064	-32	-0.0
			noinit	43488	43488	0	0.0
			text	571346	571304	-42	-0.0
	lighting-app	tlsr9518adk80d	(read/write)	830352	830280	-72	-0.0
			bss	71952	71920	-32	-0.0
			noinit	43488	43488	0	0.0
			text	589436	589396	-40	-0.0

* Feedback from Android commissioning fixes * Update src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Update src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Update src/credentials/attestation_verifier/DacOnlyPartialAttestationVerifier.h Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Restyle Feedback from Android commissioning fixes (#21928) * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>

* Feedback from Android commissioning fixes * Update src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Update src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Update src/credentials/attestation_verifier/DacOnlyPartialAttestationVerifier.h Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Restyle Feedback from Android commissioning fixes (project-chip#21928) * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>

Feedback from Android commissioning fixes

d5d0fe2

github-actions bot added the controller label Aug 16, 2022

restyled-io bot mentioned this pull request Aug 16, 2022

Restyle Feedback from Android commissioning fixes #21928

Merged

tcarmelveilleux reviewed Aug 16, 2022

View reviewed changes

src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Aug 16, 2022

View reviewed changes

src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Aug 16, 2022

View reviewed changes

src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Aug 16, 2022

View reviewed changes

src/credentials/attestation_verifier/DacOnlyPartialAttestationVerifier.h Outdated Show resolved Hide resolved

tcarmelveilleux approved these changes Aug 16, 2022

View reviewed changes

chrisdecenzo and others added 4 commits August 16, 2022 11:50

Update src/controller/java/src/chip/devicecontroller/ChipDeviceContro…

5e20aa6

…ller.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

Update src/controller/java/src/chip/devicecontroller/ChipDeviceContro…

ba2bf3c

…ller.java Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

Update src/credentials/attestation_verifier/DacOnlyPartialAttestation…

fc3482d

…Verifier.h Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

Restyle Feedback from Android commissioning fixes (#21928)

4048467

* Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>

pullapprove bot requested review from anush-apple, arkq, Byungjoo-Lee, bzbarsky-apple, carol-apple, chshu, chulspro, Damian-Nordic, dhrishi and electrocucaracha August 16, 2022 18:53

pullapprove bot requested review from lazarkov, saurabhst, LuDuda, selissia, msandstedt, tecimovic, vijs, vivien-apple, wbschiller, woody-apple and xylophone21 August 16, 2022 18:53

pullapprove bot added the review - pending label Aug 16, 2022

sharadb-amazon approved these changes Aug 16, 2022

View reviewed changes

woody-apple approved these changes Aug 16, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Aug 16, 2022

woody-apple enabled auto-merge (squash) August 16, 2022 23:50

woody-apple merged commit 06457ae into master Aug 17, 2022

woody-apple deleted the tvapps-android23 branch August 17, 2022 00:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feedback from Android commissioning fixes #21927

Feedback from Android commissioning fixes #21927

chrisdecenzo commented Aug 16, 2022

github-actions bot commented Aug 16, 2022 •

edited

Loading

github-actions bot commented Aug 16, 2022 •

edited

Loading

Feedback from Android commissioning fixes #21927

Feedback from Android commissioning fixes #21927

Conversation

chrisdecenzo commented Aug 16, 2022

Problem

Change overview

Testing

github-actions bot commented Aug 16, 2022 • edited Loading

github-actions bot commented Aug 16, 2022 • edited Loading

github-actions bot commented Aug 16, 2022 •

edited

Loading

github-actions bot commented Aug 16, 2022 •

edited

Loading