Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enums in admin commissioning cluster #21890

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Fix enums in admin commissioning cluster #21890

merged 3 commits into from
Aug 16, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

Change overview

  • This PR updates the enum values

Testing

  • Unit tests still pass
  • Cert tests still pass

@tcarmelveilleux
Fix enums in admin commissioning cluster
cb94003 
- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes project-chip#21887

Testing done:
- Unit tests still pass
- Cert tests still pass
@github-actions
Copy link

github-actions bot commented Aug 15, 2022 •
edited
Loading

PR #21890: Size comparison from 89232c5 to cb94003

Increases (8 builds for bl602, efr32, linux, p6, telink)
platform target config section 89232c5 cb94003 change % change
bl602 lighting-app bl602 (read/write) 1383050 1383058 8 0.0
.text 1050716 1050724 8 0.0
bl602+rpc (read/write) 1428290 1428298 8 0.0
.text 1082220 1082224 4 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 1154264 1154280 16 0.0
.text 1002296 1002312 16 0.0
lock-app BRD4161A+wf200 (read/write) 1139100 1139116 16 0.0
.text 991520 991536 16 0.0
window-app BRD4161A (read/write) 1091444 1091460 16 0.0
.text 954916 954932 16 0.0
linux chip-tool-ipv6only arm64 (read only) 10130196 10130772 576 0.0
.text 8005780 8006356 576 0.0
p6 lock-app default (read/write) 1597180 1597196 16 0.0
.text 1441384 1441400 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 830304 830312 8 0.0
text 589386 589390 4 0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 89232c5 cb94003 change % change
bl602 lighting-app bl602 (read/write) 1383050 1383058 8 0.0
.bss 119882 119882 0 0.0
.data 4480 4480 0 0.0
.text 1050716 1050724 8 0.0
bl602+rpc (read/write) 1428290 1428298 8 0.0
.bss 127322 127322 0 0.0
.data 4600 4600 0 0.0
.text 1082220 1082224 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672303 672303 0 0.0
(read/write) 179208 179208 0 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88703 88703 0 0.0
.text 583284 583284 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637679 637679 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77951 77951 0 0.0
.text 559404 559404 0 0.0
lock-ftd LP_CC2652R7 (read only) 674027 674027 0 0.0
(read/write) 167676 167676 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76643 76643 0 0.0
.text 596904 596904 0 0.0
lock-mtd LP_CC2652R7 (read only) 656779 656779 0 0.0
(read/write) 180612 180612 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101731 101731 0 0.0
.text 554568 554568 0 0.0
pump-app LP_CC2652R7 (read only) 684771 684771 0 0.0
(read/write) 157740 157740 0 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89931 89931 0 0.0
.text 594356 594356 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669223 669223 0 0.0
(read/write) 173408 173408 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85487 85487 0 0.0
.text 583256 583256 0 0.0
shell LP_CC2652R7 (read only) 664994 664994 0 0.0
(read/write) 182036 182036 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85650 85650 0 0.0
.text 579028 579028 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586006 586006 0 0.0
.app_xip_area 462672 462672 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591822 591822 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598962 598962 0 0.0
.app_xip_area 476348 476348 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1099996 1099996 0 0.0
.bss 132980 132980 0 0.0
.data 2068 2068 0 0.0
.text 964928 964928 0 0.0
BRD4161A+rpc (read/write) 1154264 1154280 16 0.0
.bss 149668 149668 0 0.0
.data 2280 2280 0 0.0
.text 1002296 1002312 16 0.0
BRD4161A+rs911x (read/write) 989408 989408 0 0.0
.bss 162320 162320 0 0.0
.data 2056 2056 0 0.0
.text 825012 825012 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139100 1139116 16 0.0
.bss 145496 145496 0 0.0
.data 2064 2064 0 0.0
.text 991520 991536 16 0.0
window-app BRD4161A (read/write) 1091444 1091460 16 0.0
.bss 134412 134412 0 0.0
.data 2096 2096 0 0.0
.text 954916 954932 16 0.0
esp32 all-clusters-app c3devkit (read only) 1027614 1027614 0 0.0
(read/write) 1488218 1488218 0 0.0
.dram0.bss 70480 70480 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217704 217704 0 0.0
.flash.text 1027614 1027614 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1081007 1081007 0 0.0
(read/write) 490168 490168 0 0.0
.dram0.bss 75984 75984 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248044 248044 0 0.0
.flash.text 1075623 1075623 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645028 645028 0 0.0
.bss 69848 69848 0 0.0
.data 2044 2044 0 0.0
.text 570408 570408 0 0.0
lock k32w0+release (read/write) 702572 702572 0 0.0
.bss 70320 70320 0 0.0
.data 2052 2052 0 0.0
.text 627472 627472 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10130196 10130772 576 0.0
(read/write) 698673 698673 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643424 643424 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 487412 487412 0 0.0
.text 8005780 8006356 576 0.0
thermostat-no-ble arm64 (read only) 2356244 2356244 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140508 140508 0 0.0
.text 1978016 1978016 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454392 2454392 0 0.0
.bss 214692 214692 0 0.0
.data 5872 5872 0 0.0
.text 1417036 1417036 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180003 1180003 0 0.0
bss 143350 143350 0 0.0
rodata 143412 143412 0 0.0
text 814396 814396 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159899 1159899 0 0.0
bss 142588 142588 0 0.0
rodata 135108 135108 0 0.0
text 803384 803384 0 0.0
p6 all-clusters-app default (read only) 881392 881392 0 0.0
(read/write) 1697300 1697300 0 0.0
.bss 149296 149296 0 0.0
.data 2656 2656 0 0.0
.text 1536960 1536960 0 0.0
all-clusters-minimal-app default (read only) 882112 882112 0 0.0
(read/write) 1641340 1641340 0 0.0
.bss 148576 148576 0 0.0
.data 2656 2656 0 0.0
.text 1481720 1481720 0 0.0
light-app default (read only) 890432 890432 0 0.0
(read/write) 1560012 1560012 0 0.0
.bss 140464 140464 0 0.0
.data 2448 2448 0 0.0
.text 1408712 1408712 0 0.0
lock-app default (read only) 885936 885936 0 0.0
(read/write) 1597180 1597196 16 0.0
.bss 144944 144944 0 0.0
.data 2464 2464 0 0.0
.text 1441384 1441400 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808384 808384 0 0.0
bss 71096 71096 0 0.0
noinit 43488 43488 0 0.0
text 571310 571310 0 0.0
lighting-app tlsr9518adk80d (read/write) 830304 830312 8 0.0
bss 71952 71952 0 0.0
noinit 43488 43488 0 0.0
text 589386 589390 4 0.0

@github-actions github-actions bot added the tests label Aug 15, 2022
@github-actions
Copy link

github-actions bot commented Aug 15, 2022 •
edited
Loading

PR #21890: Size comparison from 89232c5 to f2ac0e2

Increases (8 builds for bl602, efr32, esp32, linux, p6)
platform target config section 89232c5 f2ac0e2 change % change
bl602 lighting-app bl602 (read/write) 1383050 1383058 8 0.0
.text 1050716 1050720 4 0.0
bl602+rpc (read/write) 1428290 1428298 8 0.0
.text 1082220 1082224 4 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 1154264 1154280 16 0.0
.text 1002296 1002312 16 0.0
lock-app BRD4161A+wf200 (read/write) 1139100 1139116 16 0.0
.text 991520 991536 16 0.0
window-app BRD4161A (read/write) 1091444 1091460 16 0.0
.text 954916 954932 16 0.0
esp32 all-clusters-app c3devkit (read only) 1027614 1027618 4 0.0
.flash.text 1027614 1027618 4 0.0
linux chip-tool-ipv6only arm64 (read only) 10130196 10130932 736 0.0
.text 8005780 8006516 736 0.0
p6 lock-app default (read/write) 1597180 1597196 16 0.0
.text 1441384 1441400 16 0.0
Decreases (1 build for telink)
platform target config section 89232c5 f2ac0e2 change % change
telink light-switch-app tlsr9518adk80d (read/write) 808384 808376 -8 -0.0
text 571310 571308 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 89232c5 f2ac0e2 change % change
bl602 lighting-app bl602 (read/write) 1383050 1383058 8 0.0
.bss 119882 119882 0 0.0
.data 4480 4480 0 0.0
.text 1050716 1050720 4 0.0
bl602+rpc (read/write) 1428290 1428298 8 0.0
.bss 127322 127322 0 0.0
.data 4600 4600 0 0.0
.text 1082220 1082224 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672303 672303 0 0.0
(read/write) 179208 179208 0 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88703 88703 0 0.0
.text 583284 583284 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637679 637679 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77951 77951 0 0.0
.text 559404 559404 0 0.0
lock-ftd LP_CC2652R7 (read only) 674027 674027 0 0.0
(read/write) 167676 167676 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76643 76643 0 0.0
.text 596904 596904 0 0.0
lock-mtd LP_CC2652R7 (read only) 656779 656779 0 0.0
(read/write) 180612 180612 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101731 101731 0 0.0
.text 554568 554568 0 0.0
pump-app LP_CC2652R7 (read only) 684771 684771 0 0.0
(read/write) 157740 157740 0 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89931 89931 0 0.0
.text 594356 594356 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669223 669223 0 0.0
(read/write) 173408 173408 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85487 85487 0 0.0
.text 583256 583256 0 0.0
shell LP_CC2652R7 (read only) 664994 664994 0 0.0
(read/write) 182036 182036 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85650 85650 0 0.0
.text 579028 579028 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586006 586006 0 0.0
.app_xip_area 462672 462672 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591822 591822 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598962 598962 0 0.0
.app_xip_area 476348 476348 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1099996 1099996 0 0.0
.bss 132980 132980 0 0.0
.data 2068 2068 0 0.0
.text 964928 964928 0 0.0
BRD4161A+rpc (read/write) 1154264 1154280 16 0.0
.bss 149668 149668 0 0.0
.data 2280 2280 0 0.0
.text 1002296 1002312 16 0.0
BRD4161A+rs911x (read/write) 989408 989408 0 0.0
.bss 162320 162320 0 0.0
.data 2056 2056 0 0.0
.text 825012 825012 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139100 1139116 16 0.0
.bss 145496 145496 0 0.0
.data 2064 2064 0 0.0
.text 991520 991536 16 0.0
window-app BRD4161A (read/write) 1091444 1091460 16 0.0
.bss 134412 134412 0 0.0
.data 2096 2096 0 0.0
.text 954916 954932 16 0.0
esp32 all-clusters-app c3devkit (read only) 1027614 1027618 4 0.0
(read/write) 1488218 1488218 0 0.0
.dram0.bss 70480 70480 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217704 217704 0 0.0
.flash.text 1027614 1027618 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1081007 1081007 0 0.0
(read/write) 490168 490168 0 0.0
.dram0.bss 75984 75984 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248044 248044 0 0.0
.flash.text 1075623 1075623 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645028 645028 0 0.0
.bss 69848 69848 0 0.0
.data 2044 2044 0 0.0
.text 570408 570408 0 0.0
lock k32w0+release (read/write) 702572 702572 0 0.0
.bss 70320 70320 0 0.0
.data 2052 2052 0 0.0
.text 627472 627472 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10130196 10130932 736 0.0
(read/write) 698673 698673 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643424 643424 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 487412 487412 0 0.0
.text 8005780 8006516 736 0.0
thermostat-no-ble arm64 (read only) 2356244 2356244 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140508 140508 0 0.0
.text 1978016 1978016 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454392 2454392 0 0.0
.bss 214692 214692 0 0.0
.data 5872 5872 0 0.0
.text 1417036 1417036 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180003 1180003 0 0.0
bss 143350 143350 0 0.0
rodata 143412 143412 0 0.0
text 814396 814396 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159899 1159899 0 0.0
bss 142588 142588 0 0.0
rodata 135108 135108 0 0.0
text 803384 803384 0 0.0
p6 all-clusters-app default (read only) 881392 881392 0 0.0
(read/write) 1697300 1697300 0 0.0
.bss 149296 149296 0 0.0
.data 2656 2656 0 0.0
.text 1536960 1536960 0 0.0
all-clusters-minimal-app default (read only) 882112 882112 0 0.0
(read/write) 1641340 1641340 0 0.0
.bss 148576 148576 0 0.0
.data 2656 2656 0 0.0
.text 1481720 1481720 0 0.0
light-app default (read only) 890432 890432 0 0.0
(read/write) 1560012 1560012 0 0.0
.bss 140464 140464 0 0.0
.data 2448 2448 0 0.0
.text 1408712 1408712 0 0.0
lock-app default (read only) 885936 885936 0 0.0
(read/write) 1597180 1597196 16 0.0
.bss 144944 144944 0 0.0
.data 2464 2464 0 0.0
.text 1441384 1441400 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808384 808376 -8 -0.0
bss 71096 71096 0 0.0
noinit 43488 43488 0 0.0
text 571310 571308 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830304 830304 0 0.0
bss 71952 71952 0 0.0
noinit 43488 43488 0 0.0
text 589386 589386 0 0.0

@woody-apple woody-apple added the spec Mismatch between spec and implementation label Aug 15, 2022
@woody-apple woody-apple enabled auto-merge (squash) August 16, 2022 01:06
@github-actions
Copy link

github-actions bot commented Aug 16, 2022 •
edited
Loading

PR #21890: Size comparison from 6322b8d to a40eb35

Increases (12 builds for bl602, cc13x2_26x2, efr32, linux, nrfconnect, p6)
platform target config section 6322b8d a40eb35 change % change
bl602 lighting-app bl602 (read/write) 1383090 1383098 8 0.0
.text 1050740 1050748 8 0.0
bl602+rpc (read/write) 1428602 1428610 8 0.0
.text 1082496 1082504 8 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 179216 179224 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637663 637671 8 0.0
.text 559388 559396 8 0.0
efr32 window-app BRD4161A (read/write) 1091644 1091660 16 0.0
.text 955092 955108 16 0.0
linux chip-tool debug (read only) 10724297 10725017 720 0.0
.text 8662340 8663060 720 0.0
chip-tool-ipv6only arm64 (read only) 10130420 1013114 720 0.0
.text 8006068 8006788 720 0.0
tv-casting-app debug (read only) 5415009 5415553 544 0.0
.text 4804210 4804754 544 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180083 1180099 16 0.0
text 814336 814340 4 0.0
p6 all-clusters-minimal-app default (read/write) 1641500 1641516 16 0.0
.text 1481880 1481896 16 0.0
light-app default (read/write) 1560204 1560220 16 0.0
.text 1408904 1408920 16 0.0
lock-app default (read/write) 1597372 1597388 16 0.0
.text 1441576 1441592 16 0.0
Decreases (4 builds for cc13x2_26x2, cyw30739, efr32, telink)
platform target config section 6322b8d a40eb35 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672295 672287 -8 -0.0
.text 583260 583252 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598970 598962 -8 -0.0
.app_xip_area 476324 476316 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1139124 1139108 -16 -0.0
.text 991520 991504 -16 -0.0
telink light-switch-app tlsr9518adk80d text 571274 571272 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6322b8d a40eb35 change % change
bl602 lighting-app bl602 (read/write) 1383090 1383098 8 0.0
.bss 119906 119906 0 0.0
.data 4480 4480 0 0.0
.text 1050740 1050748 8 0.0
bl602+rpc (read/write) 1428602 1428610 8 0.0
.bss 127346 127346 0 0.0
.data 4600 4600 0 0.0
.text 1082496 1082504 8 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672295 672287 -8 -0.0
(read/write) 179216 179224 8 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88719 88719 0 0.0
.text 583260 583252 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637663 637671 8 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77951 77951 0 0.0
.text 559388 559396 8 0.0
lock-ftd LP_CC2652R7 (read only) 674011 674011 0 0.0
(read/write) 167716 167716 0 0.0
.bss 71508 71508 0 0.0
.data 3296 3296 0 0.0
.rodata 76643 76643 0 0.0
.text 596888 596888 0 0.0
lock-mtd LP_CC2652R7 (read only) 656755 656755 0 0.0
(read/write) 180660 180660 0 0.0
.bss 67196 67196 0 0.0
.data 3296 3296 0 0.0
.rodata 101731 101731 0 0.0
.text 554544 554544 0 0.0
pump-app LP_CC2652R7 (read only) 684707 684707 0 0.0
(read/write) 157828 157828 0 0.0
.bss 71548 71548 0 0.0
.data 3296 3296 0 0.0
.rodata 89931 89931 0 0.0
.text 594292 594292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669175 669175 0 0.0
(read/write) 173480 173480 0 0.0
.bss 71668 71668 0 0.0
.data 3292 3292 0 0.0
.rodata 85487 85487 0 0.0
.text 583208 583208 0 0.0
shell LP_CC2652R7 (read only) 665002 665002 0 0.0
(read/write) 182028 182028 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85666 85666 0 0.0
.text 579020 579020 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586030 586030 0 0.0
.app_xip_area 462664 462664 0 0.0
.bss 65800 65800 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591838 591838 0 0.0
.app_xip_area 463688 463688 0 0.0
.bss 70584 70584 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598970 598962 -8 -0.0
.app_xip_area 476324 476316 -8 -0.0
.bss 65112 65112 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100212 1100212 0 0.0
.bss 133004 133004 0 0.0
.data 2068 2068 0 0.0
.text 965120 965120 0 0.0
BRD4161A+rpc (read/write) 1154464 1154464 0 0.0
.bss 149692 149692 0 0.0
.data 2280 2280 0 0.0
.text 1002472 1002472 0 0.0
BRD4161A+rs911x (read/write) 989608 989608 0 0.0
.bss 162344 162344 0 0.0
.data 2056 2056 0 0.0
.text 825188 825188 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139124 1139108 -16 -0.0
.bss 145520 145520 0 0.0
.data 2064 2064 0 0.0
.text 991520 991504 -16 -0.0
window-app BRD4161A (read/write) 1091644 1091660 16 0.0
.bss 134436 134436 0 0.0
.data 2096 2096 0 0.0
.text 955092 955108 16 0.0
esp32 all-clusters-app c3devkit (read only) 1029864 1029864 0 0.0
(read/write) 1488650 1488650 0 0.0
.dram0.bss 70864 70864 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217752 217752 0 0.0
.flash.text 1029864 1029864 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083255 1083255 0 0.0
(read/write) 490608 490608 0 0.0
.dram0.bss 76376 76376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248092 248092 0 0.0
.flash.text 1077871 1077871 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645044 645044 0 0.0
.bss 69848 69848 0 0.0
.data 2044 2044 0 0.0
.text 570424 570424 0 0.0
lock k32w0+release (read/write) 702588 702588 0 0.0
.bss 70320 70320 0 0.0
.data 2052 2052 0 0.0
.text 627488 627488 0 0.0
linux all-clusters-app debug (read only) 3033889 3033889 0 0.0
(read/write) 155920 155920 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85560 85560 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 274443 274443 0 0.0
.text 2580370 2580370 0 0.0
all-clusters-minimal-app debug (read only) 2873745 2873745 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274635 274635 0 0.0
.text 2422738 2422738 0 0.0
bridge-app debug+rpc (read only) 2372585 2372585 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203432 203432 0 0.0
.text 2006530 2006530 0 0.0
chip-tool debug (read only) 10724297 10725017 720 0.0
(read/write) 650912 650912 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615880 615880 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 556213 556213 0 0.0
.text 8662340 8663060 720 0.0
chip-tool-ipv6only arm64 (read only) 10130420 1013114 720 0.0
(read/write) 698657 698657 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643408 643408 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 487396 487396 0 0.0
.text 8006068 8006788 720 0.0
lighting-app debug+rpc (read only) 2596585 2596585 0 0.0
(read/write) 130176 130176 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72360 72360 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220208 220208 0 0.0
.text 2205666 2205666 0 0.0
lock-app debug (read only) 2580497 2580497 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237264 237264 0 0.0
.text 2176578 2176578 0 0.0
ota-provider-app debug (read only) 2357657 2357657 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209240 209240 0 0.0
.text 1984946 1984946 0 0.0
ota-requestor-app debug (read only) 2522873 2522873 0 0.0
(read/write) 127320 127320 0 0.0
.bss 50336 50336 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68728 68728 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216000 216000 0 0.0
.text 2134306 2134306 0 0.0
shell debug (read only) 2602177 2602177 0 0.0
(read/write) 142040 142040 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77160 77160 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 234546 234546 0 0.0
.text 2209282 2209282 0 0.0
thermostat-no-ble arm64 (read only) 2356836 2356836 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978592 1978592 0 0.0
tv-app debug (read only) 3173641 3173641 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258856 258856 0 0.0
.text 2725042 2725042 0 0.0
tv-casting-app debug (read only) 5415009 5415553 544 0.0
(read/write) 159088 159088 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98776 98776 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 342449 342449 0 0.0
.text 4804210 4804754 544 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454264 2454264 0 0.0
.bss 214692 214692 0 0.0
.data 5872 5872 0 0.0
.text 1416908 1416908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180083 1180099 16 0.0
bss 143375 143375 0 0.0
rodata 143428 143428 0 0.0
text 814336 814340 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159963 1159963 0 0.0
bss 142612 142612 0 0.0
rodata 135108 135108 0 0.0
text 803328 803328 0 0.0
p6 all-clusters-app default (read only) 881392 881392 0 0.0
(read/write) 1697476 1697476 0 0.0
.bss 149296 149296 0 0.0
.data 2656 2656 0 0.0
.text 1537136 1537136 0 0.0
all-clusters-minimal-app default (read only) 882112 882112 0 0.0
(read/write) 1641500 1641516 16 0.0
.bss 148576 148576 0 0.0
.data 2656 2656 0 0.0
.text 1481880 1481896 16 0.0
light-app default (read only) 890432 890432 0 0.0
(read/write) 1560204 1560220 16 0.0
.bss 140464 140464 0 0.0
.data 2448 2448 0 0.0
.text 1408904 1408920 16 0.0
lock-app default (read only) 885936 885936 0 0.0
(read/write) 1597372 1597388 16 0.0
.bss 144944 144944 0 0.0
.data 2464 2464 0 0.0
.text 1441576 1441592 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808344 808344 0 0.0
bss 71096 71096 0 0.0
noinit 43488 43488 0 0.0
text 571274 571272 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830272 830272 0 0.0
bss 71952 71952 0 0.0
noinit 43488 43488 0 0.0
text 589350 589350 0 0.0

@woody-apple woody-apple merged commit c24577d into project-chip:master Aug 16, 2022
woody-apple added a commit that referenced this pull request Aug 16, 2022
@tcarmelveilleux @woody-apple
Fix enums in admin commissioning cluster (#21890)
a2031c5 
* Fix enums in admin commissioning cluster

- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes #21887

Testing done:
- Unit tests still pass
- Cert tests still pass

* Update some tests to validate new codes

Co-authored-by: Justin Wood <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@tcarmelveilleux @woody-apple @isiu-apple
Fix enums in admin commissioning cluster (project-chip#21890)
41ba5cf 
* Fix enums in admin commissioning cluster

- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes project-chip#21887

Testing done:
- Unit tests still pass
- Cert tests still pass

* Update some tests to validate new codes

Co-authored-by: Justin Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@tehampson tehampson tehampson approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app cert controller darwin examples request cert blocker review - approved spec Mismatch between spec and implementation sve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Commissioning Cluster status codes are not spec compliant
4 participants
@tcarmelveilleux @msandstedt @tehampson @woody-apple