-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: convenience API Part 2 (Issue 16691) #21757
Merged
woody-apple
merged 2 commits into
project-chip:master
from
jtung-apple:issue-16691-convenience-API-part-2
Aug 15, 2022
Merged
Darwin: convenience API Part 2 (Issue 16691) #21757
woody-apple
merged 2 commits into
project-chip:master
from
jtung-apple:issue-16691-convenience-API-part-2
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtung-apple
changed the title
Issue 16691 - Darwin: convenience API Part 2
Darwin: convenience API Part 2 (Issue 16691)
Aug 9, 2022
PR #21757: Size comparison from a61e8e6 to 8da389f Increases (5 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2, efr32)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
force-pushed
the
issue-16691-convenience-API-part-2
branch
from
August 9, 2022 20:33
3249b16
to
b1c39e9
Compare
jtung-apple
force-pushed
the
issue-16691-convenience-API-part-2
branch
from
August 9, 2022 20:56
b1c39e9
to
6f6b0a1
Compare
PR #21757: Size comparison from b75e85a to 6f6b0a1 Increases (5 builds for bl602, cc13x2_26x2, telink)
Decreases (1 build for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jtung-apple
force-pushed
the
issue-16691-convenience-API-part-2
branch
from
August 10, 2022 01:22
6f6b0a1
to
de91ab3
Compare
PR #21757: Size comparison from ab7b3bd to de91ab3 Increases (2 builds for bl602, cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, esp32, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
force-pushed
the
issue-16691-convenience-API-part-2
branch
from
August 10, 2022 05:35
de91ab3
to
62fe820
Compare
PR #21757: Size comparison from 9b85c7a to 62fe820 Increases (4 builds for efr32, esp32, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jtung-apple
force-pushed
the
issue-16691-convenience-API-part-2
branch
from
August 13, 2022 06:32
62fe820
to
ea3d3aa
Compare
PR #21757: Size comparison from 1c613ad to ea3d3aa Increases (2 builds for bl602, cyw30739)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Tested locally with some hardcoded hack that validated read, write, and commands with the OnOff cluster. |
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
August 13, 2022 15:56
pullapprove
bot
requested review from
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller and
xylophone21
August 13, 2022 15:56
PR #21757: Size comparison from 1c613ad to 5e4fb24 Increases (2 builds for bl602, esp32)
Decreases (3 builds for k32w, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This was referenced Aug 16, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Issue 16691 - Darwin: convenience API Part 2 * Restyled change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part 2 of the convenience API (serialized and synchronous reads, expected values cache, attribute cache, and implicit subscription)
Tracked in issue #16691
Change overview
Testing
TBD