Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 12 bytes nonce for crypto #2174

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Conversation

pan-apple
Copy link
Contributor

Problem

CHIP is currently using 8 bytes nonce. It should be changed to 12 bytes.

Summary of Changes

Updated code to use 12 bytes of nonce (8 bytes from source node ID, and 4 bytes from message ID).

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 124 124
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_loc,0,509
.debug_abbrev,0,187
.text,124,124
.debug_frame,0,52
.symtab,0,48
.strtab,0,30
.debug_ranges,0,16
.debug_aranges,0,8
[Unmapped],0,-120
.debug_line,0,-568
.debug_macro,0,-589
.debug_info,0,-3478
.debug_str,0,-3863


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf text 202 202
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] -10 -10
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
text,202,202
.debug_abbrev,0,125
.symtab,0,48
.debug_line,0,45
.debug_frame,0,28
.debug_aranges,0,8
.debug_ranges,0,8
[Unmapped],0,1
[LOAD #1 [RWX]],-10,-10
.strtab,0,-197
.debug_str,0,-1305
.debug_info,0,-2109


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .text 224 224
chip-standalone-demo.out .eh_frame 72 72
chip-standalone-demo.out .eh_frame_hdr 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_loc,0,1081
.text,224,224
.debug_abbrev,0,182
.eh_frame,72,72
.strtab,0,30
.symtab,0,24
.debug_aranges,0,16
.eh_frame_hdr,8,8
.debug_line,0,-272
[Unmapped],0,-301
.debug_macro,0,-514
.debug_info,0,-1388
.debug_str,0,-3858


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 8 8
chip-wifi-echo.elf .flash.rodata -136 -136
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.shstrtab,0,176
.symtab,0,144
[Unmapped],0,134
.xt.prop._ZN4chip8BufBound3PutEPKvj,0,112
.xt.prop._ZN4chip8BufBound9AvailableEv,0,100
.debug_abbrev,0,91
.xt.prop._ZN4chip8BufBound3FitEv,0,88
.xt.prop._ZN4chip8BufBoundC2EPhj,0,76
.strtab,0,58
.xt.lit._ZN4chip8BufBound3PutEPKvj,0,48
.flash.text,8,8
.debug_aranges,0,-40
.debug_ranges,0,-40
.debug_frame,0,-120
.flash.rodata,-136,-136
.debug_line,0,-386
.debug_str,0,-1074
.debug_info,0,-4751


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@andy31415 andy31415 merged commit 66e6c42 into project-chip:master Aug 17, 2020
@pan-apple pan-apple deleted the iv_len branch August 17, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants