Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Fix status report handling in write handler (#21440)"… #21707

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Revert "Revert "Fix status report handling in write handler (#21440)"… #21707

merged 3 commits into from
Aug 9, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Aug 8, 2022 •
edited
Loading

… (#21701)"

This reverts commit 5ab5be3.

Problem

nrf tests don't have enable CONFIG_BUILD_FOR_HOST_UNIT_TEST, several other tests encounter the same issues, and have been disabled in nrf tests, need to disable this test in nrf tests.

Change overview

see above

Testing

presubmit

@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21707: Size comparison from 9665a20 to 0c7c4ce

Increases (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 9665a20 0c7c4ce change % change
bl602 lighting-app bl602 (read/write) 1379634 1379682 48 0.0
.text 1047876 1047920 44 0.0
bl602+rpc (read/write) 1424890 1424938 48 0.0
.text 1079380 1079424 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636303 636343 40 0.0
.text 558252 558292 40 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655139 32 0.0
.text 553320 553352 32 0.0
pump-app LP_CC2652R7 (read only) 682791 682823 32 0.0
.text 593060 593092 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667287 32 0.0
.text 581984 582016 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096052 48 0.0
.text 961068 961116 48 0.0
BRD4161A+rpc (read/write) 1150268 1150316 48 0.0
.text 998436 998484 48 0.0
BRD4161A+rs911x (read/write) 985284 985332 48 0.0
.text 821024 821072 48 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135992 32 0.0
.text 989052 989084 32 0.0
window-app BRD4161A (read/write) 1087736 1087784 48 0.0
.text 951328 951376 48 0.0
esp32 all-clusters-app c3devkit (read only) 1025862 1025888 26 0.0
.flash.text 1025862 1025888 26 0.0
m5stack (read only) 1079155 1079191 36 0.0
.flash.text 1073771 1073807 36 0.0
k32w light k32w0+release (read/write) 643340 643372 32 0.0
.text 568856 568888 32 0.0
lock k32w0+release (read/write) 700676 700708 32 0.0
.text 625712 625744 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859436 112 0.0
(read/write) 694145 694161 16 0.0
.data.rel.ro 639360 639384 24 0.0
.text 7767524 7767604 80 0.0
thermostat-no-ble arm64 (read only) 2349676 2349772 96 0.0
(read/write) 141649 141681 32 0.0
.data.rel.ro 75856 75880 24 0.0
.text 1972544 1972624 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452392 2452456 64 0.0
.text 1415036 1415100 64 0.0
p6 all-clusters-app default (read/write) 1690756 1690804 48 0.0
.text 1530552 1530600 48 0.0
all-clusters-minimal-app default (read/write) 1634948 1634996 48 0.0
.text 1475464 1475512 48 0.0
light-app default (read/write) 1553668 1553716 48 0.0
.text 1402504 1402552 48 0.0
lock-app default (read/write) 1590956 1591004 48 0.0
.text 1435296 1435344 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805860 24 0.0
text 569644 569668 24 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827668 24 0.0
text 587618 587640 22 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 9665a20 0c7c4ce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180576 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182148 182116 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159584 159552 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175256 175224 -32 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 9665a20 0c7c4ce change % change
bl602 lighting-app bl602 (read/write) 1379634 1379682 48 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047876 1047920 44 0.0
bl602+rpc (read/write) 1424890 1424938 48 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079380 1079424 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
(read/write) 180608 180576 -32 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636303 636343 40 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558252 558292 40 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655139 32 0.0
(read/write) 182148 182116 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101307 101307 0 0.0
.text 553320 553352 32 0.0
pump-app LP_CC2652R7 (read only) 682791 682823 32 0.0
(read/write) 159584 159552 -32 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 593060 593092 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667287 32 0.0
(read/write) 175256 175224 -32 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581984 582016 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096052 48 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961068 961116 48 0.0
BRD4161A+rpc (read/write) 1150268 1150316 48 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998436 998484 48 0.0
BRD4161A+rs911x (read/write) 985284 985332 48 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821024 821072 48 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135992 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989052 989084 32 0.0
window-app BRD4161A (read/write) 1087736 1087784 48 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951328 951376 48 0.0
esp32 all-clusters-app c3devkit (read only) 1025862 1025888 26 0.0
(read/write) 1487226 1487226 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216856 216856 0 0.0
.flash.text 1025862 1025888 26 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079155 1079191 36 0.0
(read/write) 489232 489232 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247252 247252 0 0.0
.flash.text 1073771 1073807 36 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643340 643372 32 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568856 568888 32 0.0
lock k32w0+release (read/write) 700676 700708 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625712 625744 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859436 112 0.0
(read/write) 694145 694161 16 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639384 24 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464508 464508 0 0.0
.text 7767524 7767604 80 0.0
thermostat-no-ble arm64 (read only) 2349676 2349772 96 0.0
(read/write) 141649 141681 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139620 139620 0 0.0
.text 1972544 1972624 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452392 2452456 64 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415036 1415100 64 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690756 1690804 48 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530552 1530600 48 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634948 1634996 48 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475464 1475512 48 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553668 1553716 48 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402504 1402552 48 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1590956 1591004 48 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435296 1435344 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805860 24 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569644 569668 24 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827668 24 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587618 587640 22 0.0

@yunhanw-google yunhanw-google changed the title Revert "Revert "Fix status report handling in write handler (#21440)"… [Debugging]Revert "Revert "Fix status report handling in write handler (#21440)"… Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21707: Size comparison from 9665a20 to 66a0f53

Increases (8 builds for bl602, linux, nrfconnect, telink)
platform target config section 9665a20 66a0f53 change % change
bl602 lighting-app bl602 (read/write) 1379634 1379762 128 0.0
.text 1047876 1047944 68 0.0
bl602+rpc (read/write) 1424890 1425010 120 0.0
.text 1079380 1079444 64 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9865596 6272 0.1
(read/write) 694145 694161 16 0.0
.data.rel.ro 639360 639384 24 0.0
.rodata 464508 464764 256 0.1
.text 7767524 7773508 5984 0.1
thermostat-no-ble arm64 (read only) 2349676 2349884 208 0.0
(read/write) 141649 141681 32 0.0
.data.rel.ro 75856 75880 24 0.0
.rodata 139620 139668 48 0.0
.text 1972544 1972688 144 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177679 1177795 116 0.0
rodata 142704 142756 52 0.0
text 812912 812964 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157735 1157851 116 0.0
rodata 134400 134452 52 0.0
text 802064 802116 52 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805936 100 0.0
text 569644 569688 44 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827744 100 0.0
text 587618 587662 44 0.0
Full report (8 builds for bl602, linux, nrfconnect, telink)
platform target config section 9665a20 66a0f53 change % change
bl602 lighting-app bl602 (read/write) 1379634 1379762 128 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047876 1047944 68 0.0
bl602+rpc (read/write) 1424890 1425010 120 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079380 1079444 64 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9865596 6272 0.1
(read/write) 694145 694161 16 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639384 24 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464508 464764 256 0.1
.text 7767524 7773508 5984 0.1
thermostat-no-ble arm64 (read only) 2349676 2349884 208 0.0
(read/write) 141649 141681 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139620 139668 48 0.0
.text 1972544 1972688 144 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177679 1177795 116 0.0
bss 143222 143222 0 0.0
rodata 142704 142756 52 0.0
text 812912 812964 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157735 1157851 116 0.0
bss 142460 142460 0 0.0
rodata 134400 134452 52 0.0
text 802064 802116 52 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805936 100 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569644 569688 44 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827744 100 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587618 587662 44 0.0

@yunhanw-google yunhanw-google force-pushed the feature/writer_handler branch 2 times, most recently from a36db6a to da267fc Compare August 8, 2022 08:04
@yunhanw-google yunhanw-google changed the title [Debugging]Revert "Revert "Fix status report handling in write handler (#21440)"… Revert "Revert "Fix status report handling in write handler (#21440)"… Aug 8, 2022
@yunhanw-google yunhanw-google force-pushed the feature/writer_handler branch from da267fc to f9957e7 Compare August 8, 2022 08:18
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21707: Size comparison from b52e56d to f9957e7

Increases (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, p6, telink)
platform target config section b52e56d f9957e7 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
.text 593076 593100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096116 48 0.0
.text 961132 961180 48 0.0
BRD4161A+rpc (read/write) 1150332 1150380 48 0.0
.text 998500 998548 48 0.0
BRD4161A+rs911x (read/write) 985356 985404 48 0.0
.text 821096 821144 48 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087856 48 0.0
.text 951400 951448 48 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025896 22 0.0
.flash.text 1025874 1025896 22 0.0
m5stack (read only) 1079171 1079203 32 0.0
.flash.text 1073787 1073819 32 0.0
k32w light k32w0+release (read/write) 643372 643404 32 0.0
.text 568888 568920 32 0.0
lock k32w0+release (read/write) 700764 700796 32 0.0
.text 625800 625832 32 0.0
linux all-clusters-app debug (read only) 3022857 3023001 144 0.0
.text 2571154 2571298 144 0.0
all-clusters-minimal-app debug (read only) 2864721 2864865 144 0.0
.text 2415554 2415698 144 0.0
bridge-app debug+rpc (read only) 2363993 2364137 144 0.0
.text 1999426 1999570 144 0.0
chip-tool debug (read only) 10444817 10444961 144 0.0
.text 8415252 8415396 144 0.0
chip-tool-ipv6only arm64 (read only) 9859420 9859532 112 0.0
(read/write) 694145 694161 16 0.0
.data.rel.ro 639360 639384 24 0.0
.text 7767572 7767652 80 0.0
lighting-app debug+rpc (read only) 2587625 2587769 144 0.0
.text 2198322 2198466 144 0.0
lock-app debug (read only) 2571825 2571969 144 0.0
.text 2169618 2169762 144 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473593 144 0.0
.text 2089010 2089154 144 0.0
shell debug (read only) 2593457 2593601 144 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349884 112 0.0
(read/write) 141649 141681 32 0.0
.data.rel.ro 75856 75880 24 0.0
.text 1972592 1972688 96 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5402769 144 0.0
.text 4794130 4794274 144 0.0
p6 all-clusters-app default (read/write) 1690828 1690876 48 0.0
.text 1530624 1530672 48 0.0
all-clusters-minimal-app default (read/write) 1635020 1635068 48 0.0
.text 1475536 1475584 48 0.0
light-app default (read/write) 1553740 1553788 48 0.0
.text 1402576 1402624 48 0.0
lock-app default (read/write) 1591028 1591076 48 0.0
.text 1435368 1435416 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
text 569664 569690 26 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827744 32 0.0
text 587636 587662 26 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section b52e56d f9957e7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180576 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159496 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175160 -32 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section b52e56d f9957e7 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
(read/write) 180608 180576 -32 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
(read/write) 159520 159496 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89295 0 0.0
.text 593076 593100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
(read/write) 175192 175160 -32 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84839 0 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096116 48 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961180 48 0.0
BRD4161A+rpc (read/write) 1150332 1150380 48 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998548 48 0.0
BRD4161A+rs911x (read/write) 985356 985404 48 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821144 48 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087856 48 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951448 48 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025896 22 0.0
(read/write) 1487282 1487282 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 216912 0 0.0
.flash.text 1025874 1025896 22 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079203 32 0.0
(read/write) 489288 489288 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247308 0 0.0
.flash.text 1073787 1073819 32 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643404 32 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568920 32 0.0
lock k32w0+release (read/write) 700764 700796 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625800 625832 32 0.0
linux all-clusters-app debug (read only) 3022857 3023001 144 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571298 144 0.0
all-clusters-minimal-app debug (read only) 2864721 2864865 144 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415698 144 0.0
bridge-app debug+rpc (read only) 2363993 2364137 144 0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999570 144 0.0
chip-tool debug (read only) 10444817 10444961 144 0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 533205 533205 0 0.0
.text 8415252 8415396 144 0.0
chip-tool-ipv6only arm64 (read only) 9859420 9859532 112 0.0
(read/write) 694145 694161 16 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639384 24 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464556 464556 0 0.0
.text 7767572 7767652 80 0.0
lighting-app debug+rpc (read only) 2587625 2587769 144 0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218736 0 0.0
.text 2198322 2198466 144 0.0
lock-app debug (read only) 2571825 2571969 144 0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235696 0 0.0
.text 2169618 2169762 144 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473593 144 0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2089154 144 0.0
shell debug (read only) 2593457 2593601 144 0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349884 112 0.0
(read/write) 141649 141681 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139668 0 0.0
.text 1972592 1972688 96 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257608 0 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5402769 144 0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794274 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452504 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415148 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690876 48 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530672 48 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635068 48 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475584 48 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553788 48 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402624 48 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591076 48 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435416 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569664 569690 26 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827744 32 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587662 26 0.0

@yunhanw-google yunhanw-google force-pushed the feature/writer_handler branch from f9957e7 to c856862 Compare August 8, 2022 15:10
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21707: Size comparison from 34a8570 to c856862

Increases (33 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, p6, telink)
platform target config section 34a8570 c856862 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670767 670807 40 0.0
.text 581980 582020 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682887 32 0.0
.text 593076 593108 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
k32w light k32w0+release (read/write) 643356 643404 48 0.0
.text 568872 568920 48 0.0
lock k32w0+release (read/write) 700764 700796 32 0.0
.text 625800 625832 32 0.0
linux all-clusters-app debug (read only) 3022857 3023001 144 0.0
.text 2571154 2571298 144 0.0
all-clusters-minimal-app debug (read only) 2864721 2864865 144 0.0
.text 2415554 2415698 144 0.0
bridge-app debug+rpc (read only) 2363993 2364137 144 0.0
.text 1999426 1999570 144 0.0
chip-tool debug (read only) 10445041 10445185 144 0.0
.text 8415412 8415556 144 0.0
chip-tool-ipv6only arm64 (read only) 9859644 9859756 112 0.0
(read/write) 694145 694161 16 0.0
.data.rel.ro 639360 639384 24 0.0
.text 7767716 7767796 80 0.0
lighting-app debug+rpc (read only) 2587625 2587769 144 0.0
.text 2198322 2198466 144 0.0
lock-app debug (read only) 2571825 2571969 144 0.0
.text 2169618 2169762 144 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473593 144 0.0
.text 2089010 2089154 144 0.0
shell debug (read only) 2593457 2593601 144 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349884 112 0.0
(read/write) 141649 141681 32 0.0
.data.rel.ro 75856 75880 24 0.0
.text 1972592 1972688 96 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5402769 144 0.0
.text 4794130 4794274 144 0.0
p6 all-clusters-app default (read/write) 1690828 1690876 48 0.0
.text 1530624 1530672 48 0.0
all-clusters-minimal-app default (read/write) 1635020 1635068 48 0.0
.text 1475536 1475584 48 0.0
light-app default (read/write) 1553740 1553788 48 0.0
.text 1402576 1402624 48 0.0
lock-app default (read/write) 1591028 1591076 48 0.0
.text 1435368 1435416 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
text 569662 569686 24 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827736 24 0.0
text 587636 587660 24 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 34a8570 c856862 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180616 180576 -40 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159488 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175160 -32 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 34a8570 c856862 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670767 670807 40 0.0
(read/write) 180616 180576 -40 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581980 582020 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682887 32 0.0
(read/write) 159520 159488 -32 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89295 0 0.0
.text 593076 593108 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
(read/write) 175192 175160 -32 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84839 0 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w0+release (read/write) 643356 643404 48 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568872 568920 48 0.0
lock k32w0+release (read/write) 700764 700796 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625800 625832 32 0.0
linux all-clusters-app debug (read only) 3022857 3023001 144 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571298 144 0.0
all-clusters-minimal-app debug (read only) 2864721 2864865 144 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415698 144 0.0
bridge-app debug+rpc (read only) 2363993 2364137 144 0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999570 144 0.0
chip-tool debug (read only) 10445041 10445185 144 0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 533269 533269 0 0.0
.text 8415412 8415556 144 0.0
chip-tool-ipv6only arm64 (read only) 9859644 9859756 112 0.0
(read/write) 694145 694161 16 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639384 24 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464636 464636 0 0.0
.text 7767716 7767796 80 0.0
lighting-app debug+rpc (read only) 2587625 2587769 144 0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218736 0 0.0
.text 2198322 2198466 144 0.0
lock-app debug (read only) 2571825 2571969 144 0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235696 0 0.0
.text 2169618 2169762 144 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473593 144 0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2089154 144 0.0
shell debug (read only) 2593457 2593601 144 0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349884 112 0.0
(read/write) 141649 141681 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139668 0 0.0
.text 1972592 1972688 96 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257608 0 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5402769 144 0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794274 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452504 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415148 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690876 48 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530672 48 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635068 48 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475584 48 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553788 48 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402624 48 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591076 48 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435416 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 569686 24 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827736 24 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587660 24 0.0

@yunhanw-google
Fix nrf test
600c2ba 
in nrf test, somehow CONFIG_BUILD_FOR_HOST_UNIT_TEST is disabled,
need to disable this test in nrf tests

apply restyle
@yunhanw-google yunhanw-google force-pushed the feature/writer_handler branch from c856862 to 600c2ba Compare August 8, 2022 16:06
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21707: Size comparison from 71c74b6 to 600c2ba

Increases (42 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 71c74b6 600c2ba change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655195 24 0.0
.text 553336 553360 24 0.0
pump-app LP_CC2652R7 (read only) 682855 682887 32 0.0
.text 593076 593108 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096116 48 0.0
.text 961132 961180 48 0.0
BRD4161A+rpc (read/write) 1150332 1150380 48 0.0
.text 998500 998548 48 0.0
BRD4161A+rs911x (read/write) 985356 985404 48 0.0
.text 821096 821144 48 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087856 48 0.0
.text 951400 951448 48 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025896 22 0.0
.flash.text 1025874 1025896 22 0.0
m5stack (read only) 1079171 1079203 32 0.0
.flash.text 1073787 1073819 32 0.0
k32w light k32w0+release (read/write) 643372 643404 32 0.0
.text 568888 568920 32 0.0
lock k32w0+release (read/write) 700748 700796 48 0.0
.text 625784 625832 48 0.0
linux all-clusters-app debug (read only) 3022857 3023001 144 0.0
.text 2571154 2571298 144 0.0
all-clusters-minimal-app debug (read only) 2864721 2864865 144 0.0
.text 2415554 2415698 144 0.0
bridge-app debug+rpc (read only) 2363993 2364137 144 0.0
.text 1999426 1999570 144 0.0
chip-tool debug (read only) 10472977 10473121 144 0.0
.text 8439348 8439492 144 0.0
chip-tool-ipv6only arm64 (read only) 9884684 9884780 96 0.0
(read/write) 695121 695153 32 0.0
.data.rel.ro 640336 640360 24 0.0
.text 7788772 7788852 80 0.0
lighting-app debug+rpc (read only) 2587625 2587769 144 0.0
.text 2198322 2198466 144 0.0
lock-app debug (read only) 2571825 2571969 144 0.0
.text 2169618 2169762 144 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473593 144 0.0
.text 2089010 2089154 144 0.0
shell debug (read only) 2593457 2593601 144 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349884 112 0.0
(read/write) 141649 141681 32 0.0
.data.rel.ro 75856 75880 24 0.0
.text 1972592 1972688 96 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5402769 144 0.0
.text 4794130 4794274 144 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177795 32 0.0
text 812932 812964 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157851 32 0.0
text 802084 802116 32 0.0
p6 all-clusters-app default (read/write) 1690828 1690876 48 0.0
.text 1530624 1530672 48 0.0
all-clusters-minimal-app default (read/write) 1635020 1635068 48 0.0
.text 1475536 1475584 48 0.0
light-app default (read/write) 1553740 1553788 48 0.0
.text 1402576 1402624 48 0.0
lock-app default (read/write) 1591028 1591076 48 0.0
.text 1435368 1435416 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
text 569662 569688 26 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827744 32 0.0
text 587636 587664 28 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 71c74b6 600c2ba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182060 -24 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159488 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175160 -32 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 71c74b6 600c2ba change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655195 24 0.0
(read/write) 182084 182060 -24 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553360 24 0.0
pump-app LP_CC2652R7 (read only) 682855 682887 32 0.0
(read/write) 159520 159488 -32 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89295 0 0.0
.text 593076 593108 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
(read/write) 175192 175160 -32 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84839 0 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096116 48 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961180 48 0.0
BRD4161A+rpc (read/write) 1150332 1150380 48 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998548 48 0.0
BRD4161A+rs911x (read/write) 985356 985404 48 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821144 48 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087856 48 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951448 48 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025896 22 0.0
(read/write) 1487282 1487282 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 216912 0 0.0
.flash.text 1025874 1025896 22 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079203 32 0.0
(read/write) 489288 489288 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247308 0 0.0
.flash.text 1073787 1073819 32 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643404 32 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568920 32 0.0
lock k32w0+release (read/write) 700748 700796 48 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625784 625832 48 0.0
linux all-clusters-app debug (read only) 3022857 3023001 144 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571298 144 0.0
all-clusters-minimal-app debug (read only) 2864721 2864865 144 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415698 144 0.0
bridge-app debug+rpc (read only) 2363993 2364137 144 0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999570 144 0.0
chip-tool debug (read only) 10472977 10473121 144 0.0
(read/write) 647424 647424 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 612776 612776 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 534965 534965 0 0.0
.text 8439348 8439492 144 0.0
chip-tool-ipv6only arm64 (read only) 9884684 9884780 96 0.0
(read/write) 695121 695153 32 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640336 640360 24 0.0
.dynamic 560 560 0 0.0
.got 13648 13648 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466284 466284 0 0.0
.text 7788772 7788852 80 0.0
lighting-app debug+rpc (read only) 2587625 2587769 144 0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218736 0 0.0
.text 2198322 2198466 144 0.0
lock-app debug (read only) 2571825 2571969 144 0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235696 0 0.0
.text 2169618 2169762 144 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473593 144 0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2089154 144 0.0
shell debug (read only) 2593457 2593601 144 0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349884 112 0.0
(read/write) 141649 141681 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139668 0 0.0
.text 1972592 1972688 96 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257608 0 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5402769 144 0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794274 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452504 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415148 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177795 32 0.0
bss 143222 143222 0 0.0
rodata 142756 142756 0 0.0
text 812932 812964 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157851 32 0.0
bss 142460 142460 0 0.0
rodata 134452 134452 0 0.0
text 802084 802116 32 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690876 48 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530672 48 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635068 48 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475584 48 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553788 48 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402624 48 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591076 48 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435416 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 569688 26 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827744 32 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587664 28 0.0

bzbarsky-apple
bzbarsky-apple reviewed Aug 8, 2022
View reviewed changes
src/app/WriteHandler.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21707: Size comparison from 71c74b6 to d2add5f

Increases (42 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 71c74b6 d2add5f change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
.text 593076 593100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096228 160 0.0
.text 961132 961292 160 0.0
BRD4161A+rpc (read/write) 1150332 1150492 160 0.0
.text 998500 998660 160 0.0
BRD4161A+rs911x (read/write) 985356 985748 392 0.0
.text 821096 821488 392 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136304 280 0.0
.text 989116 989396 280 0.0
window-app BRD4161A (read/write) 1087808 1087960 152 0.0
.text 951400 951552 152 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025914 40 0.0
(read/write) 1487282 1487370 88 0.0
.flash.rodata 216912 217000 88 0.0
.flash.text 1025874 1025914 40 0.0
m5stack (read only) 1079171 1079223 52 0.0
(read/write) 489288 489368 80 0.0
.flash.rodata 247308 247388 80 0.0
.flash.text 1073787 1073839 52 0.0
k32w light k32w0+release (read/write) 643372 643516 144 0.0
.text 568888 569032 144 0.0
lock k32w0+release (read/write) 700748 700908 160 0.0
.text 625784 625944 160 0.0
linux all-clusters-app debug (read only) 3022857 3024657 1800 0.1
(read/write) 155720 155752 32 0.0
.data.rel.ro 85384 85416 32 0.0
.text 2571154 2572882 1728 0.1
all-clusters-minimal-app debug (read only) 2864721 2864881 160 0.0
.text 2415554 2415714 160 0.0
bridge-app debug+rpc (read only) 2363993 2364441 448 0.0
.text 1999426 1999874 448 0.0
chip-tool debug (read only) 10472977 10474977 2000 0.0
.rodata 534965 535445 480 0.1
.text 8439348 8443172 3824 0.0
chip-tool-ipv6only arm64 (read only) 9884684 9885276 592 0.0
.rodata 466284 466764 480 0.1
.text 7788772 7791172 2400 0.0
lighting-app debug+rpc (read only) 2587625 2587785 160 0.0
.text 2198322 2198482 160 0.0
lock-app debug (read only) 2571825 2571985 160 0.0
.text 2169618 2169778 160 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473609 160 0.0
.text 2089010 2089170 160 0.0
shell debug (read only) 2593457 2593601 144 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349900 128 0.0
(read/write) 141649 141681 32 0.0
.data.rel.ro 75856 75880 24 0.0
.text 1972592 1972704 112 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5403329 704 0.0
.text 4794130 4794834 704 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177779 16 0.0
text 812932 812960 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157851 32 0.0
text 802084 802116 32 0.0
p6 all-clusters-app default (read/write) 1690828 1690980 152 0.0
.text 1530624 1530776 152 0.0
all-clusters-minimal-app default (read/write) 1635020 1635180 160 0.0
.text 1475536 1475696 160 0.0
light-app default (read/write) 1553740 1553892 152 0.0
.text 1402576 1402728 152 0.0
lock-app default (read/write) 1591028 1591172 144 0.0
.text 1435368 1435512 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
text 569662 569688 26 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827736 24 0.0
text 587636 587660 24 0.0
Decreases (8 builds for cc13x2_26x2, linux)
platform target config section 71c74b6 d2add5f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180576 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159496 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175160 -32 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
linux chip-tool debug (read/write) 647424 646464 -960 -0.1
.data.rel.ro 612776 611800 -976 -0.2
chip-tool-ipv6only arm64 (read/write) 695121 694177 -944 -0.1
.data.rel.ro 640336 639384 -952 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 71c74b6 d2add5f change % change
bl602 lighting-app bl602 (read/write) 1379714 1379762 48 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047944 44 0.0
bl602+rpc (read/write) 1424970 1425010 40 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079444 44 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
(read/write) 180608 180576 -32 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636343 32 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558292 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
(read/write) 159520 159496 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89295 0 0.0
.text 593076 593100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667351 32 0.0
(read/write) 175192 175160 -32 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84839 0 0.0
.text 582000 582032 32 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096228 160 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961292 160 0.0
BRD4161A+rpc (read/write) 1150332 1150492 160 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998660 160 0.0
BRD4161A+rs911x (read/write) 985356 985748 392 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821488 392 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136304 280 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989396 280 0.0
window-app BRD4161A (read/write) 1087808 1087960 152 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951552 152 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025914 40 0.0
(read/write) 1487282 1487370 88 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 217000 88 0.0
.flash.text 1025874 1025914 40 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079223 52 0.0
(read/write) 489288 489368 80 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247388 80 0.0
.flash.text 1073787 1073839 52 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643516 144 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 569032 144 0.0
lock k32w0+release (read/write) 700748 700908 160 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625784 625944 160 0.0
linux all-clusters-app debug (read only) 3022857 3024657 1800 0.1
(read/write) 155720 155752 32 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85416 32 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2572882 1728 0.1
all-clusters-minimal-app debug (read only) 2864721 2864881 160 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415714 160 0.0
bridge-app debug+rpc (read only) 2363993 2364441 448 0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999874 448 0.0
chip-tool debug (read only) 10472977 10474977 2000 0.0
(read/write) 647424 646464 -960 -0.1
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 612776 611800 -976 -0.2
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 534965 535445 480 0.1
.text 8439348 8443172 3824 0.0
chip-tool-ipv6only arm64 (read only) 9884684 9885276 592 0.0
(read/write) 695121 694177 -944 -0.1
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640336 639384 -952 -0.1
.dynamic 560 560 0 0.0
.got 13648 13648 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466284 466764 480 0.1
.text 7788772 7791172 2400 0.0
lighting-app debug+rpc (read only) 2587625 2587785 160 0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218736 0 0.0
.text 2198322 2198482 160 0.0
lock-app debug (read only) 2571825 2571985 160 0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235696 0 0.0
.text 2169618 2169778 160 0.0
ota-provider-app debug (read only) 2349409 2349553 144 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1978162 1978306 144 0.0
ota-requestor-app debug (read only) 2473449 2473609 160 0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2089170 160 0.0
shell debug (read only) 2593457 2593601 144 0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2202066 144 0.0
thermostat-no-ble arm64 (read only) 2349772 2349900 128 0.0
(read/write) 141649 141681 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139668 0 0.0
.text 1972592 1972704 112 0.0
tv-app debug (read only) 3167265 3167409 144 0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257608 0 0.0
.text 2719890 2720034 144 0.0
tv-casting-app debug (read only) 5402625 5403329 704 0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794834 704 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452504 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415148 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177779 16 0.0
bss 143222 143222 0 0.0
rodata 142756 142756 0 0.0
text 812932 812960 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157851 32 0.0
bss 142460 142460 0 0.0
rodata 134452 134452 0 0.0
text 802084 802116 32 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690980 152 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530776 152 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635180 160 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475696 160 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553892 152 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402728 152 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591172 144 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435512 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805936 24 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 569688 26 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827736 24 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587660 24 0.0

@yunhanw-google yunhanw-google mentioned this pull request Aug 8, 2022
Open
@yunhanw-google yunhanw-google enabled auto-merge (squash) August 9, 2022 01:10
@yunhanw-google yunhanw-google merged commit 7a981fd into project-chip:master Aug 9, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @bzbarsky-apple @isiu-apple
Revert "Revert "Fix status report handling in write handler (project-…
11a5d5d 
…chip#21440)"… (project-chip#21707)

* Revert "Revert "Fix status report handling in write handler (project-chip#21440)" (project-chip#21701)"

This reverts commit 5ab5be3.

* Fix nrf test

in nrf test, somehow CONFIG_BUILD_FOR_HOST_UNIT_TEST is disabled,
need to disable this test in nrf tests

apply restyle

* Update src/app/WriteHandler.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @yufengwangca @bzbarsky-apple