Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the PakeError message type. #21239

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Remove the PakeError message type. #21239

merged 1 commit into from
Jul 27, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes #21128

Problem

See above.

Change overview

See above.

Testing

Should have no behavior changes, just less confusing code.

@restyled-io restyled-io bot mentioned this pull request Jul 26, 2022
Closed
@bzbarsky-apple
Remove the PakeError message type.
d7838ac 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes project-chip#21128
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21239: Size comparison from 79e8c9e to d7838ac

Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 79e8c9e d7838ac change % change
bl602 lighting-app bl602 (read/write) 1381450 1381498 48 0.0
.text 1051524 1051572 48 0.0
bl602+rpc (read/write) 1426866 1426914 48 0.0
.text 1083188 1083236 48 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668475 56 0.0
.text 579692 579748 56 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634059 40 0.0
.text 556060 556100 40 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671607 40 0.0
.text 594624 594664 40 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653835 40 0.0
.text 552152 552192 40 0.0
pump-app LP_CC2652R7 (read only) 680999 681055 56 0.0
.text 591340 591396 56 0.0
pump-controller-app LP_CC2652R7 (read only) 666759 666815 56 0.0
.text 581272 581328 56 0.0
shell LP_CC2652R7 (read only) 660894 660942 48 0.0
.text 575404 575452 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583374 40 0.0
.app_xip_area 460472 460512 40 0.0
lock cyw930739m2evb_01 (read/write) 589254 589294 40 0.0
.app_xip_area 461664 461704 40 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589138 56 0.0
.app_xip_area 467036 467092 56 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088208 48 0.0
.text 952816 952864 48 0.0
BRD4161A+rpc (read/write) 1142452 1142500 48 0.0
.text 990216 990264 48 0.0
BRD4161A+rs911x (read/write) 952704 952752 48 0.0
.text 809644 809692 48 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128320 64 0.0
.text 981820 981884 64 0.0
window-app BRD4161A (read/write) 1081636 1081684 48 0.0
.text 944788 944836 48 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022152 40 0.0
.flash.text 1022112 1022152 40 0.0
m5stack (read only) 1075771 1075811 40 0.0
.flash.text 1070387 1070427 40 0.0
k32w light k32w0+release (read/write) 641776 641808 32 0.0
.text 567292 567324 32 0.0
lock k32w0+release (read/write) 699056 699104 48 0.0
.text 624124 624172 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9809652 9810500 848 0.0
.text 7760852 7761748 896 0.0
thermostat-no-ble arm64 (read only) 2342156 2342876 720 0.0
.text 1965520 1966272 752 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449328 2449392 64 0.0
.text 1411972 1412036 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177179 48 0.0
text 812408 812460 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157231 48 0.0
text 801716 801768 52 0.0
p6 all-clusters-app default (read/write) 1687044 1687092 48 0.0
.text 1526880 1526928 48 0.0
all-clusters-minimal-app default (read/write) 1631148 1631196 48 0.0
.text 1471704 1471752 48 0.0
light-app default (read/write) 1551516 1551548 32 0.0
.text 1400376 1400408 32 0.0
lock-app default (read/write) 1589116 1589148 32 0.0
.text 1433504 1433536 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799692 32 0.0
text 567188 567220 32 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819792 32 0.0
text 583758 583792 34 0.0
Decreases (8 builds for cc13x2_26x2, linux)
platform target config section 79e8c9e d7838ac change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182940 182884 -56 -0.0
lock-ftd LP_CC2652R7 (read/write) 169984 169944 -40 -0.0
lock-mtd LP_CC2652R7 (read/write) 183444 183404 -40 -0.0
pump-app LP_CC2652R7 (read/write) 161384 161328 -56 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175760 175704 -56 -0.0
shell LP_CC2652R7 (read/write) 185984 185936 -48 -0.0
linux chip-tool-ipv6only arm64 .rodata 466500 466452 -48 -0.0
thermostat-no-ble arm64 .rodata 139588 139556 -32 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 79e8c9e d7838ac change % change
bl602 lighting-app bl602 (read/write) 1381450 1381498 48 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051524 1051572 48 0.0
bl602+rpc (read/write) 1426866 1426914 48 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083236 48 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668419 668475 56 0.0
(read/write) 182940 182884 -56 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579692 579748 56 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634059 40 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556100 40 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671607 40 0.0
(read/write) 169984 169944 -40 -0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594664 40 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653835 40 0.0
(read/write) 183444 183404 -40 -0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552192 40 0.0
pump-app LP_CC2652R7 (read only) 680999 681055 56 0.0
(read/write) 161384 161328 -56 -0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89175 0 0.0
.text 591340 591396 56 0.0
pump-controller-app LP_CC2652R7 (read only) 666759 666815 56 0.0
(read/write) 175760 175704 -56 -0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85007 0 0.0
.text 581272 581328 56 0.0
shell LP_CC2652R7 (read only) 660894 660942 48 0.0
(read/write) 185984 185936 -48 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575452 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583374 40 0.0
.app_xip_area 460472 460512 40 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589294 40 0.0
.app_xip_area 461664 461704 40 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589138 56 0.0
.app_xip_area 467036 467092 56 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088208 48 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 952864 48 0.0
BRD4161A+rpc (read/write) 1142452 1142500 48 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990264 48 0.0
BRD4161A+rs911x (read/write) 952704 952752 48 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809692 48 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128320 64 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 981884 64 0.0
window-app BRD4161A (read/write) 1081636 1081684 48 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 944836 48 0.0
esp32 all-clusters-app c3devkit (read only) 1022112 1022152 40 0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216264 0 0.0
.flash.text 1022112 1022152 40 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075811 40 0.0
(read/write) 488608 488608 0 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246668 0 0.0
.flash.text 1070387 1070427 40 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641808 32 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567324 32 0.0
lock k32w0+release (read/write) 699056 699104 48 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624172 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9809652 9810500 848 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466500 466452 -48 -0.0
.text 7760852 7761748 896 0.0
thermostat-no-ble arm64 (read only) 2342156 2342876 720 0.0
(read/write) 141393 141393 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75672 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139556 -32 -0.0
.text 1965520 1966272 752 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449392 64 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1412036 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177179 48 0.0
bss 143132 143132 0 0.0
rodata 142660 142660 0 0.0
text 812408 812460 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157231 48 0.0
bss 142368 142368 0 0.0
rodata 134192 134192 0 0.0
text 801716 801768 52 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687092 48 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1526928 48 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631196 48 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471752 48 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551548 32 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400408 32 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589148 32 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433536 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799692 32 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567188 567220 32 0.0
lighting-app tlsr9518adk80d (read/write) 819760 819792 32 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583758 583792 34 0.0

@woody-apple woody-apple merged commit bd5924d into project-chip:master Jul 27, 2022
@bzbarsky-apple bzbarsky-apple deleted the nix-PakeError branch July 27, 2022 18:07
github-actions bot pushed a commit that referenced this pull request Jul 27, 2022
@bzbarsky-apple @web-flow
Remove the PakeError message type. (#21239)
9c04a64 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes #21128
woody-apple added a commit that referenced this pull request Jul 28, 2022
@woody-apple @bzbarsky-apple
Remove the PakeError message type. (#21239) (#21300)
9ab1a94 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes #21128

Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Remove the PakeError message type. (project-chip#21239)
1bf7a83 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes project-chip#21128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@emargolis emargolis emargolis approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PASE enums used in the SDK do not match the spec
3 participants
@bzbarsky-apple @emargolis @woody-apple