Run crypto tests (only) under BoringSSL from unified build #21168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #21168: Size comparison from be1d492 to 3b657ad Decreases (3 builds for bl602, telink)
Full report (25 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
mspang
force-pushed
the
for-chip/boringssl-unified
branch
from
3b657ad to
675f634
Compare
|
PR #21168: Size comparison from be1d492 to 675f634 Decreases (1 build for telink)
Full report (18 builds for bl602, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 25, 2022
Add a new default option enable_host_clang_boringssl_crypto_tests to the unified build that runs the tests from src/crypto and src/credentials only. Also add an option enable_host_clang_boringssl_build that runs all of the tests (and builds any tools), which is not enabled by default. This gives some coverage to BoringSSL without costing a full build (it would be even cheaper if we could swap out the CryptoPAL via the command line..)
mspang
force-pushed
the
for-chip/boringssl-unified
branch
from
675f634 to
af7b957
Compare
emargolis
approved these changes
Jul 25, 2022
|
PR #21168: Size comparison from be1d492 to af7b957 Increases (2 builds for efr32, esp32)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
Add a new default option enable_host_clang_boringssl_crypto_tests to the unified build that runs the tests from src/crypto and src/credentials only. Also add an option enable_host_clang_boringssl_build that runs all of the tests (and builds any tools), which is not enabled by default. This gives some coverage to BoringSSL without costing a full build (it would be even cheaper if we could swap out the CryptoPAL via the command line..)
woody-apple
added a commit
that referenced
this pull request
Jul 29, 2022
…21200) Add a new default option enable_host_clang_boringssl_crypto_tests to the unified build that runs the tests from src/crypto and src/credentials only. Also add an option enable_host_clang_boringssl_build that runs all of the tests (and builds any tools), which is not enabled by default. This gives some coverage to BoringSSL without costing a full build (it would be even cheaper if we could swap out the CryptoPAL via the command line..) Co-authored-by: Michael Spang <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#21168) Add a new default option enable_host_clang_boringssl_crypto_tests to the unified build that runs the tests from src/crypto and src/credentials only. Also add an option enable_host_clang_boringssl_build that runs all of the tests (and builds any tools), which is not enabled by default. This gives some coverage to BoringSSL without costing a full build (it would be even cheaper if we could swap out the CryptoPAL via the command line..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's no coverage of BoringSSL from unified build.
Change overview
Add a new default option enable_host_clang_boringssl_crypto_tests
to the unified build that runs the tests from src/crypto and
src/credentials only.
Also add an option enable_host_clang_boringssl_build that runs all of
the tests (and builds any tools), which is not enabled by default.
This gives some coverage to BoringSSL without costing a full build
(it would be even cheaper if we could swap out the CryptoPAL via
the command line..)
Testing
gn_build.sh