Improve discovery logging a bit. #21056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) In shared "platform" discovery code, log when we discovered an operational id or a commissionable instance and what the TXT records were. 2) In Darwin code, do Discovery, not DeviceLayer logging and improve some of the log messages. The intent is to make it a little clearer on failure where in the pipeline things stop propagating information.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
Damian-Nordic
approved these changes
Jul 21, 2022
woody-apple
approved these changes
Jul 21, 2022
|
PR #21056: Size comparison from 83deb47 to 2988a60 Increases (13 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #21056: Size comparison from 83deb47 to 3684a3f Increases above 0.2%:
Increases (23 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
1) In shared "platform" discovery code, log when we discovered an operational id or a commissionable instance and what the TXT records were. 2) In Darwin code, do Discovery, not DeviceLayer logging and improve some of the log messages. The intent is to make it a little clearer on failure where in the pipeline things stop propagating information.
woody-apple
added a commit
that referenced
this pull request
Jul 21, 2022
1) In shared "platform" discovery code, log when we discovered an operational id or a commissionable instance and what the TXT records were. 2) In Darwin code, do Discovery, not DeviceLayer logging and improve some of the log messages. The intent is to make it a little clearer on failure where in the pipeline things stop propagating information. Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
1) In shared "platform" discovery code, log when we discovered an operational id or a commissionable instance and what the TXT records were. 2) In Darwin code, do Discovery, not DeviceLayer logging and improve some of the log messages. The intent is to make it a little clearer on failure where in the pipeline things stop propagating information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or a commissionable instance and what the TXT records were.
log messages.
The intent is to make it a little clearer on failure where in the pipeline
things stop propagating information.
Problem
Can't tell whether we never got "all" addresses or whether consumer just ignored the result.
Change overview
Log when we plan to notify the consumer.
Testing
Ran chip-tool, saw the updated logs.