Add support for BoringSSL CHIPCryptoPAL backend #20824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OpenSSL still works - Updated necessary differences - Added tests for Matter-compliant AES-CCM128 with 16 byte tag, 13 byte nonce - Added build files
|
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
tcarmelveilleux
changed the title
|
PR #20824: Size comparison from 6185156 to b8971f6 Increases (2 builds for cc13x2_26x2, telink)
Decreases (1 build for cc13x2_26x2)
Full report (23 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
|
|
PR #20824: Size comparison from 6185156 to b793585 Increases (2 builds for telink)
Decreases (12 builds for k32w, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
This is great! Shouldn't everything in Also, are all the platform-specific assembly files Matter-specific or can those come in as submodule(s) too? |
I followed the conventions for src folder from the boringssl source generation script. We can clean-up the build more once we start using the asm. For now, those are generated from the repos at regular interval. |
|
PR #20824: Size comparison from cd4ab7c to 445ac4e Increases (4 builds for cc13x2_26x2, esp32, k32w)
Decreases (14 builds for cc13x2_26x2, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 16, 2022
andy31415
approved these changes
Jul 18, 2022
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this pull request
Jul 18, 2022
PR project-chip#20824 moved some defines out of CryptoBuildConfig.h by mistake. This caused some defines to be globalized but only in GN builds. Fixes project-chip#20883 This PR brings back the defines in CryptoBuildConfig.h and fixes what's needed for that to build Testing done: - Unit tests still pass - Integration tests still pass
woody-apple
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Fix CryptoBuildConfig.h usage PR #20824 moved some defines out of CryptoBuildConfig.h by mistake. This caused some defines to be globalized but only in GN builds. Fixes #20883 This PR brings back the defines in CryptoBuildConfig.h and fixes what's needed for that to build Testing done: - Unit tests still pass - Integration tests still pass * Add BoringSSL coverage to rotating ID build
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Fix CryptoBuildConfig.h usage PR #20824 moved some defines out of CryptoBuildConfig.h by mistake. This caused some defines to be globalized but only in GN builds. Fixes #20883 This PR brings back the defines in CryptoBuildConfig.h and fixes what's needed for that to build Testing done: - Unit tests still pass - Integration tests still pass * Add BoringSSL coverage to rotating ID build
woody-apple
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Add boringssl submodule * Ran GN build generator from boringssl repos, added files * Boring SSL fully working - OpenSSL still works - Updated necessary differences - Added tests for Matter-compliant AES-CCM128 with 16 byte tag, 13 byte nonce - Added build files * Restyled * Fix CI, remove some forgotten remainders Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 19, 2022
* Fix CryptoBuildConfig.h usage PR #20824 moved some defines out of CryptoBuildConfig.h by mistake. This caused some defines to be globalized but only in GN builds. Fixes #20883 This PR brings back the defines in CryptoBuildConfig.h and fixes what's needed for that to build Testing done: - Unit tests still pass - Integration tests still pass * Add BoringSSL coverage to rotating ID build Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
third_party/boringssl/repo/src.third_party/boringssl/repoare auto-generated by a builder script that copies the assembly versions by platform in a way that allows platform selection by GN later down the line (see https://github.com/google/boringssl/blob/master/util/generate_build_files.py)Testing