-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove various non-Matter clusters from Matter XML. #20705
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-non-Matter-clusters
Jul 14, 2022
Merged
Remove various non-Matter clusters from Matter XML. #20705
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-non-Matter-clusters
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
July 13, 2022 23:04
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 13, 2022 23:04
pullapprove
bot
added
review - pending
and removed
examples
darwin
controller
app
labels
Jul 13, 2022
PR #20705: Size comparison from 61dd4d0 to b450822 Decreases (6 builds for esp32, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 14, 2022
jmartinez-silabs
approved these changes
Jul 14, 2022
This removes clusters that are not part of Matter core or appclusters specs from the XML files Matter pulls in.
bzbarsky-apple
force-pushed
the
remove-non-Matter-clusters
branch
from
July 14, 2022 14:39
b450822
to
6293d95
Compare
PR #20705: Size comparison from 8051b3b to 6293d95 Increases (1 build for telink)
Decreases (5 builds for esp32, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
This removes clusters that are not part of Matter core or appclusters specs from the XML files Matter pulls in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes clusters that are not part of Matter core or appclusters
specs from the XML files Matter pulls in.
Problem
Various non-Matter clusters in XML, ending up in public APIs generated from the XML.
Change overview
Remove the clusters.
Testing
All the existing tests should pass.