-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add separate feature bits for dl schedules #20670
Merged
andy31415
merged 2 commits into
project-chip:master
from
Morozov-5F:feature/add-separate-feature-bits-for-dl-schedules
Jul 15, 2022
Merged
Feature/add separate feature bits for dl schedules #20670
andy31415
merged 2 commits into
project-chip:master
from
Morozov-5F:feature/add-separate-feature-bits-for-dl-schedules
Jul 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda and
mlepage-google
July 13, 2022 11:15
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 13, 2022 11:15
PR #20670: Size comparison from e7915ea to f94e51a Increases (21 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Morozov-5F
force-pushed
the
feature/add-separate-feature-bits-for-dl-schedules
branch
from
July 13, 2022 12:40
f94e51a
to
f830c41
Compare
PR #20670: Size comparison from e7915ea to f830c41 Increases (24 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Jul 13, 2022
andy31415
reviewed
Jul 13, 2022
andy31415
reviewed
Jul 13, 2022
Morozov-5F
force-pushed
the
feature/add-separate-feature-bits-for-dl-schedules
branch
from
July 13, 2022 15:27
f830c41
to
7055b63
Compare
PR #20670: Size comparison from 51e41f9 to 7055b63 Increases (21 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (5 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 13, 2022
andy31415
reviewed
Jul 13, 2022
bzbarsky-apple
approved these changes
Jul 15, 2022
andy31415
approved these changes
Jul 15, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
* [#19793] Implement separate feature bits for schedules in the door lock cluster * Update auto-generated files
Morozov-5F
deleted the
feature/add-separate-feature-bits-for-dl-schedules
branch
July 15, 2022 20:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
DL_*
andTC_DRLK_*
tests against the Linux lock app.