-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up P6 SDK paths #20624
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
mspang:for-chip/p6-sdk-paths
Jul 12, 2022
Merged
Clean up P6 SDK paths #20624
bzbarsky-apple
merged 1 commit into
project-chip:master
from
mspang:for-chip/p6-sdk-paths
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new variable p6_sdk_root for the actual root of the SDK repository and use this to specify SDK paths. This avoids forcing locating the SDK submodule at a particular location in the Matter SDK directory, as projects may want to use a different layout.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248 and
isiu-apple
July 12, 2022 16:25
pullapprove
bot
requested review from
jtung-apple,
xylophone21,
kghost,
yufengwangca,
kpschoedel,
yunhanw-google,
lazarkov,
LuDuda,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller and
woody-apple
July 12, 2022 16:25
andy31415
approved these changes
Jul 12, 2022
PR #20624: Size comparison from 761a9e9 to 39351ce Increases (5 builds for bl602, cc13x2_26x2, cyw30739, telink)
Decreases (1 build for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
Introduce a new variable p6_sdk_root for the actual root of the SDK repository and use this to specify SDK paths. This avoids forcing locating the SDK submodule at a particular location in the Matter SDK directory, as projects may want to use a different layout.
ajwak
pushed a commit
to ajwak/connectedhomeip
that referenced
this pull request
Jul 13, 2022
Introduce a new variable p6_sdk_root for the actual root of the SDK repository and use this to specify SDK paths. This avoids forcing locating the SDK submodule at a particular location in the Matter SDK directory, as projects may want to use a different layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
P6 SDK sources are specified relative to
${chip_root}
which preventsalternate repository layouts.
Change overview
Introduce a new variable p6_sdk_root for the actual root of the SDK
repository and use this to specify SDK paths.
This avoids forcing locating the SDK submodule at a particular location
in the Matter SDK directory, as projects may want to use a different
layout.
Testing
CI