-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Support for specifying absolute timeouts for Invoke/Write #20531
Merged
woody-apple
merged 4 commits into
project-chip:master
from
mrjerryjohns:python/add-invokewrite-timeout
Jul 21, 2022
Merged
Python: Support for specifying absolute timeouts for Invoke/Write #20531
woody-apple
merged 4 commits into
project-chip:master
from
mrjerryjohns:python/add-invokewrite-timeout
Jul 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang and
rgoliver
July 9, 2022 15:02
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 9, 2022 15:03
mrjerryjohns
force-pushed
the
python/add-invokewrite-timeout
branch
from
July 9, 2022 15:10
7a02ba6
to
d5e9940
Compare
PR #20531: Size comparison from 776c06d to d5e9940 Decreases (1 build for esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 9, 2022
woody-apple
approved these changes
Jul 14, 2022
msandstedt
approved these changes
Jul 15, 2022
PR #20531: Size comparison from 6185156 to 40449ac Increases (1 build for telink)
Decreases (1 build for esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This adds support for specifying an absolute timeout for ChipDeviceController.SendCommand and ChipDeviceController.WriteAttribute methods. This timeout is used to bound both mDNS discovery and the subsequent IM interaction.
woody-apple
force-pushed
the
python/add-invokewrite-timeout
branch
from
July 19, 2022 23:14
40449ac
to
f5cea26
Compare
PR #20531: Size comparison from df636ce to f5cea26 Increases (4 builds for bl602, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20531: Size comparison from 5132358 to eadcca8 Increases (1 build for cc13x2_26x2)
Decreases (4 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
…0531) * Python: Support for specifying absolute timeouts for Invoke/Write This adds support for specifying an absolute timeout for ChipDeviceController.SendCommand and ChipDeviceController.WriteAttribute methods. This timeout is used to bound both mDNS discovery and the subsequent IM interaction. * Review feedback * Review feedback
woody-apple
added a commit
that referenced
this pull request
Jul 21, 2022
…0531) (#21035) * Python: Support for specifying absolute timeouts for Invoke/Write This adds support for specifying an absolute timeout for ChipDeviceController.SendCommand and ChipDeviceController.WriteAttribute methods. This timeout is used to bound both mDNS discovery and the subsequent IM interaction. * Review feedback * Review feedback Co-authored-by: Jerry Johns <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…oject-chip#20531) * Python: Support for specifying absolute timeouts for Invoke/Write This adds support for specifying an absolute timeout for ChipDeviceController.SendCommand and ChipDeviceController.WriteAttribute methods. This timeout is used to bound both mDNS discovery and the subsequent IM interaction. * Review feedback * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying an absolute timeout for
ChipDeviceController.SendCommand
andChipDeviceController.WriteAttribute
methods. This timeout is used to bound both mDNS discovery andthe subsequent IM interaction.
This sets the possibility for adding negative tests to the REPL that are expected to timeout, and can consequently be bounded in execution.
Testing