-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Platform builds for all-clusters and all-clusters-minimal apps #20480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
July 8, 2022 09:33
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 8, 2022 09:33
pullapprove
bot
added
review - pending
examples
github
scripts
workflows
and removed
examples
scripts
github
workflows
labels
Jul 8, 2022
PR #20480: Size comparison from 996f5f3 to 4019d77 Increases (4 builds for esp32, k32w, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2022
#20480) * [Tizen] Platform build for all-clusters-minimal app * Add Tizen all-clusters-minimal app build to build script * [Tizen] Platform build for all-clusters app
woody-apple
added a commit
that referenced
this pull request
Jul 9, 2022
#20480) (#20528) * [Tizen] Platform build for all-clusters-minimal app * Add Tizen all-clusters-minimal app build to build script * [Tizen] Platform build for all-clusters app Co-authored-by: Arkadiusz Bokowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tizen platform lacks all-clusters(-minimal) apps. The all-clusters-app is used by Matter test suite, so it will be required for future platform tests.
Change overview
Testing
Verified that all-clusters(-minimal) apps can be commissioned and tested simple
chip-tool doorlock lock-door
chip-tool doorlock unlock-door
actions to verify whether app works correctly. Additionally, compilation will be verified by CI.