Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AccessControl] Ensure extension attribute data are valid TLV per spec #20425

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[AccessControl] Ensure extension attribute data are valid TLV per spec #20425

merged 1 commit into from
Jul 8, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

Per spec the AccessControlExtensionStruct.data field constraints are defined as:
The contents SHALL consist of a top-level anonymous list; each list element SHALL include a profile-specific tag encoded in fully qualified form.

But nothing enforces that.

Change overview

  • Enforce the extension data format.

Testing

It was tested using manually generated TLV matching the constraints from the AccessControl test plan.
Please let me know if I misread the spec, both for generating the octet string, and for validating them.

For reference:

_OK_EMPTY   	        (2): 1718
D_OK_SINGLE   	       (71): 17D00000F1FF01003D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E670018
D_OK_FULL   	    (128): 17D00000F1FF01003D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E6700D00000F1FF02003148656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E7420616761696E2E2E2E2E2E0018
D_BAD_LENGTH      (129): 17D00000F1FF01003D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E6700D00000F1FF02003248656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E7420616761696E2E2E2E2E2E2E0018
D_BAD_STRUCT   	 (2): 1518
D_BAD_LIST   	       (72): 3701D00000F1FF01003D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E670018
D_BAD_ELEM   	       (65): 17103D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E670018
D_BAD_OVERFLOW   (72): 17D00000F1FF01003D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E670018FF
D_BAD_UNDERFLOW(70): 17D00000F1FF01003D48656C6C6F20576F726C642E205468697320697320612073696E676C6520656C656D656E74206C6976696E6720617320612063686172737472696E6700
D_BAD_NONE   		 (0):

@vivien-apple vivien-apple self-assigned this Jul 7, 2022
@boring-cyborg boring-cyborg bot added the app label Jul 7, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 7, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited
Loading

PR #20425: Size comparison from ef588e1 to a84be52

Increases above 0.2%:

platform target config section ef588e1 a84be52 change % change
efr32 lighting-app BRD4161A+rpc (read/write) 151948 1135148 983200 647.1
Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ef588e1 a84be52 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665587 144 0.0
.text 577060 577204 144 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631587 144 0.0
.text 553812 553956 144 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668487 144 0.0
.text 591656 591800 144 0.0
lock-mtd LP_CC2652R7 (read only) 617751 617903 152 0.0
.text 541176 541328 152 0.0
pump-app LP_CC2652R7 (read only) 677703 677847 144 0.0
.text 588788 588932 144 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663671 144 0.0
.text 578752 578896 144 0.0
shell LP_CC2652R7 (read only) 657934 658070 136 0.0
.text 572772 572908 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579278 144 0.0
.app_xip_area 457904 458048 144 0.0
lock cyw930739m2evb_01 (read/write) 584862 585006 144 0.0
.app_xip_area 458896 459040 144 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582350 144 0.0
.app_xip_area 461824 461968 144 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080812 160 0.0
.text 945588 945748 160 0.0
BRD4161A+rpc (read/write) 151948 1135148 983200 647.1
.text 983032 983192 160 0.0
BRD4161A+rs911x (read/write) 946756 946916 160 0.0
.text 803920 804080 160 0.0
lock-app BRD4161A+wf200 (read/write) 1127288 1127432 144 0.0
.text 981020 981164 144 0.0
window-app BRD4161A (read/write) 1074436 1074612 176 0.0
.text 937868 938044 176 0.0
esp32 all-clusters-app c3devkit (read only) 1019368 1019498 130 0.0
.flash.text 1019368 1019498 130 0.0
m5stack (read only) 1073243 1073359 116 0.0
.flash.text 1067859 1067975 116 0.0
k32w light k32w061+release (read/write) 658192 658320 128 0.0
.text 580884 581012 128 0.0
lock k32w061+release (read/write) 684788 684916 128 0.0
.text 607004 607132 128 0.0
linux thermostat-no-ble arm64 (read only) 2592644 2593636 992 0.0
.text 2187520 2188512 992 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447400 2447528 128 0.0
.text 1410044 1410172 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1173951 144 0.0
text 810640 810776 136 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154835 144 0.0
text 800360 800500 140 0.0
p6 all-clusters-app default (read/write) 2563088 2563248 160 0.0
.text 1521352 1521512 160 0.0
all-clusters-minimal-app default (read/write) 2508952 2509128 176 0.0
.text 1467216 1467392 176 0.0
light-app default (read/write) 2439240 2439416 176 0.0
.text 1397504 1397680 176 0.0
lock-app default (read/write) 2465672 2465832 160 0.0
.text 1423936 1424096 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796764 128 0.0
text 565130 565258 128 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816592 128 0.0
text 581452 581582 130 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section ef588e1 a84be52 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185780 185636 -144 -0.1
lock-ftd LP_CC2652R7 (read/write) 173024 172880 -144 -0.1
pump-app LP_CC2652R7 (read/write) 164512 164368 -144 -0.1
pump-controller-app LP_CC2652R7 (read/write) 178808 178664 -144 -0.1
shell LP_CC2652R7 (read/write) 188792 188656 -136 -0.1
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ef588e1 a84be52 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665587 144 0.0
(read/write) 185780 185636 -144 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577060 577204 144 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631587 144 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553956 144 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668487 144 0.0
(read/write) 173024 172880 -144 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591656 591800 144 0.0
lock-mtd LP_CC2652R7 (read only) 617751 617903 152 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541176 541328 152 0.0
pump-app LP_CC2652R7 (read only) 677703 677847 144 0.0
(read/write) 164512 164368 -144 -0.1
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588932 144 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663671 144 0.0
(read/write) 178808 178664 -144 -0.1
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578896 144 0.0
shell LP_CC2652R7 (read only) 657934 658070 136 0.0
(read/write) 188792 188656 -136 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572772 572908 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579278 144 0.0
.app_xip_area 457904 458048 144 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 584862 585006 144 0.0
.app_xip_area 458896 459040 144 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582350 144 0.0
.app_xip_area 461824 461968 144 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080812 160 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945748 160 0.0
BRD4161A+rpc (read/write) 151948 1135148 983200 647.1
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983192 160 0.0
BRD4161A+rs911x (read/write) 946756 946916 160 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 804080 160 0.0
lock-app BRD4161A+wf200 (read/write) 1127288 1127432 144 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981020 981164 144 0.0
window-app BRD4161A (read/write) 1074436 1074612 176 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 938044 176 0.0
esp32 all-clusters-app c3devkit (read only) 1019368 1019498 130 0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019368 1019498 130 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073243 1073359 116 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067859 1067975 116 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658320 128 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 581012 128 0.0
lock k32w061+release (read/write) 684788 684916 128 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607004 607132 128 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9971956 9971956 0 0.0
(read/write) 680689 680689 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 619624 619624 0 0.0
.dynamic 528 528 0 0.0
.got 13488 13488 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475572 475572 0 0.0
.text 7944804 7944804 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2593636 992 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2188512 992 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447400 2447528 128 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410044 1410172 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1173951 144 0.0
bss 142900 142900 0 0.0
rodata 141376 141376 0 0.0
text 810640 810776 136 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154835 144 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800500 140 0.0
p6 all-clusters-app default (read/write) 2563088 2563248 160 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521352 1521512 160 0.0
all-clusters-minimal-app default (read/write) 2508952 2509128 176 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467392 176 0.0
light-app default (read/write) 2439240 2439416 176 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397680 176 0.0
lock-app default (read/write) 2465672 2465832 160 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1424096 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796764 128 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565130 565258 128 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816592 128 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581452 581582 130 0.0

@vivien-apple vivien-apple force-pushed the AccessControl_CheckTLV branch from a84be52 to 6cca121 Compare July 7, 2022 14:37
@cjandhyala cjandhyala added the sve label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited
Loading

PR #20425: Size comparison from acbe9cd to 6cca121

Increases above 0.2%:

platform target config section acbe9cd 6cca121 change % change
efr32 lighting-app BRD4161A+rpc (read/write) 151948 1135148 983200 647.1
Increases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section acbe9cd 6cca121 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665651 665795 144 0.0
.text 577268 577412 144 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631579 136 0.0
.text 553812 553948 136 0.0
lock-ftd LP_CC2652R7 (read only) 668551 668695 144 0.0
.text 591864 592008 144 0.0
lock-mtd LP_CC2652R7 (read only) 617951 618095 144 0.0
.text 541376 541520 144 0.0
pump-app LP_CC2652R7 (read only) 677703 677847 144 0.0
.text 588788 588932 144 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663671 144 0.0
.text 578752 578896 144 0.0
shell LP_CC2652R7 (read only) 658150 658270 120 0.0
.text 572988 573108 120 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579278 144 0.0
.app_xip_area 457904 458048 144 0.0
lock cyw930739m2evb_01 (read/write) 585070 585206 136 0.0
.app_xip_area 459104 459240 136 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582350 144 0.0
.app_xip_area 461824 461968 144 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080812 160 0.0
.text 945588 945748 160 0.0
BRD4161A+rpc (read/write) 151948 1135148 983200 647.1
.text 983032 983192 160 0.0
BRD4161A+rs911x (read/write) 946756 946916 160 0.0
.text 803920 804080 160 0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1128104 144 0.0
.text 981692 981836 144 0.0
window-app BRD4161A (read/write) 1074436 1074612 176 0.0
.text 937868 938044 176 0.0
esp32 all-clusters-app c3devkit (read only) 1019476 1019606 130 0.0
.flash.text 1019476 1019606 130 0.0
m5stack (read only) 1073383 1073503 120 0.0
.flash.text 1067999 1068119 120 0.0
k32w light k32w061+release (read/write) 658192 658320 128 0.0
.text 580884 581012 128 0.0
lock k32w061+release (read/write) 684964 685092 128 0.0
.text 607180 607308 128 0.0
linux all-clusters-app debug (read only) 2957793 2959041 1248 0.0
.text 2517058 2518306 1248 0.0
all-clusters-minimal-app debug (read only) 2810337 2811585 1248 0.0
.text 2370082 2371330 1248 0.1
bridge-app debug+rpc (read only) 2312761 2314009 1248 0.1
.text 1953074 1954322 1248 0.1
lighting-app debug+rpc (read only) 2548249 2549497 1248 0.0
.text 2164674 2165922 1248 0.1
lock-app debug (read only) 2512865 2514097 1232 0.0
.text 2119074 2120306 1232 0.1
ota-provider-app debug (read only) 2319585 2320817 1232 0.1
.text 1953394 1954626 1232 0.1
ota-requestor-app debug (read only) 2436737 2437985 1248 0.1
.text 2058354 2059602 1248 0.1
shell debug (read only) 2548121 2549369 1248 0.0
.text 2163378 2164626 1248 0.1
thermostat-no-ble arm64 (read only) 2592644 2593636 992 0.0
.text 2187520 2188512 992 0.0
tv-app debug (read only) 3099713 3100961 1248 0.0
.text 2662882 2664130 1248 0.0
tv-casting-app debug (read only) 5562817 5564065 1248 0.0
.text 4941746 4942994 1248 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447488 2447616 128 0.0
.text 1410132 1410260 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174623 128 0.0
text 810916 811056 140 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154835 144 0.0
text 800360 800500 140 0.0
p6 all-clusters-app default (read/write) 2563896 2564072 176 0.0
.text 1522160 1522336 176 0.0
all-clusters-minimal-app default (read/write) 2508952 2509128 176 0.0
.text 1467216 1467392 176 0.0
light-app default (read/write) 2439240 2439416 176 0.0
.text 1397504 1397680 176 0.0
lock-app default (read/write) 2466496 2466656 160 0.0
.text 1424760 1424920 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796764 128 0.0
text 565130 565258 128 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816592 128 0.0
text 581452 581582 130 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section acbe9cd 6cca121 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185572 185428 -144 -0.1
lock-ftd LP_CC2652R7 (read/write) 172816 172672 -144 -0.1
pump-app LP_CC2652R7 (read/write) 164512 164368 -144 -0.1
pump-controller-app LP_CC2652R7 (read/write) 178808 178664 -144 -0.1
shell LP_CC2652R7 (read/write) 188576 188456 -120 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section acbe9cd 6cca121 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665651 665795 144 0.0
(read/write) 185572 185428 -144 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577268 577412 144 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631579 136 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553948 136 0.0
lock-ftd LP_CC2652R7 (read only) 668551 668695 144 0.0
(read/write) 172816 172672 -144 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591864 592008 144 0.0
lock-mtd LP_CC2652R7 (read only) 617951 618095 144 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541376 541520 144 0.0
pump-app LP_CC2652R7 (read only) 677703 677847 144 0.0
(read/write) 164512 164368 -144 -0.1
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588932 144 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663671 144 0.0
(read/write) 178808 178664 -144 -0.1
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578896 144 0.0
shell LP_CC2652R7 (read only) 658150 658270 120 0.0
(read/write) 188576 188456 -120 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572988 573108 120 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579278 144 0.0
.app_xip_area 457904 458048 144 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585070 585206 136 0.0
.app_xip_area 459104 459240 136 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582350 144 0.0
.app_xip_area 461824 461968 144 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080812 160 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945748 160 0.0
BRD4161A+rpc (read/write) 151948 1135148 983200 647.1
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983192 160 0.0
BRD4161A+rs911x (read/write) 946756 946916 160 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 804080 160 0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1128104 144 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981692 981836 144 0.0
window-app BRD4161A (read/write) 1074436 1074612 176 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 938044 176 0.0
esp32 all-clusters-app c3devkit (read only) 1019476 1019606 130 0.0
(read/write) 1485458 1485458 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215344 215344 0 0.0
.flash.text 1019476 1019606 130 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073383 1073503 120 0.0
(read/write) 487536 487536 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245796 245796 0 0.0
.flash.text 1067999 1068119 120 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658320 128 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 581012 128 0.0
lock k32w061+release (read/write) 684964 685092 128 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607180 607308 128 0.0
linux all-clusters-app debug (read only) 2957793 2959041 1248 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263549 263549 0 0.0
.text 2517058 2518306 1248 0.0
all-clusters-minimal-app debug (read only) 2810337 2811585 1248 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265245 265245 0 0.0
.text 2370082 2371330 1248 0.1
bridge-app debug+rpc (read only) 2312761 2314009 1248 0.1
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1953074 1954322 1248 0.1
chip-tool debug (read only) 10275665 10275665 0 0.0
(read/write) 618432 618432 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 584080 584080 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 513461 513461 0 0.0
.text 8339444 8339444 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9971940 9971940 0 0.0
(read/write) 680689 680689 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 619624 619624 0 0.0
.dynamic 528 528 0 0.0
.got 13488 13488 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475556 475556 0 0.0
.text 7944804 7944804 0 0.0
lighting-app debug+rpc (read only) 2548249 2549497 1248 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213608 213608 0 0.0
.text 2164674 2165922 1248 0.1
lock-app debug (read only) 2512865 2514097 1232 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228648 228648 0 0.0
.text 2119074 2120306 1232 0.1
ota-provider-app debug (read only) 2319585 2320817 1232 0.1
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1953394 1954626 1232 0.1
ota-requestor-app debug (read only) 2436737 2437985 1248 0.1
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2058354 2059602 1248 0.1
shell debug (read only) 2548121 2549369 1248 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227666 227666 0 0.0
.text 2163378 2164626 1248 0.1
thermostat-no-ble arm64 (read only) 2592644 2593636 992 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2188512 992 0.0
tv-app debug (read only) 3099713 3100961 1248 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2662882 2664130 1248 0.0
tv-casting-app debug (read only) 5562817 5564065 1248 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343209 343209 0 0.0
.text 4941746 4942994 1248 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447488 2447616 128 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410132 1410260 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174623 128 0.0
bss 142900 142900 0 0.0
rodata 141776 141776 0 0.0
text 810916 811056 140 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154835 144 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800500 140 0.0
p6 all-clusters-app default (read/write) 2563896 2564072 176 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1522160 1522336 176 0.0
all-clusters-minimal-app default (read/write) 2508952 2509128 176 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467392 176 0.0
light-app default (read/write) 2439240 2439416 176 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397680 176 0.0
lock-app default (read/write) 2466496 2466656 160 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1424760 1424920 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796764 128 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565130 565258 128 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816592 128 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581452 581582 130 0.0

@woody-apple woody-apple added spec Mismatch between spec and implementation and removed sve labels Jul 7, 2022
@woody-apple woody-apple enabled auto-merge (squash) July 7, 2022 18:07
@woody-apple woody-apple merged commit e6e43fa into project-chip:master Jul 8, 2022
github-actions bot pushed a commit that referenced this pull request Jul 8, 2022
@vivien-apple @web-flow
[AccessControl] Ensure extension attribute data are valid TLV per spec (
1033f6a 
#20425)
andy31415 pushed a commit that referenced this pull request Jul 9, 2022
@woody-apple @vivien-apple
[AccessControl] Ensure extension attribute data are valid TLV per spec (
7c5c3f0 
#20425) (#20511)

Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees

@vivien-apple vivien-apple

Labels
app review - approved spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @mrjerryjohns @woody-apple @cjandhyala