Add pre-execution command callback. #20357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. This callback is called before every command gets executed.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
msandstedt and
mspang
mrjerryjohns
reviewed
Jul 7, 2022
mrjerryjohns
suggested changes
Jul 7, 2022
… exec" (add fabricIndex parameter)
done |
…andReceivedCallback (project-chip#20361)
Done, last commit contains extension for MatterPreCommandReceivedCallback(), added chip::Access::SubjectDescriptor parameter |
bzbarsky-apple
approved these changes
Jul 12, 2022
mrjerryjohns
approved these changes
Jul 12, 2022
|
PR #20357: Size comparison from 415ee2f to c93d8d2 Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Added the callback that could be implemented by application uses Matter. This callback is called before every command gets executed. * Restyled by astyle * Restyled by clang-format * Restyled by whitespace * Regenerate all callback-stub.cpp and IMCLusterCommandHandler.cpp * Restyled by astyle * Restyled by clang-format * Add pre-execution command callback. #20361 - move MatterPreExecuteCommandCallback() into DispatchSingleClusterCommand() - regenerate all IMClusterCommandHandler.cpp files * Restyled by astyle * Restyled by clang-format * Removed a modified MTRCallbackBridge.mm file from pull request * Removed a modified zzz_generated/chip-tool/zap-generated/test/Commands.h file from pull request * remove all autogenerated files from PR * Use existing callback MatterPreCommandReceivedCallback to notify "cmd exec" (add fabricIndex parameter) * Added parameter subjectDescriptor into callbacks Matter(Pre/Post)CommandReceivedCallback (#20361) Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jan 23, 2023
Damian-Nordic
pushed a commit
that referenced
this pull request
Jan 23, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes it is required to perform some kind of preparation work before command is handled. As it seems, there's no way for app to be notified before the command is executed.
Change overview
This PR adds the callback that could be implemented by application uses Matter. This callback is called before every command gets executed.
Resolve #20361