-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 20336 - Darwin: rename MTRDevice and MTRClsutersObjc files and classes #20345
Issue 20336 - Darwin: rename MTRDevice and MTRClsutersObjc files and classes #20345
Conversation
Fast tracking platform changes |
PR #20345: Size comparison from 5b603f3 to 83228d1 Increases (1 build for nrfconnect)
Decreases (2 builds for telink)
Full report (8 builds for cyw30739, mbed, nrfconnect, telink)
|
83228d1
to
5c08d39
Compare
5c08d39
to
aa27d8b
Compare
PR #20345: Size comparison from 5b603f3 to f6e8c39 Increases (2 builds for nrfconnect, telink)
Full report (8 builds for cyw30739, mbed, nrfconnect, telink)
|
PR #20345: Size comparison from 5b603f3 to 078e67b Increases (1 build for cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
078e67b
to
ee03605
Compare
ee03605
to
1828732
Compare
author Jeff Tung <[email protected]> 1657083114 -0700 committer Jeff Tung <[email protected]> 1657128282 -0700 Issue 20336 - Darwin: rename MTRDevice and MTRClsutersObjc files and classes
6584324
to
707d60b
Compare
PR #20345: Size comparison from a9da0d8 to 707d60b Increases (1 build for cc13x2_26x2)
Decreases (1 build for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20345: Size comparison from a9da0d8 to cb6f46a Increases (1 build for telink)
Decreases (2 builds for cyw30739, telink)
Full report (16 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20345: Size comparison from a9da0d8 to 4dc3fcd Increases above 0.2%:
Increases (5 builds for cc13x2_26x2, linux, telink)
Decreases (4 builds for cc13x2_26x2, esp32, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20345: Size comparison from a9da0d8 to d4e74a9 Increases above 0.2%:
Increases (5 builds for cc13x2_26x2, linux, telink)
Decreases (3 builds for cc13x2_26x2, linux)
Full report (32 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect, p6, telink)
|
…classes (#20345) * Issue 20336 - Darwin: rename MTRDevice and MTRClsutersObjc files and classes * Restyled by astyle * Restyled by clang-format * Restyled by jq * Restyled by prettier-json * uncommited zap generated file MTRBaseClusters.mm * Restyled by astyle * Restyled by clang-format * Restyled by jq * Restyled by prettier-json Co-authored-by: Restyled.io <[email protected]>
…classes (#20345) (#20409) * Issue 20336 - Darwin: rename MTRDevice and MTRClsutersObjc files and classes * Restyled by astyle * Restyled by clang-format * Restyled by jq * Restyled by prettier-json * uncommited zap generated file MTRBaseClusters.mm * Restyled by astyle * Restyled by clang-format * Restyled by jq * Restyled by prettier-json Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Jeff Tung <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Problem
Copying from Issue #20336 : "As part of the plan to move towards a synchronous API for Darwin Framework, the async APIs as exposed by MTRDevice and MTRClustersObjc should be renamed to show these are low level functionality headers/classes."
Change overview
Renamed MTRDevice and MTRClustersObjc files and classes to reflect these being low-level API.
Testing
Built both CHIPTool and Darwin Framework locally with Xcode.