-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Set LE Random Address for BLE Advertising #20301
Merged
tcarmelveilleux
merged 1 commit into
project-chip:master
from
shubhamdp:esp32_fix_ble_addr
Jul 5, 2022
Merged
[ESP32] Set LE Random Address for BLE Advertising #20301
tcarmelveilleux
merged 1 commit into
project-chip:master
from
shubhamdp:esp32_fix_ble_addr
Jul 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
July 5, 2022 09:45
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 5, 2022 09:45
ESP32-C3 devices were advertising with the same address on every boot. Because of this even with different discriminator chip-tool was connecting with the random device. These changes make sure that we set the random address for advertising
shubhamdp
force-pushed
the
esp32_fix_ble_addr
branch
from
July 5, 2022 10:03
d4bfa6e
to
dfc6b23
Compare
PR #20301: Size comparison from 13ac032 to dfc6b23 Increases (3 builds for esp32, k32w)
Decreases (3 builds for cc13x2_26x2, cyw30739, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Jul 5, 2022
tcarmelveilleux
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ESP32-C3 devices were advertising with the same address on every boot.
Because of this even with different discriminator chip-tool was
connecting with the random device.
Change overview
These changes make sure that we set the random address for advertising
Testing
Tested manually: Flashed 3 C3 devices with all-clusters-app and different discriminator and verified that chip-tool indeed connects to the device with provided discriminator