chip-tool PersistentStorage: support for CASE resumption keys #20220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
| @@ -95,6 +117,10 @@ CHIP_ERROR PersistentStorage::Init(const char * name) | |||
| mName = name; | |||
| mConfig.parse(ifs); | |||
| ifs.close(); | |||
|
|
|||
| // inipp.h cannot deal with keys containing '=' and does not support escapes either | |||
| AdjustConfig(mConfig.sections); | |||
There was a problem hiding this comment.
We could escape the key any way we want though.
There was a problem hiding this comment.
Yes but not in any standard way such as backslash=. It would also slow down all operations. This way we only do it once.
tcarmelveilleux
approved these changes
Jul 1, 2022
|
PR #20220: Size comparison from 6c6dca3 to bf2dec2 Increases (5 builds for cc13x2_26x2, linux, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 1, 2022
| std::string key = it->first; | ||
| const char * value = it->second.c_str(); | ||
|
|
||
| while (value[0] == '=') |
There was a problem hiding this comment.
So this is assuming that values don't actually ever start with '=', right? I guess that's true because we base64-encode the values? Might be worth documenting that...
msandstedt
suggested changes
Jul 2, 2022
|
In the meantime fixed by #20239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool PersistentStorage is broken with CASE resumption which uses keys containing '='. It can write the key/value pairs but upon read they end up something different. As a result console is flooded with error messages since none of the keys can be found.
Change overview
Make sure that CASE resumption key/values read match the written ones.
Testing